Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <eff0021c-5a9b-5c44-3fb7-24387cf13e16@kernel.org>
Date:   Thu, 17 Mar 2022 12:49:54 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.2
Subject: Re: [PATCH v4] net:bonding:Add support for IPV6 RLB to balance-alb
 mode
Content-Language: en-US
To:     Sun Shouxin <sunshouxin@chinatelecom.cn>, j.vosburgh@gmail.com,
        vfalico@gmail.com, andy@greyhouse.net, davem@davemloft.net,
        kuba@kernel.org, yoshfuji@linux-ipv6.org, oliver@neukum.org
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        huyd12@chinatelecom.cn
References: <20220317061521.23985-1-sunshouxin@chinatelecom.cn>
From:   David Ahern <dsahern@kernel.org>
In-Reply-To: <20220317061521.23985-1-sunshouxin@chinatelecom.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/17/22 12:15 AM, Sun Shouxin wrote:
> This patch is implementing IPV6 RLB for balance-alb mode.
> 
> Suggested-by: Hu Yadi <huyd12@chinatelecom.cn>
> Signed-off-by: Sun Shouxin <sunshouxin@chinatelecom.cn>
> ---
> changelog:
> v1-->v2:
> -Remove ndisc_bond_send_na and refactor ndisc_send_na.
> -In rlb_nd_xmit, if the lladdr is not local, return curr_active_slave.
> -Don't send neighbor advertisement message when receiving
>  neighbor advertisement message in rlb6_update_entry_from_na.
> 
> v2-->v3:
> -Don't export ndisc_send_na.
> -Use ipv6_stub->ndisc_send_na to replace ndisc_send_na
>  in rlb6_update_client.
> 
> v3-->v4:
> -Submit all code at a whole patch.

you misunderstood Jakub's comment. The code should evolve with small,
focused patches and each patch needs to compile and function correctly
(ie., no breakage).

You need to respond to Jiri's question about why this feature is needed.
After that:

1. patch 1 adds void *data to ndisc_send_na stub function and
ndisc_send_na direct function. Update all places that use both
ndisc_send_na to pass NULL as the data parameter.

2. patch 2 refactors ndisc_send_na to handle the new data argument

3. patch 3 exports any IPv6 functions. explain why each needs to be
exported.

4. patch 4 .... bonding changes. (bonding folks can respond on how to
introduce that change).