Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <bb6aefcf-92aa-ef41-27de-1e3e0b227761@suse.com>
Date:   Thu, 17 Mar 2022 08:34:55 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] scsi:libiscsi: remove unnecessary memset in
 iscsi_conn_setup
Content-Language: en-US
To:     Wenchao Hao <haowenchao@huawei.com>,
        Chris Leech <cleech@redhat.com>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>,
        Mike Christie <michael.christie@oracle.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Zhiqiang Liu <liuzhiqiang26@huawei.com>, Wu Bo <wubo40@huawei.com>,
        linfeilong@huawei.com
References: <20220317150116.194140-1-haowenchao@huawei.com>
From:   Lee Duncan <lduncan@suse.com>
In-Reply-To: <20220317150116.194140-1-haowenchao@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MTVJdE9zY2g5b3ZCM05NK2hRRlErWUlaMTJCZTZkdTFZRzMxWk5ydjBOaTRs?=
 =?utf-8?B?a3NXRmc2VjJLVEF3a3BQa0ZrQ2RKdGIzZDBOeGJnVUN5cCtNYVFQL3c0b21R?=
 =?utf-8?B?TWhIMTI3dzVRUW0raVcwVnZ5NUpyQi96UEhuQXZMSW94d25GTUpMZWVVY2s0?=
 =?utf-8?B?S1lEeFZiSW14S2xCU0N5M2pqS21kNFdtbU1qdWNNOVdSK3ZjWG1hU3dFcWUr?=
 =?utf-8?B?ZnZRVUg4L2REenJVbTAvaWZoSE53c1FtN2ROVzNNNXZLeHNCbWJCQnVhVm52?=
 =?utf-8?B?MHpja3pUd2VXQlB1RWwvQmNoaUxHTDAxU1puK3hWSWlLSDY4M1I4K3hvOGp0?=
 =?utf-8?B?UXJZUS9yRzFnOVZ5YW1oQ1dYdHRIY2tWcjk1dkNZSkg4SFBXeTBGTjNrZnlN?=
 =?utf-8?B?ZVZzRmJJcGVScFVwUnl6eTNUek40VUlnbWUwc213NExLRDZ6S1p0azBiMDFB?=
 =?utf-8?B?c25BeFhHeldwcEY5dnErd1U2VkliQnBxRGhESDJ1QVlvYjlDMmdJRnNQVk5a?=
 =?utf-8?B?dzIwYncxNmNhYURLV2NsVmZiQW44OWdnVXEwdm9ia25TSGlNK245ZDNkK29k?=
 =?utf-8?B?Yk1KUTZvRS93TlVBTmMzOURzMWtBMTVLc2NXN0RzNkhzTmNzbStTVkI5L2xR?=
 =?utf-8?B?cjVlTFlCb01oUC9xam12ZStFTEFXYUxmM0hzYVJ0UHBWSzB0RXJraHdjMlBI?=
 =?utf-8?B?R1cxUnVNeVZoVFM4MU4zYXNnc1NpWlVzeDQxSDV4Q05jR0IxeUlwc0J4aEgv?=
 =?utf-8?B?eWVUWGV2dXZDMHl2OG5ydjdFUGRoOE5TMWJ6RElWVnlyVkJITFR6VGJTa3l5?=
 =?utf-8?B?ZUhYeGVGeit0UStkODlCSVNLYnBxRk90SUZtb3RwQVd3RDNIb2N5LzU0Ynhs?=
 =?utf-8?B?OFlCeUVwemNiNjkwVXFVL2ozSmppc3FSN3l6UEhsZ1lQYzhrdm1WZGgyZW04?=
 =?utf-8?B?RWxnajVFOEdNd0VRYWxtbE9HSUs1UGQxTGIwUUdEMi82WlZYT3EySWVHUm1t?=
 =?utf-8?B?TnZyRGN2a21ZcUZDazJsbWp4VFM1QUowR0c5N2lTaWNBVC9iTGxFb2w0ZlRo?=
 =?utf-8?B?THdCbmFlVUJKOHZCOTJyTWd1YitUbkpIYk5zQmtuV1RPdWc0SkZ6WTV0NS81?=
 =?utf-8?B?S1dVS1M3enFjSmE5b2dxV1BHb1lSYTY1MVZaNDVMMXE4dXhvZkhjY1d5MjdQ?=
 =?utf-8?B?WEhJYVFDQjZZUlVvTjNFb0VJbml3Q1JHSTRqTnlKVXdaRXFaZUN3WDN4Z0pT?=
 =?utf-8?B?NDZiVkxqWHZZRnl2UVQvUXluMGkvcDRJbWtVYm5Bdzl4d21MMDhweVZqcHg4?=
 =?utf-8?B?VG1GaGtkdklZOTkrdzFBcUo5ZlJGTGUyS1Axd1hldW02NjM5UEhoa3FlbnJY?=
 =?utf-8?B?c0J3QlpMbGVVU3FmVjQwS0h4NGdrY2ROZVoveEorWklRVVZkV2h1T0UvYTJ5?=
 =?utf-8?B?V3pLWUJhMjFEWDc3L2M0OE1QZFByRWVOYkllNkp4RGk3cFRLTlpOWXJLRVEv?=
 =?utf-8?B?aWY4UlJhRWY3ejdSMG5DV0cvdzZsWnFOcDRkWTFERW9CTEJpd0IrYm56NHkx?=
 =?utf-8?B?SWd1SUZnMDNpK2IwUDBRNSt1bHoxdDVzZnlQRHRtUFFRVExPSWtGa2p1K05t?=
 =?utf-8?B?cEVveko0ZldTWmRKRytKWm5tT01LRkVoaTNDaTdtWWI0ZExSRExWeUhBbVNW?=
 =?utf-8?B?cGFxU3l5d1R5QUxLZmlNNzVIUDFQZEdqWC9Rd2dxWk9takJYZkFuZVk0N0VX?=
 =?utf-8?B?VTNmT0xMa2xuMHg0OGZBa1RqQzlLam9yWUl2VzlWODY2NU55QkZqcGRUQUhr?=
 =?utf-8?B?d0FEbldnUnBxbmtJSU1nL0hLcUVHT2F0bEkzQnJWQTJMa2RlYmR0Q0VvemJI?=
 =?utf-8?B?RENUZk5HZWovSDI2cHI3Tk01UWRNT1J5SDNDZFRUK3Qwc3Nqc202N20rQnY4?=
 =?utf-8?Q?F6NHEDq1+lFCtjEF/3k8fKeF+5YVqS7w?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5b63c3ef-087e-4c2b-7e64-08da082bb339
X-MS-Exchange-CrossTenant-AuthSource: AM5PR04MB3089.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2022 15:35:01.1101
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZuCjvS4ayw1MjAbPfVGCV785+dEMml65Q5TRW8h55e2MUOWjf50uq0IYkLV+rhX/zElwGSO0/U/arOiqi1XXMQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4836
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/17/22 08:01, Wenchao Hao wrote:
> iscsi_cls_conn is alloced by kzalloc(), the whole iscsi_cls_conn is
> zero filled already including the dd_data. So it is unnecessary to
> call memset again.
> 
> Signed-off-by: Wenchao Hao <haowenchao@huawei.com>
> Reviewed-by: Wu Bo <wubo40@huawei.com>
> Reviewed-by: Lee Duncan <lduncan@suse.com>
> ---
>   drivers/scsi/libiscsi.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
> index d09926e6c8a8..cf4211c6500d 100644
> --- a/drivers/scsi/libiscsi.c
> +++ b/drivers/scsi/libiscsi.c
> @@ -3045,7 +3045,6 @@ iscsi_conn_setup(struct iscsi_cls_session *cls_session, int dd_size,
>   	if (!cls_conn)
>   		return NULL;
>   	conn = cls_conn->dd_data;
> -	memset(conn, 0, sizeof(*conn) + dd_size);
>   
>   	conn->dd_data = cls_conn->dd_data + sizeof(*conn);
>   	conn->session = session;

Reviewed-by: Lee Duncan <lduncan@suse.com>