Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 17 Mar 2022 23:10:54 +0300
From:   "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     mingo@redhat.com, bp@alien8.de, dave.hansen@intel.com,
        luto@kernel.org, peterz@infradead.org,
        sathyanarayanan.kuppuswamy@linux.intel.com, aarcange@redhat.com,
        ak@linux.intel.com, dan.j.williams@intel.com, david@redhat.com,
        hpa@zytor.com, jgross@suse.com, jmattson@google.com,
        joro@8bytes.org, jpoimboe@redhat.com, knsathya@kernel.org,
        pbonzini@redhat.com, sdeep@vmware.com, seanjc@google.com,
        tony.luck@intel.com, vkuznets@redhat.com, wanpengli@tencent.com,
        thomas.lendacky@amd.com, brijesh.singh@amd.com, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCHv6 15/30] x86/boot: Port I/O: allow to hook up alternative
 helpers
Message-ID: <20220317201054.5wdykfru5hhvukvd@black.fi.intel.com>
References: <20220316020856.24435-1-kirill.shutemov@linux.intel.com>
 <20220316020856.24435-16-kirill.shutemov@linux.intel.com>
 <87czik22wk.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87czik22wk.ffs@tglx>
Precedence: bulk

On Thu, Mar 17, 2022 at 01:12:59PM +0100, Thomas Gleixner wrote:
> On Wed, Mar 16 2022 at 05:08, Kirill A. Shutemov wrote:
> > +#undef inb
> > +#undef inw
> > +#undef inl
> > +#undef outb
> > +#undef outw
> > +#undef outl
> > +
> > +struct port_io_ops {
> > +	u8 (*inb)(u16 port);
> > +	u16 (*inw)(u16 port);
> > +	u32 (*inl)(u16 port);
> > +	void (*outb)(u8 v, u16 port);
> > +	void (*outw)(u16 v, u16 port);
> > +	void (*outl)(u32 v, u16 port);
> 
> 	u8	(*inb)(u16 port);
> 	void	(*outb)(u8 v, u16 port);
> 	void	(*outw)(u16 v, u16 port);
> 
> is all what's used AFAICT.

Hm. Okay. I will drop the rest.

> > +};
> > +
> > +extern struct port_io_ops pio_ops;
> > +
> > +/*
> > + * Use the normal I/O instructions by default.
> > + * TDX guests override these to use hypercalls.
> > + */
> > +static inline void init_default_io_ops(void)
> > +{
> > +	pio_ops.inb = __inb;
> > +	pio_ops.inw = __inw;
> > +	pio_ops.inl = __inl;
> > +	pio_ops.outb = __outb;
> > +	pio_ops.outw = __outw;
> > +	pio_ops.outl = __outl;
> > +}
> 
> #define DEFINE_PORT_IO_OPS()		\
> 	struct port_io_ops pio_ops = {	\
>         	.inb	= __inb,	\
>         	.outb	= __outb,	\
>         	.outw	= __outw, }
> 
> Hmm?

This kind of initializations are problematic. They generate run-time
relacations that kernel cannot handle in the boot stub. Linker complains
about this:

	ld.lld: error: Unexpected run-time relocations (.rela) detected!

I will leave it as is, unless you have better ideas.

-- 
 Kirill A. Shutemov