Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 17 Mar 2022 23:21:55 +0300
From:   "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To:     Boris Petkov <bp@alien8.de>
Cc:     tglx@linutronix.de, dave.hansen@intel.com, mingo@redhat.com,
        luto@kernel.org, peterz@infradead.org,
        sathyanarayanan.kuppuswamy@linux.intel.com, aarcange@redhat.com,
        brijesh.singh@amd.com, ak@linux.intel.com, david@redhat.com,
        dan.j.williams@intel.com, wanpengli@tencent.com, jgross@suse.com,
        linux-kernel@vger.kernel.org, hpa@zytor.com, jmattson@google.com,
        pbonzini@redhat.com, seanjc@google.com, jpoimboe@redhat.com,
        vkuznets@redhat.com, joro@8bytes.org, thomas.lendacky@amd.com,
        sdeep@vmware.com, x86@kernel.org, knsathya@kernel.org,
        Sean Christopherson <sean.j.christopherson@intel.com>,
        tony.luck@intel.com
Subject: Re: [PATCHv6 20/30] x86/boot: Add a trampoline for booting APs via
 firmware handoff
Message-ID: <20220317202155.aurobskmy3v57nse@black.fi.intel.com>
References: <20220316020856.24435-1-kirill.shutemov@linux.intel.com>
 <20220316020856.24435-21-kirill.shutemov@linux.intel.com>
 <3D4C3388-DC6A-41A5-A79F-B23FBFFE4E0F@alien8.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3D4C3388-DC6A-41A5-A79F-B23FBFFE4E0F@alien8.de>
Precedence: bulk

On Thu, Mar 17, 2022 at 12:44:42PM +0000, Boris Petkov wrote:
> On March 16, 2022 2:08:46 AM UTC, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> wrote:
> >diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h
> >index 48067af94678..35006e151774 100644
> >--- a/arch/x86/include/asm/apic.h
> >+++ b/arch/x86/include/asm/apic.h
> >@@ -328,6 +328,8 @@ struct apic {
> > 
> > 	/* wakeup_secondary_cpu */
> > 	int	(*wakeup_secondary_cpu)(int apicid, unsigned long start_eip);
> >+	/* wakeup secondary CPU using 64-bit wakeup point */
> >+	int	(*wakeup_secondary_cpu_64)(int apicid, unsigned long start_eip);
> > 
> > 	void	(*inquire_remote_apic)(int apicid);
> > 
> >diff --git a/arch/x86/include/asm/realmode.h b/arch/x86/include/asm/realmode.h
> >index 331474b150f1..fd6f6e5b755a 100644
> >--- a/arch/x86/include/asm/realmode.h
> >+++ b/arch/x86/include/asm/realmode.h
> >@@ -25,6 +25,7 @@ struct real_mode_header {
> > 	u32	sev_es_trampoline_start;
> > #endif
> > #ifdef CONFIG_X86_64
> >+	u32	trampoline_start64;
> 
> I had already asked about those here: why do you need to add a new u32 here and can't use trampoline_start?
> 
> Ditto for the new function pointer too.
> 
> And yes, sev_es_trampoline_start is superfluous too.

As I said[1], I'm confused by the request. These field initialized at
build time. I don't see how a single field would work.

[1] https://lore.kernel.org/all/20220216141009.ymmjduf5doqnhnqy@black.fi.intel.com/

-- 
 Kirill A. Shutemov