Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <2b91abe5-88bd-2941-d561-a8b0ad40f62b@intel.com>
Date:   Thu, 17 Mar 2022 13:23:12 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Content-Language: en-US
From:   Dave Hansen <dave.hansen@intel.com>
To:     "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>
Cc:     mingo@redhat.com, bp@alien8.de, luto@kernel.org,
        peterz@infradead.org, sathyanarayanan.kuppuswamy@linux.intel.com,
        aarcange@redhat.com, ak@linux.intel.com, dan.j.williams@intel.com,
        david@redhat.com, hpa@zytor.com, jgross@suse.com,
        jmattson@google.com, joro@8bytes.org, jpoimboe@redhat.com,
        knsathya@kernel.org, pbonzini@redhat.com, sdeep@vmware.com,
        seanjc@google.com, tony.luck@intel.com, vkuznets@redhat.com,
        wanpengli@tencent.com, thomas.lendacky@amd.com,
        brijesh.singh@amd.com, x86@kernel.org, linux-kernel@vger.kernel.org
References: <20220316020856.24435-1-kirill.shutemov@linux.intel.com>
 <20220316020856.24435-16-kirill.shutemov@linux.intel.com>
 <87czik22wk.ffs@tglx> <20220317201054.5wdykfru5hhvukvd@black.fi.intel.com>
 <c3b640aa-05a1-7706-0c0f-b3f75eee58c6@intel.com>
Subject: Re: [PATCHv6 15/30] x86/boot: Port I/O: allow to hook up alternative
 helpers
In-Reply-To: <c3b640aa-05a1-7706-0c0f-b3f75eee58c6@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/17/22 13:20, Dave Hansen wrote:
> You keep the preprocessor away from things like
> 
> 	foo.inb = bar;
> 
> with:
> 
> 	#define inb(x) pio_ops.inb(x)

... and I spotted my nonsense just as I hit send.

You could do that ^^.  But you'd need to rename the 'inb' op  like:

struct port_io_ops {
	u8 (*f_inb)(u16 port);
	...
};

so that you do:

	#define inb(x) pio_ops.f_inb(x)

But, remember when I said I hate playing #define tricks? ;)  This is one
reason why.