Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 17 Mar 2022 22:08:22 +0100
From:   Max Staudt <max@enpas.org>
To:     Marc Kleine-Budde <mkl@pengutronix.de>
Cc:     Vincent Mailhol <vincent.mailhol@gmail.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        linux-can@vger.kernel.org, Oliver Neukum <oneukum@suse.com>,
        linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.com>
Subject: Re: [PATCH v3] can, tty: elmcan CAN/ldisc driver for ELM327 based
 OBD-II adapters
Message-ID: <20220317220822.4595c89f.max@enpas.org>
In-Reply-To: <20220317205717.pfgfdxxyucmeuuwr@pengutronix.de>
References: <20220307214303.1822590-1-max@enpas.org>
        <CAMZ6RqJZObevKPc29jW+m6i0eAgestTbw8KCPXxSGHzSXK7cRg@mail.gmail.com>
        <20220309135414.34f77251.max@enpas.org>
        <CAMZ6RqJJ-PO=WeFeuXk4iC9GHLXz_ZMWtsVCm6sGVGbmeE5U1Q@mail.gmail.com>
        <20220314220408.hn4vdohtjdbfoaqo@pengutronix.de>
        <20220317212359.71252c57.max@enpas.org>
        <20220317205717.pfgfdxxyucmeuuwr@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 17 Mar 2022 21:57:17 +0100
Marc Kleine-Budde <mkl@pengutronix.de> wrote:

> On 17.03.2022 21:23:59, Max Staudt wrote:
> > On Mon, 14 Mar 2022 23:04:08 +0100
> > Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> >   
> > > On 09.03.2022 22:49:49, Vincent Mailhol wrote:  
> > > > Either we agree that using can_rx_offload without implementing
> > > > the mailbox_read() is OK and in that case, the can_rx_offload
> > > > framework should be modified to allow mailbox_read() to be a
> > > > NULL pointer.
> > > > 
> > > > Either it is not the case and you use the more classic
> > > > netif_rx().
> > > > 
> > > > And I do not have the answer. I haven't studied can_rx_offload
> > > > enough to be a judge here. Sorry.
> > > > 
> > > > @Marc, any thoughts?    
> > > 
> > > Use can_rx_offload_add_manual() instead.  
> > 
> > m-(
> > 
> > Yes, it's right underneath _add_fifo() and does the right thing. No
> > idea how I missed it, I thought I had looked through all variants.  
> 
> I think that function was not there form the beginning, maybe you
> looked at the rx-offload code when it was not available.

Indeed, it was added in 5.10, and my rx-offload work likely just about
missed that. Thanks!


Max