Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 18 Mar 2022 01:48:31 +0300
From:   "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To:     Dave Hansen <dave.hansen@intel.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>, mingo@redhat.com,
        bp@alien8.de, luto@kernel.org, peterz@infradead.org,
        sathyanarayanan.kuppuswamy@linux.intel.com, aarcange@redhat.com,
        ak@linux.intel.com, dan.j.williams@intel.com, david@redhat.com,
        hpa@zytor.com, jgross@suse.com, jmattson@google.com,
        joro@8bytes.org, jpoimboe@redhat.com, knsathya@kernel.org,
        pbonzini@redhat.com, sdeep@vmware.com, seanjc@google.com,
        tony.luck@intel.com, vkuznets@redhat.com, wanpengli@tencent.com,
        thomas.lendacky@amd.com, brijesh.singh@amd.com, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCHv6 15/30] x86/boot: Port I/O: allow to hook up alternative
 helpers
Message-ID: <20220317224831.ci7tb4lasg3xlgvr@black.fi.intel.com>
References: <20220316020856.24435-1-kirill.shutemov@linux.intel.com>
 <20220316020856.24435-16-kirill.shutemov@linux.intel.com>
 <87czik22wk.ffs@tglx>
 <20220317201054.5wdykfru5hhvukvd@black.fi.intel.com>
 <c3b640aa-05a1-7706-0c0f-b3f75eee58c6@intel.com>
 <2b91abe5-88bd-2941-d561-a8b0ad40f62b@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2b91abe5-88bd-2941-d561-a8b0ad40f62b@intel.com>
Precedence: bulk

On Thu, Mar 17, 2022 at 01:23:12PM -0700, Dave Hansen wrote:
> On 3/17/22 13:20, Dave Hansen wrote:
> > You keep the preprocessor away from things like
> > 
> > 	foo.inb = bar;
> > 
> > with:
> > 
> > 	#define inb(x) pio_ops.inb(x)
> 
> ... and I spotted my nonsense just as I hit send.
> 
> You could do that ^^.  But you'd need to rename the 'inb' op  like:
> 
> struct port_io_ops {
> 	u8 (*f_inb)(u16 port);
> 	...
> };
> 
> so that you do:
> 
> 	#define inb(x) pio_ops.f_inb(x)
> 
> But, remember when I said I hate playing #define tricks? ;)  This is one
> reason why.

But the define tricks are unrelated to the linker issue. The issue pops up
after you get past the preprocessor tricks.

-- 
 Kirill A. Shutemov