Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <10fb1261-f22f-8e21-4056-166c283e26f2@redhat.com>
Date:   Fri, 18 Mar 2022 04:34:20 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v2] mm/hmm/test: simplify hmm test code: use miscdevice
 instead of char dev
Content-Language: en-US
To:     Jason Gunthorpe <jgg@ziepe.ca>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        apopple@nvidia.com, jhubbard@nvidia.com, rcampbell@nvidia.com,
        vbabka@suse.cz
References: <20220311033050.22724-1-mpenttil@redhat.com>
 <20220314182439.GB64706@ziepe.ca>
 <d9b9c82e-4012-cf0a-d966-d9669a684a27@redhat.com>
 <20220315183922.GC64706@ziepe.ca>
 <8e836d75-97b0-d301-4d6a-92025e91cad5@redhat.com>
 <0f53c5ff-1711-861d-9a12-0634d4ab9fca@redhat.com>
 <20220317141539.GD64706@ziepe.ca>
From:   =?UTF-8?Q?Mika_Penttil=c3=a4?= <mpenttil@redhat.com>
In-Reply-To: <20220317141539.GD64706@ziepe.ca>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 17.3.2022 16.15, Jason Gunthorpe wrote:
> On Thu, Mar 17, 2022 at 08:58:52AM +0200, Mika Penttilä wrote:
>> @@ -1225,7 +1232,11 @@ static int dmirror_device_init(struct dmirror_device
>> *mdevice, int id)
>>
>>          cdev_init(&mdevice->cdevice, &dmirror_fops);
>>          mdevice->cdevice.owner = THIS_MODULE;
>> -       ret = cdev_add(&mdevice->cdevice, dev, 1);
>> +       device_initialize(&mdevice->device);
>> +       dev_set_name(&mdevice->device, "%s", dmirror_device_names[id]);
>> +       mdevice->device.devt = dev;
>> +
>> +       ret = cdev_device_add(&mdevice->cdevice, &mdevice->device);
>>          if (ret)
>>                  return ret;
> 
> Right, miscdev isn't that helpful in the end..
> 
> Jason
> 

To wrap up, I could send a v3 formal patch with either this cdev way or 
the miscdev way.. Both eliminate the user space /proc/devices parsing 
and mknod'ing. Jason brought up concerns using miscdevice like this, 
although for this case it works correctly. miscdevice also provides a 
little more cleanup and simpler code, but the difference is not huge. So 
what do people prefer?

Thanks,
Mika