Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp2025172pxp; Fri, 18 Mar 2022 01:02:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw6MOqarvf1DhnUhISvrlAFpQeAj5bRGm++AwP3tP1sSrYjLOBhgDFJyCQkbIv9yIh+0iJJ X-Received: by 2002:a17:907:1c10:b0:6da:6316:d009 with SMTP id nc16-20020a1709071c1000b006da6316d009mr7855194ejc.621.1647590571596; Fri, 18 Mar 2022 01:02:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647590571; cv=none; d=google.com; s=arc-20160816; b=TmHcwdgtpThHfEar8qH4ZwaaWPnRxsejBYfeDJC84uXl6Bbl+dp0dtQRgCrPk0ffFH iQFKqDuyw08of2SU2xNx2vtyefyujQLAKOhoZEkdWSVjy7XstjSJ/dHKBWkJ4O+yIgEo 5st03mXoKsLecAPqKqq+vv4b4JK+wcqVqeBWCyVo/f7rFrRC+sUAVu/x6agZyI/5cUch wqUr/bVv6Gv/ExMPA67H4CgMU1PsBM7pFMfPgDolR5iA2uSk2MbvBRYSxYiLLFslMN/C SjW2r2yXKaU2Op/YVc9NNdYJKmlkqiUOUuI5aUbFj9RAHxjt2avo4B+Hw2uwohAVghnO mEVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=z6YI2f1Bz7dckkGqYcq8fNB1pPFYWHiXaRQsubbYHH4=; b=G7yddqGjMaH0ncYBlIYjqCEHdcvCs5yefTFnY1JEJkbC9RDp4gvs8t+wL6UjoJJqJZ zHAqmCHLMXFkgYy463rvNsUx+RRyyQUMTxzptn7WC+6t/v71utMob9/E4HRzOfQbAm0F UjXRwtwEgxxE18I+It88E9DZwdfIWhC57JnIS6M5TvgKrAVPwC5R+7Vihe/YEm4sQ3NX rSvcVppoz8vgXeJ2Msf5s96MUeUkHM6KA31QTXZpqywHOkXo+U3dmYAnFyeZqNhVE30n OV9Owh6jjhHXYT1q7AKbRmXXeb0hXACLorQRk3BZ9g+mHDYhtYBRcaY/BAxwqr3MMKW7 X2+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gs14-20020a1709072d0e00b006dfa083a252si790067ejc.139.2022.03.18.01.02.22; Fri, 18 Mar 2022 01:02:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232333AbiCREEx (ORCPT + 99 others); Fri, 18 Mar 2022 00:04:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229503AbiCREEs (ORCPT ); Fri, 18 Mar 2022 00:04:48 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9BFC63DE; Thu, 17 Mar 2022 21:03:28 -0700 (PDT) Received: from canpemm500007.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4KKVgS4JNQzCqkR; Fri, 18 Mar 2022 12:01:24 +0800 (CST) Received: from [10.174.179.215] (10.174.179.215) by canpemm500007.china.huawei.com (7.192.104.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 18 Mar 2022 12:03:26 +0800 Subject: Re: [PATCH -next] wlwifi: mei: Fix build error without CFG80211 To: , , , , , , CC: , , References: <20220318030149.1328-1-yuehaibing@huawei.com> From: YueHaibing Message-ID: Date: Fri, 18 Mar 2022 12:03:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20220318030149.1328-1-yuehaibing@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.215] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500007.china.huawei.com (7.192.104.62) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/3/18 11:01, YueHaibing wrote: > If CFG80211 is n and IWLMEI is y, building fails: > > drivers/net/wireless/intel/iwlwifi/mei/net.o: In function `iwl_mei_tx_copy_to_csme': > net.c:(.text+0xd0): undefined reference to `ieee80211_hdrlen' > > Make IWLMEI depends on CFG80211 to fix this. > It seems has been fixed, Pls igbore this. > Fixes: 2da4366f9e2c ("iwlwifi: mei: add the driver to allow cooperation with CSME") > Signed-off-by: YueHaibing > --- > drivers/net/wireless/intel/iwlwifi/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/intel/iwlwifi/Kconfig b/drivers/net/wireless/intel/iwlwifi/Kconfig > index 85e704283755..8c003cd29ab7 100644 > --- a/drivers/net/wireless/intel/iwlwifi/Kconfig > +++ b/drivers/net/wireless/intel/iwlwifi/Kconfig > @@ -137,7 +137,7 @@ endif > > config IWLMEI > tristate "Intel Management Engine communication over WLAN" > - depends on INTEL_MEI > + depends on INTEL_MEI && CFG80211 > depends on PM > help > Enables the iwlmei kernel module. >