Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 18 Mar 2022 15:04:00 +0800
From:   Ming Lei <ming.lei@redhat.com>
To:     "yukuai (C)" <yukuai3@huawei.com>
Cc:     Christoph Hellwig <hch@infradead.org>, tj@kernel.org,
        axboe@kernel.dk, cgroups@vger.kernel.org,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        yi.zhang@huawei.com
Subject: Re: [PATCH v9] block: cancel all throttled bios in del_gendisk()
Message-ID: <YjQu4FfpUq33pyDx@T590>
References: <20220210115637.1074927-1-yukuai3@huawei.com>
 <YhuyBgZSS6m/Mwu6@infradead.org>
 <Yhxnkg0AEaj36t+a@T590>
 <YhyYpWHGVhs3J/dk@infradead.org>
 <Yh31bQu3gbXoDBuK@T590>
 <836f0686-4ac8-327d-2bab-64a762ea8673@huawei.com>
 <Yh6/dH2CERzsBPJd@T590>
 <f46c8512-400b-144f-e2ba-c57cc895fca8@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <f46c8512-400b-144f-e2ba-c57cc895fca8@huawei.com>
Precedence: bulk

On Thu, Mar 17, 2022 at 07:22:04PM +0800, yukuai (C) wrote:
> 在 2022/03/02 8:51, Ming Lei 写道:
> > On Tue, Mar 01, 2022 at 09:54:28PM +0800, yukuai (C) wrote:
> > > 在 2022/03/01 18:29, Ming Lei 写道:
> > > > On Mon, Feb 28, 2022 at 01:40:53AM -0800, Christoph Hellwig wrote:
> > > > > On Mon, Feb 28, 2022 at 02:11:30PM +0800, Ming Lei wrote:
> > > > > > > FYI, this crashed left rigt and center when running xfstests with
> > > > > > > traces pointing to throtl_pending_timer_fn.
> > > > > > 
> > > > > > Can you share the exact xfstests test(fs, test)? Or panic log?
> > > > > > 
> > > > > > I can't reproduce it when running './check -g auto' on XFS, meantime
> > > > > > tracking throtl_pending_timer_fn().
> > > > > 
> > > > >   From a quick run using f2fs:
> > > > > 
> > > > > generic/081 files ... [  316.487861] run fstests generic/081 at 2022-02-28 09:38:40
> > > > 
> > > > Thanks for providing the reproducer.
> > > > 
> > > > The reason is that the pending timer is deleted in blkg's release
> > > > handler, so the timer can still be live after request queue is released.
> > > > 
> > > > The patch of 'block: cancel all throttled bios in del_gendisk()' should just
> > > > make it easier to trigger.
> > > > 
> > > > After patch of "block: move blkcg initialization/destroy into disk allocation/
> > > > release handler" lands, the issue can be fixed easily by:
> 
> Hi, Ming
> 
> Now that the above patch is landed in linux-next, do you intend to fix
> the above problem? Or I can take over if you don't mind.

Hi Yu Kuai, 

I will send one fix and your V9 later.


Thanks,
Ming