Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 18 Mar 2022 09:19:18 +0100
Message-ID: <s5hee2z4qrd.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc:     tiwai@suse.com, Jaroslav Kysela <perex@perex.cz>,
        Jeremy Szu <jeremy.szu@canonical.com>,
        Werner Sembach <wse@tuxedocomputers.com>,
        Hui Wang <hui.wang@canonical.com>,
        Lucas Tanure <tanureal@opensource.cirrus.com>,
        Cameron Berkenpas <cam@neo-zeon.de>,
        Kailang Yang <kailang@realtek.com>, Sami Loone <sami@loone.fi>,
        Hans de Goede <hdegoede@redhat.com>,
        Stefan Binding <sbinding@opensource.cirrus.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Fix LED on Zbook Studio G9
In-Reply-To: <20220317221134.566358-1-kai.heng.feng@canonical.com>
References: <20220317221134.566358-1-kai.heng.feng@canonical.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 17 Mar 2022 23:11:33 +0100,
Kai-Heng Feng wrote:
> 
> Commit 07bcab93946c ("ALSA: hda/realtek: Add support for HP Laptops")
> breaks mute and micmute LEDs because it changed the LED quirk from
> ALC285_FIXUP_HP_GPIO_LED to ALC245_FIXUP_HP_GPIO_LED, so change it back
> here.
> 
> Also reorder the chain of quirks to ensure LED quirk is the last one
> being applied.
> 
> Fixes: 07bcab93946c ("ALSA: hda/realtek: Add support for HP Laptops")
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>

Thanks, applied now.


Takashi