Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 18 Mar 2022 08:54:50 +0100
From:   Horatiu Vultur <horatiu.vultur@microchip.com>
To:     Michael Walle <michael@walle.cc>
CC:     <UNGLinuxDriver@microchip.com>, <davem@davemloft.net>,
        <devicetree@vger.kernel.org>, <kuba@kernel.org>,
        <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
        <robh+dt@kernel.org>
Subject: Re: [PATCH net-next 1/5] dt-bindings: net: lan966x: Extend with FDMA
 interrupt
Message-ID: <20220318075450.rvofpoc3m22g7jpj@soft-dev3-1.localhost>
References: <20220317185159.1661469-2-horatiu.vultur@microchip.com>
 <20220318021413.25810-1-michael@walle.cc>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <20220318021413.25810-1-michael@walle.cc>
Precedence: bulk

The 03/18/2022 03:14, Michael Walle wrote:
> 
> > Extend dt-bindings for lan966x with FDMA interrupt. This is generated
> > when receiving a frame or when a frame was transmitted. The interrupt
> > needs to be enable for each frame.
> >
> > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> > ---
> >  .../devicetree/bindings/net/microchip,lan966x-switch.yaml       | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml b/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
> > index 13812768b923..14e0bae5965f 100644
> > --- a/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
> > +++ b/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
> > @@ -39,6 +39,7 @@ properties:
> >        - description: frame dma based extraction
> >        - description: analyzer interrupt
> >        - description: ptp interrupt
> > +      - description: fdma interrupt
> >
> >    interrupt-names:
> >      minItems: 1
> > @@ -47,6 +48,7 @@ properties:
> >        - const: fdma
> >        - const: ana
> >        - const: ptp
> > +      - const: fdma
> 
> This interrupt is already described (three lines above), no?

Yes you are right.
So I will drop this patch in the next version.

> 
> -michael

-- 
/Horatiu