Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Sa, Nuno" <Nuno.Sa@analog.com>
To:     Wang ShaoBo <bobo.shaobowang@huawei.com>
CC:     "cj.chengjian@huawei.com" <cj.chengjian@huawei.com>,
        "liwei391@huawei.com" <liwei391@huawei.com>,
        "Miclaus, Antoniu" <Antoniu.Miclaus@analog.com>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "jic23@kernel.org" <jic23@kernel.org>,
        "Jonathan.Cameron@huawei.com" <Jonathan.Cameron@huawei.com>
Subject: RE: [PATCH 1/2] iio:filter:admv8818: Add depends on REGMAP
Thread-Topic: [PATCH 1/2] iio:filter:admv8818: Add depends on REGMAP
Thread-Index: AQHYOnLUWKUWx9O5c0SULrznBschF6zE0w5Q
Date:   Fri, 18 Mar 2022 08:45:33 +0000
Message-ID: <PH0PR03MB678617206D33B41868D565B499139@PH0PR03MB6786.namprd03.prod.outlook.com>
References: <20220318025914.2614812-1-bobo.shaobowang@huawei.com>
 <20220318025914.2614812-2-bobo.shaobowang@huawei.com>
In-Reply-To: <20220318025914.2614812-2-bobo.shaobowang@huawei.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?/lBXWJMmWVrsZwlO4cG2u5RcGbQOcfkHJ1tCPqXXbdWpNkG4VsTz4FuepX?=
 =?iso-8859-1?Q?S/2vCnvebL0Fa1ktRvHGHOX2+5ATrpVkdehoxWMovb+95Srf7cEOMA6TJ9?=
 =?iso-8859-1?Q?nklP/3sy3DuuGwJ8XTXkUa4lJgE85V0Ob+1Orw8mztHhjz6UB4Qptf/QrQ?=
 =?iso-8859-1?Q?b6HLNqfZEFhHiCkgKTR/bEQ/23A248GS1U+xDRbFCKHHgJzJolSNA2pEa8?=
 =?iso-8859-1?Q?S/yOqmnRj9oBEpHtbFDAOzpIRzx54/15ePsWLF6BTc5RnCByJuzgF+Hj4N?=
 =?iso-8859-1?Q?zTUc0en5zR5IXpFBzmYkANAvnOyOU3QSWjnijYBTJdGoKd6AQDmIwhkGRH?=
 =?iso-8859-1?Q?YbzlYVmKKsU3ZLDSzAjSqbzeuydU8KSOcK27ay7ylHw+g0KIKka6tipvCo?=
 =?iso-8859-1?Q?Z4P0ZLX4J9WLiSmytbptCH5btzzKksSTJ9yJVa2KxNBaUaQxR+1RfJhOeI?=
 =?iso-8859-1?Q?cTKtkP1+LzyhpyoDk00dZZSK1U1aFeBAPox86YTcl38649qDrm06l4n9Z7?=
 =?iso-8859-1?Q?Lj7jpu2RxT51C456EN6IRbttZafXHxScPEpOmIfPPMXzlX1+pe+YiPg/9r?=
 =?iso-8859-1?Q?hGvN0DsPPEoanHQwqTGsroIzl5D98rVIiet/7txDS2yR4HQKF6KUvr7BD3?=
 =?iso-8859-1?Q?qy2KOvfNshGgEdtLOvrnfmw2WioOMSfNDoynw072KjII3xJ2EYQljKkiYD?=
 =?iso-8859-1?Q?uQnaOplGRRLqj4Y3k1x+H2R4TNyZjaSmDxYybgk8wiYJcHxl9CqBlKpqVO?=
 =?iso-8859-1?Q?sTc6ASkV6ulVreH2zrJM63Vjpq5Sp9qc/YL774bo6e2kSa9LvY43U15pb7?=
 =?iso-8859-1?Q?ZUrJ7CIw0nWnXlJJhISDJn7ky3mA2RCVr6ieYr5G445lLBLpI4VqO0fbbC?=
 =?iso-8859-1?Q?pWz5KF884QS7GD2DZp+XOU14ffWv9cb6Y3WCfXUFJiIAJE15gOYnLsVDql?=
 =?iso-8859-1?Q?EkPLejoGTjXX4VzYYWnAi/lYR8SxkERMgpdYK53BW8/nZZojx71TEtDdDx?=
 =?iso-8859-1?Q?37bgah9gx5u+gwCVRzwjM2NWgCD1LdrecLwy/aP9pQOrcAdJ0jxnmqjt8E?=
 =?iso-8859-1?Q?xmvFkjAX1bdUPvSoAuy+sugw5kGc0aAMxWYjxJK0hHnor03seJoWw3Oxqw?=
 =?iso-8859-1?Q?GtnoEe6toR+zdxB4lv0lmbchAzKCD5AFW4nE2cS1ReJqJrFvAwxYUTYt5z?=
 =?iso-8859-1?Q?Hag3C5ytoOvHNRTYljFEjXduk0Hq+KXz7rjLbocgjpVZPV7C/cg/N745Ha?=
 =?iso-8859-1?Q?tumDUZGDY0IdwJ7nU0QjOPok5FGcpquaN+cfzrjVfqokbsKgfTWaUS+U5d?=
 =?iso-8859-1?Q?EWmtZQhxkI90GIM7Bh/+nFfYK3BGbXmaZhvePQOhjtPCRqJQuzjz9AjwxW?=
 =?iso-8859-1?Q?aHZvoaxmPPmhXx3kbgwEqWE5r2a1d1iUVV64WSPckgyzqD2lLpD3zmLGfC?=
 =?iso-8859-1?Q?xVvV2N3Og1TupFaKR4PkfqwCCrTz8Jf1x2RCu8Q/G+AdS3kTFrdowQqMLc?=
 =?iso-8859-1?Q?3PMYG2hOs2WVNn7vAOQQ5O?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB6786.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dff0b160-762d-4576-7351-08da08bbaa78
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Mar 2022 08:45:33.7180
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mbPcqzN0+bAEFHNmb64okWU7T8Wl96ODZkJLMNauHxOoIHepEIo3JoW3oQBS7VIaPqnIbYkWhPd4koXzjJLfvg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2228
X-Proofpoint-GUID: _U470MhC9pVhvhAKsflxnZLPc3KpcBWB
X-Proofpoint-ORIG-GUID: y8K4SrzpqJ5hj2QvTqloLzBT31DfNLsg
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.850,Hydra:6.0.425,FMLib:17.11.64.514
 definitions=2022-03-18_07,2022-03-15_01,2022-02-23_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0
 malwarescore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015
 priorityscore=1501 mlxscore=0 mlxlogscore=999 adultscore=0 impostorscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2203180047
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Wang,

Thanks for the patch

> -----Original Message-----
> From: Wang ShaoBo <bobo.shaobowang@huawei.com>
> Sent: Friday, March 18, 2022 3:59 AM
> Cc: cj.chengjian@huawei.com; liwei391@huawei.com;
> bobo.shaobowang@huawei.com; Miclaus, Antoniu
> <Antoniu.Miclaus@analog.com>; linux-iio@vger.kernel.org; linux-
> kernel@vger.kernel.org; jic23@kernel.org;
> Jonathan.Cameron@huawei.com
> Subject: [PATCH 1/2] iio:filter:admv8818: Add depends on REGMAP
>=20
> [External]
>=20
> Add "depends on REGMAP" to CONFIG_ADMV8818, because
> admv8818 driver
> uses structure/symbols such as 'struct regmap_config' which are
> defined
> only when CONFIG_REGMAP is set.
>=20
> Fixes: f34fe888ad05 ("iio:filter:admv8818: add support for ADMV8818")
> Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
> ---
>  drivers/iio/filter/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/iio/filter/Kconfig b/drivers/iio/filter/Kconfig
> index 3ae35817ad82..4bbf10f8692c 100644
> --- a/drivers/iio/filter/Kconfig
> +++ b/drivers/iio/filter/Kconfig
> @@ -7,7 +7,7 @@ menu "Filters"
>=20
>  config ADMV8818
>  	tristate "Analog Devices ADMV8818 High-Pass and Low-Pass
> Filter"
> -	depends on SPI && COMMON_CLK && 64BIT
> +	depends on REGMAP && SPI && COMMON_CLK && 64BIT

I think the best way is to have select REGMAP_SPI. Hence:

    depends on SPI && COMMON_CLK && 64BIT
    select REGMAP_SPI

This will automatically default CONFIG_REGMAP to y. with your
patch, I guess we can still have issues with ' __devm_regmap_init_spi()'

- Nuno S=E1