Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp2254710pxp; Fri, 18 Mar 2022 06:48:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4v4IEtbfHeoMSHZj7SOhmYPLrgRGQ6QQZuEBsb0Wt3w/CuJy6cFRG234R5kBJ4ojgQHNl X-Received: by 2002:a17:90a:c583:b0:1c6:8e98:c93f with SMTP id l3-20020a17090ac58300b001c68e98c93fmr8086347pjt.177.1647611330323; Fri, 18 Mar 2022 06:48:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647611330; cv=none; d=google.com; s=arc-20160816; b=vJwNs1pkyNNqkxENcdyE/3/vJkU69QnNE8L0Dnms27SbQjjf7Q4rOX52EhMhj41FYQ 7eHp0aozZW5TjAZrO2EmwXvw2N3HoW7AdoRbJMrDaljOzF7+WSJc6zADsthsyHNIv/6O n8Lz9IBKNYMd7kWb09ZuKDiM6MoX7Fu5wO7oNl3LoCtaq7oFVSMABGZO8F4zFc2TBKIo 4iOPBed7PBu8Hs/x3VNEdT3fHgu28yx1KZ9fGHp+ipPT0Ee8Y/DY4nGvIdtZ9bHFSbX1 9gGRU8hvCRHcZz9UsJBwzMlQRIaDg5zS3AGnaD6KDcxywUIRbAnM6ZyfUB4eM54slpJx 3HTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Ucy7UKERk5tY9qyEMAlSrBNAZ3YAADMKvJM+Yyl2E7w=; b=Z8QpxMlS5YeBHcx+DDRVkNxgUIiUOUg7GRPlUj/LInzc02LF7C05t2Ww+npCs9H3jN 11qM0YRpE0YhVacSVwt+mxCjoODkG/0gTx4/yy5B2G9fMOjHnpwbRnQ4OYJVpJoKUg4E FhhaV/SQ6bi6BvRtpfx82IzoZZDYUNrKgowwlAC8ZsSvqdUZvw1tGmeqdk/wJEvePaQu 8A/gvMxzIcxkXb4ILqxXc/k0HScvs4z0EoukKvQiAMB+qJOBWCIlaXYeCFatxbiXdcRH Xk0uGl/cnnx3w2qotIEBdFG+DaQryHBRGMgwRu38gJiCtarYV7U2Q5CrtHdHmyf8xMSK BhPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BcdPrKxX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s19-20020a170902a51300b00153b2d1640esi2108758plq.22.2022.03.18.06.48.36; Fri, 18 Mar 2022 06:48:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BcdPrKxX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234519AbiCRJip (ORCPT + 99 others); Fri, 18 Mar 2022 05:38:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232006AbiCRJil (ORCPT ); Fri, 18 Mar 2022 05:38:41 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A2DC92EA91D for ; Fri, 18 Mar 2022 02:37:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647596242; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Ucy7UKERk5tY9qyEMAlSrBNAZ3YAADMKvJM+Yyl2E7w=; b=BcdPrKxX/U3DqmNOsjE4PIf0z9Z2I2O7Zktbq5CCnMaiIYJD11Vcw2uKbQ6uN2JZQL8o8I ypQ0O59gSckHbmsPpubEWCDQRp7SWcxKMQ3vjm9mWAWUeDQPZMjM0GL/+87snsxR65MvgQ UypBFQ6GQiPi6JCHlowQN3xKA5JpSPg= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-669-1LiOB--OP1a_RA3_bcE6mQ-1; Fri, 18 Mar 2022 05:37:17 -0400 X-MC-Unique: 1LiOB--OP1a_RA3_bcE6mQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1E9033C02B90; Fri, 18 Mar 2022 09:37:17 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-13-174.pek2.redhat.com [10.72.13.174]) by smtp.corp.redhat.com (Postfix) with ESMTP id A2E04112C08E; Fri, 18 Mar 2022 09:37:11 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: willy@infradead.org, bhe@redhat.com, kexec@lists.infradead.org, yangtiezhu@loongson.cn, amit.kachhap@arm.com, hch@lst.de, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk Subject: [PATCH v4 0/4] Convert vmcore to use an iov_iter Date: Fri, 18 Mar 2022 17:37:02 +0800 Message-Id: <20220318093706.161534-1-bhe@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Copy the description of v3 cover letter from Willy: === For some reason several people have been sending bad patches to fix compiler warnings in vmcore recently. Here's how it should be done. Compile-tested only on x86. As noted in the first patch, s390 should take this conversion a bit further, but I'm not inclined to do that work myself. This series resends Willy's v3 patches which includes patch 1~3, and append one patch to clean up the open code pointed out by Al. Al's concerns to v3 patches and my reply after investigation: https://lore.kernel.org/all/YhiTN0MORoQmFFkO@MiWiFi-R3L-srv/T/#u Willy's v3 patchset: [PATCH v3 0/3] Convert vmcore to use an iov_iter https://lore.kernel.org/all/20211213143927.3069508-1-willy@infradead.org/T/#u Changelog: === v4: - Append one patch to replace the open code with iov_iter_count(). This is suggested by Al. - Fix a indentation error by replacing space with tab in arch/sh/kernel/crash_dump.c of patch 1 reported by checkpatch. The rest of patch 1~3 are untouched. - Add Christopy's Reviewed-by and my Acked-by for patch 1~3. v3: - Send the correct patches this time v2: - Removed unnecessary kernel-doc - Included uio.h to fix compilation problems - Made read_from_oldmem_iter static to avoid compile warnings during the conversion - Use iov_iter_truncate() (Christoph) Baoquan He (1): fs/proc/vmcore: Use iov_iter_count() Matthew Wilcox (Oracle) (3): vmcore: Convert copy_oldmem_page() to take an iov_iter vmcore: Convert __read_vmcore to use an iov_iter vmcore: Convert read_from_oldmem() to take an iov_iter arch/arm/kernel/crash_dump.c | 27 +------ arch/arm64/kernel/crash_dump.c | 29 +------ arch/ia64/kernel/crash_dump.c | 32 +------- arch/mips/kernel/crash_dump.c | 27 +------ arch/powerpc/kernel/crash_dump.c | 35 ++------- arch/riscv/kernel/crash_dump.c | 26 +------ arch/s390/kernel/crash_dump.c | 13 ++-- arch/sh/kernel/crash_dump.c | 29 ++----- arch/x86/kernel/crash_dump_32.c | 29 +------ arch/x86/kernel/crash_dump_64.c | 48 ++++-------- fs/proc/vmcore.c | 130 +++++++++++++------------------ include/linux/crash_dump.h | 19 ++--- 12 files changed, 123 insertions(+), 321 deletions(-) -- 2.34.1