Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp2324826pxp; Fri, 18 Mar 2022 08:13:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNX7D/CEl4WRiMakKcDwQVBGdhNape+qTw5nGwUhb2MU8cZIseW3rnjr6V19hkBEfxFjjT X-Received: by 2002:a17:907:3f86:b0:6df:ad43:583 with SMTP id hr6-20020a1709073f8600b006dfad430583mr5309091ejc.535.1647616385595; Fri, 18 Mar 2022 08:13:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647616385; cv=none; d=google.com; s=arc-20160816; b=iILxGPvt7tZf81qPw0fRi+FPA0RcSS6zY7Iz0rBuMqkLCHMwECmAVgGfjyUWpAzqtl qARODyAKIMyYUqmlHOU0Pxaou63r78iWLXvJfhiTTd253HLDO56vo0c5DrHlidy1NDar jlRXea4PdtlTXCw8/puiM3d6LOLKBbqiINxej3VAyytJXaDElyWe+oWfgbUh1NNzXFuI w6XslazZM5jDinJKH7iwKC0FyAzKrjWccBQwxWF/SD8IBtT9YaDO21IUsqNRpQW9matd +/0H+p/q0PeqN9HxBOsYtZ4HRG7ENulECx1J6m3sUM95zoo5niC1Mk2QRL6OYOjG+VSt AkAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=hsbaToJIT7iNy6imNFC0UGX5CliHIqB90sCL0AN0uFM=; b=SZx3HQP+fOzMpBJV3USpWwIaQEiRzBMZV3c+eqI2ZTUZLlanmADKATTr1m4LTthcUX 6CJL5C22VOxlMZYqbeV+/PGTNehp+TKXKT1VLimZUexdl8J2uAaNjbkwpmvOKoUM0L8z OFpaH2M9+bVXXyWiLOzek94umUC/gpZNmuLEXGWpDB6dyuTSLFzrVRHWMhyiKXk0TLkz 1bSq8tzCStuzGpdcR9LYpilnLd1BZKkMNT2DJCNkqlU65gfBYwjmyXXQPkzfDT/hS1lC Bcc81p80gdgJTrJia2uZ12sTGluM0rtBhAU4PzLnbOYiVTZRCXyqVzCAZVRuNPLxOT5o tLDw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v26-20020a50f09a000000b00418c2b5be62si4224479edl.324.2022.03.18.08.12.38; Fri, 18 Mar 2022 08:13:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231661AbiCRCCg (ORCPT + 99 others); Thu, 17 Mar 2022 22:02:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230344AbiCRCCe (ORCPT ); Thu, 17 Mar 2022 22:02:34 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D88F417F3EC for ; Thu, 17 Mar 2022 19:01:15 -0700 (PDT) Received: from dggpeml500020.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4KKRz51XbMzfYpx; Fri, 18 Mar 2022 09:59:45 +0800 (CST) Received: from [10.174.177.174] (10.174.177.174) by dggpeml500020.china.huawei.com (7.185.36.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 18 Mar 2022 10:01:13 +0800 Subject: Re: [PATCH -next] ubifs: rename_whiteout: correct old_dir size computing To: Richard Weinberger CC: linux-mtd , linux-kernel , yukuai3 , chengzhihao1 , Baokun Li References: <20220215040736.2839939-1-libaokun1@huawei.com> <157336576.152785.1647468012272.JavaMail.zimbra@nod.at> <2008739324.156347.1647556500875.JavaMail.zimbra@nod.at> From: "libaokun (A)" Message-ID: <1535fba0-838d-848b-8906-f25929037af9@huawei.com> Date: Fri, 18 Mar 2022 10:01:13 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <2008739324.156347.1647556500875.JavaMail.zimbra@nod.at> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.174] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500020.china.huawei.com (7.185.36.88) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2022/3/18 6:35, Richard Weinberger 写道: > ----- Ursprüngliche Mail ----- >> Von: "libaokun" >>>>> + >>>>> + /* Add the old_dentry size to the old_dir size. */ >>>>> + old_sz -= CALC_DENT_SIZE(fname_len(&old_nm)); >>> So you basically reset old_sz back to 0? >> Yes, reset old_sz to 0 here. > Okay, makes sense. Patch applied. > > Thanks, > //richard > . Thank you for your review! -- With Best Regards, Baokun Li