Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 18 Mar 2022 09:23:43 +0100
From:   Jacopo Mondi <jacopo@jmondi.org>
To:     Wang Hai <wanghai38@huawei.com>
Cc:     mchehab@kernel.org, laurent.pinchart@ideasonboard.com,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] media: platform: Fix build error
Message-ID: <20220318082343.46m5xmnqmjw6q4s2@uno.localdomain>
References: <20220318071028.1356775-1-wanghai38@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220318071028.1356775-1-wanghai38@huawei.com>
Precedence: bulk

Hello Wang Hai

On Fri, Mar 18, 2022 at 03:10:28PM +0800, Wang Hai wrote:
> If VIDEO_IMX_MIPI_CSIS is y but VIDEO_DEV is n, building failed:
>
> drivers/media/platform/nxp/imx-mipi-csis.o: in function `mipi_csis_remove':
> imx-mipi-csis.c:(.text+0x1f0): undefined reference to `v4l2_async_nf_unregister'
> ld: imx-mipi-csis.c:(.text+0x1f8): undefined reference to `v4l2_async_nf_cleanup'
> ld: imx-mipi-csis.c:(.text+0x200): undefined reference to `v4l2_async_unregister_subdev'
>
> Set VIDEO_IMX_MIPI_CSIS to depend on VIDEO_DEV to fix it
>
> Fixes: 4a598f62a03b ("media: platform/*/Kconfig: make manufacturer menus more uniform")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>

Thanks, my understanding is that is fixed in Mauro's VIDEO_DEV rework.
[PATCH v2 00/67] media: Kconfig/Makefile reorg


> ---
>  drivers/media/platform/nxp/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/nxp/Kconfig b/drivers/media/platform/nxp/Kconfig
> index 838abc9766b4..704fcf55697b 100644
> --- a/drivers/media/platform/nxp/Kconfig
> +++ b/drivers/media/platform/nxp/Kconfig
> @@ -6,6 +6,7 @@ comment "NXP drivers"
>
>  config VIDEO_IMX_MIPI_CSIS
>  	tristate "NXP MIPI CSI-2 CSIS receiver found on i.MX7 and i.MX8 models"
> +	depends on VIDEO_DEV
>  	select MEDIA_CONTROLLER
>  	select V4L2_FWNODE
>  	select VIDEO_V4L2_SUBDEV_API
> --
> 2.25.1
>