Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp2397674pxp; Fri, 18 Mar 2022 09:40:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwm0LXTnif4KAFYocLXBnqisUEksIYzAfMKnVoVE5bEgH24OuzYEVAuhguUXTZs/hJ65XhZ X-Received: by 2002:a05:6402:370b:b0:413:3bcd:3d0e with SMTP id ek11-20020a056402370b00b004133bcd3d0emr10240401edb.178.1647621644759; Fri, 18 Mar 2022 09:40:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647621644; cv=none; d=google.com; s=arc-20160816; b=AZuznyUmm+maYfN81qTjG60NFjw7fBbvBztBDpxLZfzKTxW7/zFdMR9kL1BajpmjJg QAUeTzozi2OMMJmj5uZqRcGxOB0hzXoEwtqUf1idd1JC6eiInAdrNe71VSpcxnmSHm/J QhdD+s7G2kxyGWvEn7weageX3qPbgPNUIkhz5oVoMi4mn2LPBPxcL2fHhlhQ6uwTmMuz bOyqNgGQvXgpiDiFu5LOV9heyqC8SX1D9WZbDp2RncCyInBRoXhHaivlI/MlCRgHEhw1 YgPNmHzUAEpy0zMuYg+i5+BWa/9Nq+SMGVxy/mTAsTlgzVjp4F3hcbuOD8YTC7LdmJun /tlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:subject:cc:to:from :message-id:date:dkim-signature:dkim-signature; bh=f1ZVdboT7c9rIoEb7RezDlk6NpIv+NmCnDrOMrXxS0A=; b=OxqsEwxfFrfjHrbLO/Pzc36ChUWpy+l+r0C4niaBhIujHqI9QepQkiy23vj2IC6hFo OOsftm7Nn3FnJOE/MmdGSUwnb2ISrODteXqic4C8LP7M7ILnAkjuSZTGLHaHX42S02/u otuR0e79/VVykuNbueiQ4Ond4IdruGh0i1P/LG2j6qSRytY7K1YsW7aYNR22y2AE/z1n 0cHO05jdx4cr6crfOfFSQIggelCr3Mlbt9XtGYGU4abrm5upr3Tws6eUz2LiV1FAKbnM Z54DDkmeGGXR6wOPoU2C5SMtTFe8YweVTqXHClo9LU9rupmCxMCd7xctAdY+MisuRAE4 tMtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=ceCTjOlC; dkim=neutral (no key) header.i=@suse.de header.b=jr3ZSvPX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u5-20020a170906108500b006df76385c17si1584200eju.183.2022.03.18.09.40.19; Fri, 18 Mar 2022 09:40:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=ceCTjOlC; dkim=neutral (no key) header.i=@suse.de header.b=jr3ZSvPX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235937AbiCRLnx (ORCPT + 99 others); Fri, 18 Mar 2022 07:43:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235913AbiCRLnv (ORCPT ); Fri, 18 Mar 2022 07:43:51 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DABFC23D45D; Fri, 18 Mar 2022 04:42:32 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 96796210ED; Fri, 18 Mar 2022 11:42:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1647603751; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=f1ZVdboT7c9rIoEb7RezDlk6NpIv+NmCnDrOMrXxS0A=; b=ceCTjOlCWBKYX3+xABN2FPaqDSejKfMkQpkv5gL6fy0ueCK/Wi8DM84w6tGEYtXJAHpVWo Llz5V9Rv87K814ny4nDJwcpvIu9Q99/kdD8x5bU6v7/U1Oa3Um/6Bv+0U+0fzhCGziVHGB t36DYVCjFHPa8zHYcKWqYFQiODBRcZU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1647603751; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=f1ZVdboT7c9rIoEb7RezDlk6NpIv+NmCnDrOMrXxS0A=; b=jr3ZSvPXFd/gNfLA5fgldpJISKVyteAJ7QgIKitygi0+2jeXqyKBMxc4UDdikP1+tiWD/1 QRQR3F4JxnaAtvDw== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 69B4EA3B95; Fri, 18 Mar 2022 11:42:31 +0000 (UTC) Date: Fri, 18 Mar 2022 12:42:31 +0100 Message-ID: From: Takashi Iwai To: linux-input@vger.kernel.org Cc: =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= , Peter Hutterer , Benjamin Tissoires , Jiri Kosina , stable@vger.kernel.org, regressions@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [REGRESSION] Right touchpad button disabled on Dell 7750 User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, we received a bug report about the regression of the touchpad on Dell 7750 laptop, the right touchpad button is disabled on recent kernels: https://bugzilla.suse.com/show_bug.cgi?id=1197243 Note that it's a physical button, not a virtual clickpad button. The regression seems introduced by the upstream commit 37ef4c19b4c659926ce65a7ac709ceaefb211c40 ("Input: clear BTN_RIGHT/MIDDLE on buttonpads") that was backported to stable 5.16.x kernel. The device is managed by hid-multitouch driver, and the further investigation revealed that it's rather an incorrectly recognized buttonpad property; namely, ID_DG_BUTTONTYPE reports it being 0 = clickable touchpad although it's not. I built a test kernel to ignore this check and it was confirmed to make the right button working again by the reporter. Is this check really correct in general? Or do we need some device-specific quirk? thanks, Takashi