Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 18 Mar 2022 13:47:03 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     vdasa@vmware.com
Cc:     linux-kernel@vger.kernel.org,
        virtualization@lists.linux-foundation.org, pv-drivers@vmware.com,
        bryantan@vmware.com, rjalisatgi@vmware.com,
        Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH RESEND] VMCI: Check exclusive_vectors when freeing
 interrupt 1
Message-ID: <YjR/RyduLkaQevQp@kroah.com>
References: <20220318055843.30606-1-vdasa@vmware.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220318055843.30606-1-vdasa@vmware.com>
Precedence: bulk

On Thu, Mar 17, 2022 at 10:58:43PM -0700, vdasa@vmware.com wrote:
> From: Vishnu Dasa <vdasa@vmware.com>
> 
> free_irq() may be called to free an interrupt that was not
> allocated.  Add missing 'if' statement to check for
> exclusive_vectors when freeing interrupt 1.
> 
> Fixes: cc68f2177fcb ("VMCI: dma dg: register dummy IRQ handlers for DMA datagrams")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reviewed-by: Bryan Tan <bryantan@vmware.com>
> Reviewed-by: Rajesh Jalisatgi <rjalisatgi@vmware.com>
> Signed-off-by: Vishnu Dasa <vdasa@vmware.com>
> ---
>  drivers/misc/vmw_vmci/vmci_guest.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/vmw_vmci/vmci_guest.c b/drivers/misc/vmw_vmci/vmci_guest.c
> index 6596a54daa88..57a6157209a1 100644
> --- a/drivers/misc/vmw_vmci/vmci_guest.c
> +++ b/drivers/misc/vmw_vmci/vmci_guest.c
> @@ -862,7 +862,9 @@ static int vmci_guest_probe_device(struct pci_dev *pdev,
>  	return 0;
>  
>  err_free_bm_irq:
> -	free_irq(pci_irq_vector(pdev, 1), vmci_dev);
> +	if (vmci_dev->exclusive_vectors)
> +		free_irq(pci_irq_vector(pdev, 1), vmci_dev);
> +
>  err_free_irq:
>  	free_irq(pci_irq_vector(pdev, 0), vmci_dev);
>  	tasklet_kill(&vmci_dev->datagram_tasklet);
> -- 
> 2.25.1
> 

You sent the previous version 2 days before this, and 5 days before
that.  Please relax and don't start worrying unless it's been 2 weeks.

thanks,

greg k-h