Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 18 Mar 2022 02:04:28 +0300
From:   "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To:     Dave Hansen <dave.hansen@intel.com>
Cc:     tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        luto@kernel.org, peterz@infradead.org,
        sathyanarayanan.kuppuswamy@linux.intel.com, aarcange@redhat.com,
        ak@linux.intel.com, dan.j.williams@intel.com, david@redhat.com,
        hpa@zytor.com, jgross@suse.com, jmattson@google.com,
        joro@8bytes.org, jpoimboe@redhat.com, knsathya@kernel.org,
        pbonzini@redhat.com, sdeep@vmware.com, seanjc@google.com,
        tony.luck@intel.com, vkuznets@redhat.com, wanpengli@tencent.com,
        thomas.lendacky@amd.com, brijesh.singh@amd.com, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCHv6 29/30] ACPICA: Avoid cache flush inside virtual machines
Message-ID: <20220317230428.uqfbm6y7v2qbgknn@black.fi.intel.com>
References: <20220316020856.24435-1-kirill.shutemov@linux.intel.com>
 <20220316020856.24435-30-kirill.shutemov@linux.intel.com>
 <f60f4310-8a03-2fdb-d495-be2658f08abe@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f60f4310-8a03-2fdb-d495-be2658f08abe@intel.com>
Precedence: bulk

On Wed, Mar 16, 2022 at 03:13:18PM -0700, Dave Hansen wrote:
> On 3/15/22 19:08, Kirill A. Shutemov wrote:
> > While running inside virtual machine, the kernel can bypass cache
> > flushing. Changing sleep state in a virtual machine doesn't affect the
> > host system sleep state and cannot lead to data loss.
> > 
> > Before entering sleep states, the ACPI code flushes caches to prevent
> > data loss using the WBINVD instruction.  This mechanism is required on
> > bare metal.
> > 
> > But, any use WBINVD inside of a guest is worthless.  Changing sleep
> > state in a virtual machine doesn't affect the host system sleep state
> > and cannot lead to data loss, so most hypervisors simply ignore it.
> > Despite this, the ACPI code calls WBINVD unconditionally anyway.
> > It's useless, but also normally harmless.
> > 
> > In TDX guests, though, WBINVD stops being harmless; it triggers a
> > virtualization exception (#VE).  If the ACPI cache-flushing WBINVD
> > were left in place, TDX guests would need handling to recover from
> > the exception.
> > 
> > Avoid using WBINVD whenever running under a hypervisor.  This both
> > removes the useless WBINVDs and saves TDX from implementing WBINVD
> > handling.
> 
> Looks good.  Did you have more acks on this earlier that got removed?  I
> thought I remembered more acks on earlier versions.

I missed Dan's Reviewed-by, but it was the only one that got to my inbox.

We had few (actually few too many) different approaches to address WBINVD
and some of them got acks. Dan was the only one who acked this version,
before current submission.

-- 
 Kirill A. Shutemov