Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 18 Mar 2022 09:58:17 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Wolfram Sang <wsa@kernel.org>
Cc:     Jae Hyun Yoo <quic_jaehyoo@quicinc.com>,
        Ingo Molnar <mingo@redhat.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Graeme Gregory <quic_ggregory@quicinc.com>,
        linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2] i2c: add tracepoints for I2C slave events
Message-ID: <20220318095817.4ad3a65a@gandalf.local.home>
In-Reply-To: <YjRkvPc9uahbozbQ@shikoro>
References: <20220308163333.3985974-1-quic_jaehyoo@quicinc.com>
        <YjRkvPc9uahbozbQ@shikoro>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 18 Mar 2022 11:53:48 +0100
Wolfram Sang <wsa@kernel.org> wrote:


> > trace printings can be selected by adding a filter like:
> > 
> > 	echo adapter_nr==1 >/sys/kernel/tracing/events/i2c_slave/filter
> > 
> > Signed-off-by: Jae Hyun Yoo <quic_jaehyoo@quicinc.com>  
> 
> Steven, are you happy with the tracepoint parts of this patch?

Strange. I do not have v2 in my inbox anywhere. I checked the spam folders
and found nothing. I had a glitch in my mail server around this time and
maybe it was dropped then.

Let me take a look at it in my LMKL folder, which it appears to be there :-/

-- Steve


> 
> 
> > +	if (trace_i2c_slave_enabled() && !ret)
> > +		trace_i2c_slave(client, event, val);  
> 
> Why '!ret'? I think we should always print 'ret' in the trace as well.
> Backends are allowed to send errnos on WRITE_RECEIVED to NACK the
> reception of a byte. This is useful information, too, or?
> 
> Rest looks good to me.
> 
> Thanks,
> 
>    Wolfram
>