Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 18 Mar 2022 17:38:00 +0100
Message-ID: <s5hzgln1ajb.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Vitaly Rodionov <vitalyr@opensource.cirrus.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        <alsa-devel@alsa-project.org>, <patches@opensource.cirrus.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/6] Add new HW variants and fix few minor issues
In-Reply-To: <20220318155552.24751-1-vitalyr@opensource.cirrus.com>
References: <20220318155552.24751-1-vitalyr@opensource.cirrus.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 18 Mar 2022 16:55:46 +0100,
Vitaly Rodionov wrote:
> 
> This series adds new HW variants for Dell's Dolphin and Warlock,
> and also fixies few very minor issues.
> 
> Stefan Binding (5):
>   ALSA: hda/cs8409: Fix Warlock using dual mic configuration
>   ALSA: hda/cs8409: Re-order quirk table into ascending order
>   ALSA: hda/cs8409: Fix Full Scale Volume setting for all variants
>   ALSA: hda/cs8409: Support new Warlock MLK Variants
>   ALSA: hda/cs8409: Disable HSBIAS_SENSE_EN for Cyborg
> 
> Vitaly Rodionov (1):
>   ALSA: hda/cs8409: Add new Dolphin HW variants

The code changes look OK through a quick glance, but those patches
lack of the proper patch descriptions completely.

For example, the patch 1 says "ALSA: hda/cs8409: Fix Warlock using
dual mic configuration" in the subject, and that's all.  Fix what for
Warlock model?  Why the dual mic configuration makes things better, if
any?

A few other patches have the same problem: it's not clear *why* the
changes are done.  Please give a bit more description.

Also, the patch 4 introduces the code with a wrong indentation, which
is corrected in a later patch.  That confuses readers, too.  Better to
fix in the first place.

Could you update those and resubmit?


thanks,

Takashi