Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] ice: use min() to make code cleaner in ice_gnss
Date:   Fri, 18 Mar 2022 17:46:29 +0800
Message-Id: <20220318094629.526321-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WsEapf0hXeQc83vkTVxit9VO5SPQKdVhKl9clCX6NCVz2Uk7UUU5JOgGI7Yr?=
 =?us-ascii?Q?BMmGL5lLlmNlrpmELM3qNMhBXWy1CMsBPkvt9wOippCMPUp87dhGhCIwg7/t?=
 =?us-ascii?Q?QH47zoaGpG9TKhGF3pIuEIZ+/nSPHmt0yiedjgNw1thLe1g4f/Vdl5hvZiOx?=
 =?us-ascii?Q?pUOfjaFd9Nf/S0Us3Msj1smwEyGTuBNbFW7HHnaLl2Lu9qQuDnE+rnAtZ++1?=
 =?us-ascii?Q?rrC7Z03ZLRpeFyhLG34s47m5lHWIh4/TeXji+Ghsj2z67TwwZTXcFxFDprOa?=
 =?us-ascii?Q?mcVce6f51IP9LgNsIA/zH28Aw6yalMgqdnAgO6J2BMQbV5uV6kjNiSqDcxVB?=
 =?us-ascii?Q?t16xq2lyQaNDizH4JZMMeM0ApU7XStwd/0cesvUeckaaXycUV2Q4GRLkLIIW?=
 =?us-ascii?Q?SgrIZkEm5udryjplgPOhrihNXyOtPBijAvqWsnvoYrfSvd93rqACEhq1wyu9?=
 =?us-ascii?Q?fo1fF9H1qNdjLs9VxP9d8WPqqgC0I/K82fJ8dWHEtStlAoUlbO7EgT7oOovg?=
 =?us-ascii?Q?o2FCG+tJeMwVa8c8afo867RgD+uzIF1EdMcdOePMgChCFbXgzgtLFvNzvFXq?=
 =?us-ascii?Q?2Vrzx3zgvaiHXzO3QON+vcig11iEtHeTuTH1N8E65smoFVpxLa+wOHPlaAUD?=
 =?us-ascii?Q?JQNhFzqzLqbq1cjA+y/y40u7dLDue87Gr4MdMWRuF28CIviGaZr967hrMiZL?=
 =?us-ascii?Q?U5S5AK5mR6Uqi5Qze90SvJr/cFFIVLhH1iKU5VxdljkrUpWsigT3lkk06RVT?=
 =?us-ascii?Q?PFn/VgQw0OZoUGy+fsGpD3MsLKgkvl7DJnza49HI4UjUi5+AW7TqdYtacGcG?=
 =?us-ascii?Q?qIh7GloQJiNiWi88m17XyNVs8fMWz+9AvbEirKlQb7v3XcagxkPw/mZnw4X3?=
 =?us-ascii?Q?hM/+EZijcrONVTRceynPpmUMBmqkK9LG9UCGnzVDjl+4qx3BZSyuvBdbFUSi?=
 =?us-ascii?Q?ZkNJYLSrob7gremPSYLyLZx7rMWbGdwjb9Hge80sYTx8DCTZg/boHPbXtns2?=
 =?us-ascii?Q?P0o6Hrn9YxaFGgSrmXIsoaXFuM0TIpGAoR0yVPCF031bpTxDayQIe/RryEpE?=
 =?us-ascii?Q?jfboifbPBLK19kAUMtL/Yz7UnCj50QBj/VvAqlWl6y+giJLyu61Bb41tmMLX?=
 =?us-ascii?Q?mp9a0EK2Tf+C8N8i3iyiMu3qe5Dzai8V6jLlCevEVQt9gHzhD0j+hkaT67r3?=
 =?us-ascii?Q?aQ1JUQ4CsM/RsfM1IkKLEPRyc8neSERe6TLJN+PJW94sYkR0+e15Bp4/2IV5?=
 =?us-ascii?Q?re/vTvZA4lGgkV5EUXoTTmus5uSQ19JjBQukM8om+dnNcs6PfNo1/Dhq6Q4r?=
 =?us-ascii?Q?D0bEoIq11Z5B2lzPSzTePIm72+9+xYvLeyXARR/A4DWUHJr9P/5R/5canPGa?=
 =?us-ascii?Q?ozMpJYvltPvr9XCQ2aQAMbm1mS3471Pu6WP4+PulJV/3wZeRceivfNrP4TCj?=
 =?us-ascii?Q?+kFAf5/4lpxjo949J0tQdoKCvlDpbxm0?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2244477e-d40d-4813-aee9-08da08c43859
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2022 09:46:48.3984
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oR6NiaHGBmkRExuuEbNqNpaIXhPYTc/2xreFWYuTGrQpTFcAnGSx4ja4jGAXl9Iq3nEjpIxHLEOK1wLQrjTfoQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR06MB5008
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix the following coccicheck warning:
./drivers/net/ethernet/intel/ice/ice_gnss.c:79:26-27: WARNING opportunity for min()

Use min() to make code cleaner.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/net/ethernet/intel/ice/ice_gnss.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_gnss.c b/drivers/net/ethernet/intel/ice/ice_gnss.c
index 35579cf4283f..00fd22e813c0 100644
--- a/drivers/net/ethernet/intel/ice/ice_gnss.c
+++ b/drivers/net/ethernet/intel/ice/ice_gnss.c
@@ -76,8 +76,7 @@ static void ice_gnss_read(struct kthread_work *work)
 	for (i = 0; i < data_len; i += bytes_read) {
 		u16 bytes_left = data_len - i;
 
-		bytes_read = bytes_left < ICE_MAX_I2C_DATA_SIZE ? bytes_left :
-					  ICE_MAX_I2C_DATA_SIZE;
+		bytes_read = min(bytes_left, ICE_MAX_I2C_DATA_SIZE);
 
 		err = ice_aq_read_i2c(hw, link_topo, ICE_GNSS_UBX_I2C_BUS_ADDR,
 				      cpu_to_le16(ICE_GNSS_UBX_EMPTY_DATA),
-- 
2.35.1