Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 18 Mar 2022 17:22:21 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Florian Fainelli <f.fainelli@gmail.com>
Cc:     Peter Robinson <pbrobinson@gmail.com>,
        Jeremy Linton <jeremy.linton@arm.com>, netdev@vger.kernel.org,
        opendmb@gmail.com, davem@davemloft.net,
        bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: bcmgenet: Use stronger register read/writes to
 assure ordering
Message-ID: <20220318172221.68ecb86a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <082a7743-2eb8-c067-e41d-2a3acca5c056@gmail.com>
References: <20220310045358.224350-1-jeremy.linton@arm.com>
        <f831a4c6-58c9-20bd-94e8-e221369609e8@gmail.com>
        <de28c0ec-56a7-bfff-0c41-72aeef097ee3@arm.com>
        <2167202d-327c-f87d-bded-702b39ae49e1@gmail.com>
        <CALeDE9MerhZWwJrkg+2OEaQ=_9C6PHYv7kQ_XEQ6Kp7aV2R31A@mail.gmail.com>
        <472540d2-3a61-beca-70df-d5f152e1cfd1@gmail.com>
        <20220318122017.24341eb1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
        <082a7743-2eb8-c067-e41d-2a3acca5c056@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 18 Mar 2022 14:26:36 -0700 Florian Fainelli wrote:
> Maybe I should have refrained from making that comment after all :)
> Having the Fixes: tag dramatically helps with getting this patch applied
> all the way to the relevant stable trees and surely correctness over
> speed should prevail. If we want to restore the performance loss (with
> the onus on Doug and I to prove that there is a performance drop), then
> we could send a fix with the appropriate localized barrier followed by a
> revert of Jeremy's patch. And if we cared about getting those two
> patches applied to stable, we would tag them with the appropriate Fixes tag.
> 
> It looks like there are a few 'net' changes that showed up, are you
> going to send a pull request to Linus before 5.17 final is cut?

Not unless there's -rc9. We'll just merge net into net-next before
submitting net-next, most likely.