Date: Sat, 24 Feb 2007 01:05:27 +0000 (GMT)
From: Hugh Dickins <hugh@veritas.com>
To: Joel Becker <Joel.Becker@oracle.com>
cc: linux-kernel@vger.kernel.org,
       Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] mm/mincore: Return EFAULT when passed an invalid address.
In-Reply-To: <20070223231112.GM7920@ca-server1.us.oracle.com>
Message-ID: <Pine.LNX.4.64.0702240052360.9507@blonde.wat.veritas.com>
References: <20070223225847.GL7920@ca-server1.us.oracle.com>
 <20070223231112.GM7920@ca-server1.us.oracle.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 893
Lines: 22

On Fri, 23 Feb 2007, Joel Becker wrote:

>  	The locking fix to sys_mincore in commit
> 2f77d107050abc14bc393b34bdb7b91cf670c250 returns -ENOMEM when given a
> bad userspace address.  It should return -EFAULT.

No, I think you're getting confused by the way Linus uses access_ok
on the address range given with the access_ok on the vector address.

Before and after, an access_ok failure on the output vector address
gives -EFAULT.  Before and after, an invalid address in the range
to be inspected gives -ENOMEM.

Which is consistent with the other m* system calls: -EFAULT if
arguments are inaccessible, -ENOMEM if address range is invalid.

Hugh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/