Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0f5f9bd7-fdfe-ec10-071c-a75f981ff317@intel.com>
Date:   Fri, 18 Mar 2022 13:11:26 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.7.0
Subject: Re: [PATCH v4 2/2] selftests/resctrl: Print a message if the result
 of MBM&CMT tests is failed on Intel cpu
Content-Language: en-US
To:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
References: <20220316055940.292550-1-tan.shaopeng@jp.fujitsu.com>
 <20220316055940.292550-3-tan.shaopeng@jp.fujitsu.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20220316055940.292550-3-tan.shaopeng@jp.fujitsu.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YVVET2Y1elZ3QWR6bXNBNENQYWd4QkxpYjlVS0EvZ0JLN0pZSkZWWEN0Wlpm?=
 =?utf-8?B?RTNPTWVTMkZSZDJHSzRaQnJPOVFJRTJSRWhTVGJ3a0JOZGNIazhERVdwZUZ6?=
 =?utf-8?B?b3ZKaVVUOFI3RlA1d1Q4VmtZS1dBWGQ2d3kvY0k1OEp4UXdETytEdkxnTWhJ?=
 =?utf-8?B?czNvVnBWNmp3U1NPdVByMzFTdmFpbUF2b1grS3doSDdsci9sN1NRQldKOElM?=
 =?utf-8?B?SVF0ODZiTHhIVHVUM09DQkdYVkNkVE5HREhOYmNqMloxR1c3dDhKMTdrdWNT?=
 =?utf-8?B?bFNqbXZvUklKbzRkSjZUTFlDb2pkUk9pZ2szTmRjbmVkdlQwTVNEVkQ1bW01?=
 =?utf-8?B?Nkp5U2QzTE9xWlE5eHIvMERKbkNVUWNpdFp1NTd6UEtyVmsyL3pTSEdDK1Nk?=
 =?utf-8?B?N1dUa3pNdTAvcGVSaTlJa3BTanhMQnA4dkNZSGxsS1BOSU5aaUVrajBxUmhL?=
 =?utf-8?B?K3NmRXRsUWRyWTFVQy9rQVYvSWo5azZURnArL01LK2NBTFprc01wL2R5dDNY?=
 =?utf-8?B?QVd2UDNJa21XbTN2OHZmKytFbGFydXY3bFJSMERoVlRCellKSnJYMGxzRTkx?=
 =?utf-8?B?L0w2UzBKVWQyRjVpcWgvZ2JJaDRUVjJKVDZjb3RzQTdvTzJHbzRJQ1lKb29n?=
 =?utf-8?B?SWZidjVvcUJhcm9oRm5vZTRwdFlDMXdYMGdzQ3VGYmdNZStianRYMUZqQUc3?=
 =?utf-8?B?VHlySFRrc3J0dW1STklxZS9ZRkVhMStFWnBqVHE4bEczVkVhOTF6UEdNK2hB?=
 =?utf-8?B?U0wzbldKOTc0QURweFJVWWszWkJWMVRQQlNTV1Q3dzRadSt3VXpRNDVMM3da?=
 =?utf-8?B?bkZMR2dndW9paEtjY1Y5QnZxb3AyS1UyZXpoaUFNbm9DOFh1QzY5ZWFIVmdk?=
 =?utf-8?B?Y1BzWjRuRlNyUnRFYUdpaGQ1cXdkdHRoNy9IZ0YrclFxWVRTeGVLMjJidTF4?=
 =?utf-8?B?WGVYK1F0WFdSRnlxdzFLNUtGNWNQTHBFRmM5THRRZVF6bEVtZXhwZVBKazV1?=
 =?utf-8?B?NnBmVHRnaDJzdFExS29iV3g4TEVhRlpLOVFVYXluL0lXazI0cXZYdXh1SldQ?=
 =?utf-8?B?RVZQazVlc3hSS0lGT3dyZEV2djllWG1GbVVLNGpPVy9UNHpacHVNa2xZT1Vv?=
 =?utf-8?B?YlhRZDVyamZVZXpRY0R6bU5aMXNSZTBKbEVuQ25VZHpaZ2lkd3ZEWVJWRDJa?=
 =?utf-8?B?Q0JMZ3JiTFdyQzVtTjRSMjJrMlVvdDRuTVdsRXFacStVZW11Wnl6aDBha1hv?=
 =?utf-8?B?c1QwVURXYzZSRU84Mi9DRU94bEtnMjRZUUdkbCtnRDdScnc4anpMZmhrZ0Nn?=
 =?utf-8?B?dWU1L3JSS1F1eUVoMkZOQldxbDFXMEhPRWEwWXhuQU5ZMU40R2puVFpDTEV3?=
 =?utf-8?B?RHdFQUVieE00SlFUOXVySkk4UkJ1djNVdUFQcnpMK2FFVjBQY0ltdGpocFdM?=
 =?utf-8?B?YmtsR25MeUtzTGhkVEFlaEJTbTFUdFFmOUNlUFQ1SXZmM3ZQNDlNU0VSWU1T?=
 =?utf-8?B?UDFxZUIrV3ExZHZrdnZYNEJGOEZXaHhqa2hqVC9EVGFRRUgyZnU1TEVSTHVo?=
 =?utf-8?B?Vk1DbE9hdm8yMjV2cnRGVnNUQTJFU25kOGFCbWVUc2pWOC9GbnVzQlBJbDha?=
 =?utf-8?B?a2RXRWNFMkYyZk1la2FLZ1hYSkxYY01ESmR5eE10cFg5S1AyZzg5RnVpMUlO?=
 =?utf-8?B?VkQ0K3FvZGRsbktYWW1kaTlDMHBmRFB4ajMyYWcxcDRza2RLb1lzOHVhanI1?=
 =?utf-8?B?YlNOTUduOXhKQWZZc1lUeFlGc29LZldzV3pRdDdwTUw4dHAxQnFmdGhuMnlS?=
 =?utf-8?B?b3VQNGtCdm5KejZZNjhDcFQxc09MT3JScXdHbEY5Y0JHVlNsUE5QTjJYSXdD?=
 =?utf-8?B?ZlRPVUFXTy9vcmJObVMrYXRKMjJBQmx6dmszeVdwQU1xU1IxL0hCdVViaEZS?=
 =?utf-8?B?dUlSMlk0MytkRm5nb08xcEQxRThOZkk5RlhGeU9rY2ZXOU4xL2RGdWJwR0sz?=
 =?utf-8?B?K09XWDJMZWlRPT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b8f0a147-d83b-4f8d-51b1-08da091b7e33
X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2022 20:11:31.4436
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RQR+opczXJgxDgobwa15BHBL9SnRBLzJ2xMzLpTJFeS7QqZhAmq+gQv7XWIjiznQwgTRNmRdIFkIjzayu9jgSBuoRVkkGnd06SzQ6W0BWAk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB3985
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shaopeng Tan, 

Please use capitalization for CPU (in subject).

On 3/15/2022 10:59 PM, Shaopeng Tan wrote:
> According to "Intel Resource Director Technology (Intel RDT) on
> 2nd Generation Intel Xeon Scalable Processors Reference Manual",
> When the Intel Sub-NUMA Clustering(SNC) feature is enabled,
> Intel CMT and MBM counters may not be accurate.
> 
> However, there does not seem to be an architectural way to detect
> if SNC is enabled.
> 
> If the result of MBM&CMT test fails on Intel CPU,
> print a message to let users know a possible cause of failure.
> 
> Signed-off-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
> ---
>  tools/testing/selftests/resctrl/resctrl_tests.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c
> index dc548d3e2454..97ad6cfee6ee 100644
> --- a/tools/testing/selftests/resctrl/resctrl_tests.c
> +++ b/tools/testing/selftests/resctrl/resctrl_tests.c
> @@ -86,6 +86,8 @@ static void run_mbm_test(bool has_ben, char **benchmark_cmd, int span,
>  		sprintf(benchmark_cmd[5], "%s", MBA_STR);
>  	res = mbm_bw_change(span, cpu_no, bw_report, benchmark_cmd);
>  	ksft_test_result(!res, "MBM: bw change\n");
> +	if ((get_vendor() == ARCH_INTEL) && res)
> +		ksft_print_msg("Intel MBM may be inaccurate when Sub-NUMA Clustering is enabled. Check BIOS configuration.\n");
>  	mbm_test_cleanup();
>  }
>  
> @@ -122,6 +124,8 @@ static void run_cmt_test(bool has_ben, char **benchmark_cmd, int cpu_no)
>  		sprintf(benchmark_cmd[5], "%s", CMT_STR);
>  	res = cmt_resctrl_val(cpu_no, 5, benchmark_cmd);
>  	ksft_test_result(!res, "CMT: test\n");
> +	if ((get_vendor() == ARCH_INTEL) && res)
> +		ksft_print_msg("Intel CMT may be inaccurate when Sub-NUMA Clustering is enabled. Check BIOS configuration.\n");
>  	cmt_test_cleanup();
>  }
>  

Thank you very much for adding this.

Acked-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette