Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc:     mingo@redhat.com, bp@alien8.de, dave.hansen@intel.com,
        luto@kernel.org, peterz@infradead.org,
        sathyanarayanan.kuppuswamy@linux.intel.com, aarcange@redhat.com,
        ak@linux.intel.com, dan.j.williams@intel.com, david@redhat.com,
        hpa@zytor.com, jgross@suse.com, jmattson@google.com,
        joro@8bytes.org, jpoimboe@redhat.com, knsathya@kernel.org,
        pbonzini@redhat.com, sdeep@vmware.com, seanjc@google.com,
        tony.luck@intel.com, vkuznets@redhat.com, wanpengli@tencent.com,
        thomas.lendacky@amd.com, brijesh.singh@amd.com, x86@kernel.org,
        linux-kernel@vger.kernel.org,
        Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [PATCHv6 16/30] x86/boot: Port I/O: add decompression-time
 support for TDX
In-Reply-To: <20220317201547.haoyqy2iaid7lku3@black.fi.intel.com>
References: <20220316020856.24435-1-kirill.shutemov@linux.intel.com>
 <20220316020856.24435-17-kirill.shutemov@linux.intel.com>
 <87a6do22t6.ffs@tglx> <20220317201547.haoyqy2iaid7lku3@black.fi.intel.com>
Date:   Fri, 18 Mar 2022 15:28:57 +0100
Message-ID: <874k3vcp1y.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Thu, Mar 17 2022 at 23:15, Kirill A. Shutemov wrote:
> On Thu, Mar 17, 2022 at 01:15:01PM +0100, Thomas Gleixner wrote:
>> On Wed, Mar 16 2022 at 05:08, Kirill A. Shutemov wrote:
>> >  void early_tdx_detect(void)
>> >  {
>> >  	u32 eax, sig[3];
>> > @@ -23,4 +94,12 @@ void early_tdx_detect(void)
>> >  
>> >  	/* Cache TDX guest feature status */
>> >  	tdx_guest_detected = true;
>> > +
>> > +	/* Use hypercalls instead of I/O instructions */
>> > +	inb = tdx_inb;
>> 
>> Eeew. What's wrong with writing this out?
>> 
>>         pio_ops.inb = tdx_inb;
>> 
>> So it becomes obvious what this is about?
>
> This leads to preprocessor hell: "pio_ops.inb" is expanded to
> "pio_ops.pio_ops.inb" :/
>
> I can rename fields in struct port_io_ops to avoid conflicts, I donno.

Yes, please rename them.

Thanks,

        tglx