Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a7b28139-c097-385d-be22-c61f82409626@intel.com>
Date:   Fri, 18 Mar 2022 14:00:49 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.7.0
Subject: Re: [PATCH v6 0/6] selftests/resctrl: Add resctrl_tests into
 kselftest set
Content-Language: en-US
To:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
References: <20220318075807.2921063-1-tan.shaopeng@jp.fujitsu.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20220318075807.2921063-1-tan.shaopeng@jp.fujitsu.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?REJha0ZIdHNCRDB2OXVEcGY5MTNEYS9wUUdhTCtYWjJhRGhoYVlmaitORjJG?=
 =?utf-8?B?TnhnVDJOSFUwU284VDViVlVRNGNnV294Y3hvVVpQdmxLWFFiTzNtZCtVVWFR?=
 =?utf-8?B?UlpuMmlzUlhjVkl0OCtyak94SWk1R2tlK3htdmc3S2ZrNVk3S2k3d0xHaklS?=
 =?utf-8?B?Umt5c0k4SjdsQmtOdFcwU2J5NUYzN3dKSm15aHpVVmU3WmRibFNUM09uZEwx?=
 =?utf-8?B?SFBuWmVsNk9LS0hSaFpRdHFtdUtUaE9pSWRWcTREQVdWeVpYdFNwTDFtOFRJ?=
 =?utf-8?B?THU5VmpWVFNhSk4wdVNIRlBiYzFFZkI3YjFyUUh5cnh2S3ZPY0JUQTBQMlJt?=
 =?utf-8?B?WU1qcVhXL2hUWDNXeHlIQVFBUDI0Q0NFN3pWcGV2RFhkNnBYM1d4bTVya29z?=
 =?utf-8?B?bDR3K0NmNG82MUhGWm5PZG1VQTEvK1VzZ0VKWUZxUjZSMEMzdHphRjhqNlY5?=
 =?utf-8?B?Z2R5Q0dvaFN6WUM1UW5JWDVKL0daQ1B0SWxyaFpyS2Iyc1lrend2NVVFdmZy?=
 =?utf-8?B?QitZSytMcGo2bnd2Y3lWQ2R3WnFZOHQyc0F2UVhuTGVyY1lQdSsxTmllSlhn?=
 =?utf-8?B?d2pueEZoL3ViWVV3YmF4dENjV1pVdDlWSWxMclkwUEpwbGsyR3pTWEJqTkdG?=
 =?utf-8?B?aGFUV3E1WTBKNWhYdGFxQ0gvQWdLSnp2Ym9IR2sycm9wcTBBVlBMc0o5ZHAw?=
 =?utf-8?B?aGNIRHlOVmdrY3o4ZFhvakI0am10Z2F6QXRIbEdtTTVHZUdDUWoycDE1OHVH?=
 =?utf-8?B?RUhJVG4zMWdZM080TzZDWm42TjE2VVpwV3hnaFVvOXo0Uzd0VnpZbXV5Z1da?=
 =?utf-8?B?YUNpRU9uR1hBcFVlY0dTSHZWT2Fwd1lTVDBtWVdSN2xTbkovZGVrV3BJZ3Za?=
 =?utf-8?B?M285dlhZcmNSUi80VkJWTEVJb2dVVG02SFRuNFNrRm9TeUc4TWMwNWZibC84?=
 =?utf-8?B?VTQxcW5rTWZHMS9OSFRKOVg4b3pFZmdyY2NHTDZ0bHh5TXBvMEtUTU9DZlps?=
 =?utf-8?B?L3RBNFY2eEJOeng3Rk5MY3FTa2dMcXIwL0tyYzU2dXA2aVV3Q0g3aXFpSUhD?=
 =?utf-8?B?a1dQSC9wUEJCM0RScm1QSUw0cWhpUjZuZG52aU5TOTRDNUFFc0lHcDlQbDhC?=
 =?utf-8?B?UDhjRVhsK1ZtUmdQSG1YZ3ZFbXp4b0E0TFM2RG1mNllxd1NOYkE2eS82d1Fj?=
 =?utf-8?B?ZEN2STU0WGFNWWhUQjlzSCthcVRCTFFWc0RXRDROYVk5YWRzYzhYVHQ3RGxJ?=
 =?utf-8?B?M2hxbm5mS1FIWU9VZ3NsQ29uT2NXbzN5OEtMM2tXVEpOM3Y3bFQzVm95b3Zv?=
 =?utf-8?B?cDc1SE5SWUt0cUM4OFVBc3dMTXdUSjhQZytiVGhwdTFFanlSQ0VKZVdtVURx?=
 =?utf-8?B?QlZqTGtkbkxnbDVBYUp1bXhtT1FTUmpYcUM3WDZkUXBkb21LRHFSZi8xOHUy?=
 =?utf-8?B?WDU0UTlIMEQvajFvOHcyNTJYQWZjV1RhUko4blU2ZW1FMWtwOFFHN3lqQThq?=
 =?utf-8?B?UFA2c1pUVjBYQVhLTmk1TXovbDZYWVUrYmY2YTRRNXBKQUp4V1k5bWxpdDdk?=
 =?utf-8?B?V3dVUzBXcmxoVit1Tzd4K1VkNW1TejBwWlpRZlVKbUtCWWZwNktINEZBT1ho?=
 =?utf-8?B?Y2xvVGJVL21IT1RnNWcyZk9Gd211V1E2WVdSOG1NUmdDNDVNOE1PeTlSeXAr?=
 =?utf-8?B?K1ZiVVRTcTVURWM2Q0FvOTlxK2pkSCtFdzJjRHVaT0djV2NFZnA0eDV6NU1h?=
 =?utf-8?B?OTlIN1d4cktLSXJIdUdrQzNTckJOb1FaNzBLUGJxR1o0Mi9hd2ZDMkYzREUv?=
 =?utf-8?B?OVgzZGd4NmVtK3Y4OFB4OFkyeENiUXhaQlpzWU51Tk4rdzMzcVkrRkNhSEhW?=
 =?utf-8?B?S0lhbG15YW1kWE1YK3cvdFdaYXJjT0d0ZXhwRWtRZGkvMER5RU5ZNGgyQTdJ?=
 =?utf-8?B?N01QdzdkWmd0Vjl4cE90Z0Jycm5INmRPcVNEeVpCOU4waDlhWVliSy9SaThr?=
 =?utf-8?B?VE9OOUhqZTNnPT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 49779a24-3c20-4bc7-1757-08da092263d5
X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2022 21:00:53.6356
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NWTgsnCERPAwr3JTtI47ylL9IMTCSYS7UwcjvqmLu7EWy0MrLHSmlISiwHagkOY2XM5WHAq8khK4vmwkQ2lJ2hv/J60ZThqYfS2At2PvvH4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2146
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shaopeng Tan,

On 3/18/2022 12:58 AM, Shaopeng Tan wrote:
> Hello,
> 
> The aim of this series is to make resctrl_tests run by using
> kselftest framework.
> - I modify resctrl_test Makefile and kselftest Makefile,
>   to enable build/run resctrl_tests by using kselftest framework.
>   Of course, users can also build/run resctrl_tests without
>   using framework as before.
> - I change the default limited time for resctrl_tests to 120 seconds, to
>   ensure the resctrl_tests finish in limited time on different environments.
> - When resctrl file system is not supported by environment or
>   resctrl_tests is not run as root, return skip code of kselftest framework.
> - If resctrl_tests does not finish in limited time, terminate it as
>   same as executing ctrl+c that kills parent process and child process.
> 
> Difference from v5:
> - Changed skip message when resctrlfs is not supported. [PATCH v6 3/6]
> - Changed resctrl's Makefile to always build with latest kernel headers and
>   keep enabling gcc checks to detect buffer overflows. [PATCH v6 4/6]
> - Made README easier to understand. [PATCH v6 5/6]
> https://lore.kernel.org/lkml/20220311072147.3301525-1-tan.shaopeng@jp.fujitsu.com/ [PATCH V5]
> 
> This patch series is based on v5.17-rc8.
> 

I do not think this is accurate because the KHDR_INCLUDES you use in patch 4/6
does not yet exist in v5.17.rc8. It seems to be available on the "next" branch
of git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git

Reinette