Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a9d5ee7f-85cd-4294-2be6-8f7df6c982ad@intel.com>
Date:   Fri, 18 Mar 2022 13:59:23 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.7.0
Subject: Re: [PATCH v6 4/6] selftests/resctrl: Make resctrl_tests run using
 kselftest framework
Content-Language: en-US
To:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
References: <20220318075807.2921063-1-tan.shaopeng@jp.fujitsu.com>
 <20220318075807.2921063-5-tan.shaopeng@jp.fujitsu.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20220318075807.2921063-5-tan.shaopeng@jp.fujitsu.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZWVGWG9pdnVNRlM5MTRCNDV5SGJXMm84V0RzdEFVWEllYkJoR2NtM0kvV0xk?=
 =?utf-8?B?eldzbmppRmwxS0JwQmtqNWtoNFFHb3ROblVnVWZWbEpyYTY2K3crem4zSnZn?=
 =?utf-8?B?cW1WSG5rNUg4MFQ4Y01OdWlOMFltQ3FWQ2NHbFpwL1UxL0d5NnR4U0NJRldE?=
 =?utf-8?B?dWZMTCtoT3JaaHZQUXJkZldwSFlOTHMyaVlMZTFGRm8yRjRaSzVlNkNGRG12?=
 =?utf-8?B?ZVNYcyt3cHRhNnZHcFZpYXEwYTcrRGtobTRVMW12TmZXY0RXdk9TdTgvdC83?=
 =?utf-8?B?ZVdLZmllcmJuK0I4WlRpdVhZVnNrS01GT1liekRWNmF1emVTVjVTSDFTeHhZ?=
 =?utf-8?B?VWZoYXRTZ0xEM3FSVUJIcEJHWThHaXVCTUtjblZlZFRxbXVIMFQ1VExueEM2?=
 =?utf-8?B?dnk5bngrZzgvN0Z6Y1hMRzF3eWpodGxURjNWV2d3MTBzYmhSb1ZuckZrMGRR?=
 =?utf-8?B?dVBibTdPWnZHNUM3dGo0b3RCQVhhNVpzNWRZaTlpUWRpM3F4WUNEanAyVW5G?=
 =?utf-8?B?WXZzTHl4aEtLS01mcUNLS3BzNWJNa2JDelB6ckhGdVVOQ0svRWN3bjkvU1Uv?=
 =?utf-8?B?VHZNeC9Dc3hvMzFuazVVRWpOZmlnekxjOG1OS0pkclZmWlgvczAvQmVxeU5q?=
 =?utf-8?B?ZUEreERPN0trYkh5dUFVeVZ6Z2UwSkVicDRDd2ZpcWpTbzFRRFk4VnpVOUl3?=
 =?utf-8?B?ODR4ZURicmdOM3o4dWs4MzdHYnU4RFZ5bmk1bzErYzZzWUFvckx6ZUJ1SUcw?=
 =?utf-8?B?d1hVbmF3KzcyOVNHZitUd1dLUkxwTnMrSUZNejNMbHhFSGxya2NHNFdldE9G?=
 =?utf-8?B?VnlMYWJucWdRYjNXdUJMWGR0MG8zUDRuakVkQzVKcW9HQytudk4rSXFuSFN0?=
 =?utf-8?B?RjZQYUZMcjkzdDV4NW5sdHg0RFFqZSt0U3ZBZFI5djFhSWRkWkpQNHpoUGgy?=
 =?utf-8?B?a0JycStKQjRENFZtekJSS0xqL1NQRXBxckxJWVc2NG9DclpLN0R4WlQwejgx?=
 =?utf-8?B?QjBYY0Q3bVdkOHBjMVNzdEhuL05nZ05Pbm1BUXZHbktMNUsxTFZJOEdMWXNt?=
 =?utf-8?B?Smo3MFBlZ0U1UlFwNmo4WkVSQXZYYTg1cDRGaDY2Y0tSTGdjSlg1MThJbmpo?=
 =?utf-8?B?bW9jeVMwM2RubExJWEhuK1VrMEk5VFV4dXpKdmg2dkEzTFpUWmhMVUZENkxK?=
 =?utf-8?B?Rld2UUZVUVBKRjVaVnlKUUpnZTBuOFVuSWg5UURFa0xqZDNWUDhqMzBmbko4?=
 =?utf-8?B?d2hYZnQ5OHlIRXBnSkwzUkhvVEdGa3U5bUJaR244ZHpTbENZMjNnbkZCb3Fw?=
 =?utf-8?B?THdLRjFoMi8zUWVqank5WUhWUDUrSEtEK0xHWExvRkxoWHBtbVJJV05uRWRu?=
 =?utf-8?B?dXVnZ1dGSXZBaHorTEtwT1VyS1Excy9ybGZXbmV4cDdaNUNTeW9yd2s5SGw1?=
 =?utf-8?B?czFmMjlyN1N4WE4xNkx0UTBGd2JWU295VVNHbmUza0tMSDJXNVFtQjE2L3E4?=
 =?utf-8?B?WENEa0ZRNGh4dFBLSTRHUDZ0cXBHWlhnUkh2NVhRU0o5MGlQMENPVC8vUXVB?=
 =?utf-8?B?cXpCMi9ONVp6Mk9YRXlEaVNWTVpzUHZGQzVDa0FMSE1CNkNCNUI5RGNWSlpH?=
 =?utf-8?B?NWhjSVBmMHRwSjNNUkJYRFN5RGRxcXZ0alRpSGh0ZWZacnZicENzK2FPMy9Z?=
 =?utf-8?B?eVJZbDlpOG4xL2EyQkRHcXNrNWFvRTVTeGEvbWR3STNWR2dhbUw4dElXeXBx?=
 =?utf-8?B?QXFsT0dIc2hjSlgvQXRnNFdXOHA1bTJJZnJUM2NqLzl4c3B2TENFZGFKZGVB?=
 =?utf-8?B?dHBZcDVjRmVQeVVnSTFXQ1hWcmU4SEE2ZS9pUGRWeFRmSkRXTWpUOXNKK045?=
 =?utf-8?B?VnJzbnpQWjBjelhtbXcvcGxEMGZCMUkreGZiV0FrWG9RWDRUWVpMZTg5VXkx?=
 =?utf-8?B?UVFIcTAyZUtwcGxqOUpzTkd0aXJYRTdPNTN3aDVrT1pNUkdJM1NhMWpncXpL?=
 =?utf-8?B?b3MwUE9taVNBPT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f8e4352-358e-46cc-edb9-08da09222fe9
X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2022 20:59:26.5318
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IWd3cQNSWy1sgh9FK8eHrJ8/SlRSi1o30/Kip7HD0MySCXjRsVH7FTRvNzqsPsRyjQrceOJJQBAMB8Ual0tt+kgu2JFUjxWqm8vqasAwa8M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1558
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shaopeng Tan,

On 3/18/2022 12:58 AM, Shaopeng Tan wrote:
> In kselftest framework, all tests can be build/run at a time,
> and a sub test also can be build/run individually. As follows:
> $ make kselftest-all TARGETS=resctrl
> $ make -C tools/testing/selftests run_tests
> $ make -C tools/testing/selftests TARGETS=resctrl run_tests
> 
> However, resctrl_tests cannot be run using kselftest framework,
> users have to change directory to tools/testing/selftests/resctrl/,
> run "make" to build executable file "resctrl_tests",
> and run "sudo ./resctrl_tests" to execute the test.
> 
> To build/run resctrl_tests using kselftest framework.
> Modify tools/testing/selftests/Makefile
> and tools/testing/selftests/resctrl/Makefile.
> 
> Even after this change, users can still build/run resctrl_tests
> without using framework as before.
> 
> Signed-off-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
> ---
>  tools/testing/selftests/Makefile         |  1 +
>  tools/testing/selftests/resctrl/Makefile | 17 ++++-------------
>  2 files changed, 5 insertions(+), 13 deletions(-)
> 
> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> index d08fe4cfe811..6138354b3760 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -52,6 +52,7 @@ TARGETS += proc
>  TARGETS += pstore
>  TARGETS += ptrace
>  TARGETS += openat2
> +TARGETS += resctrl
>  TARGETS += rlimits
>  TARGETS += rseq
>  TARGETS += rtc
> diff --git a/tools/testing/selftests/resctrl/Makefile b/tools/testing/selftests/resctrl/Makefile
> index 6bcee2ec91a9..bee5fa8f1ac9 100644
> --- a/tools/testing/selftests/resctrl/Makefile
> +++ b/tools/testing/selftests/resctrl/Makefile
> @@ -1,17 +1,8 @@
> -CC = $(CROSS_COMPILE)gcc
>  CFLAGS = -g -Wall -O2 -D_FORTIFY_SOURCE=2
> -SRCS=$(wildcard *.c)
> -OBJS=$(SRCS:.c=.o)
> +CFLAGS += $(KHDR_INCLUDES)
>  
> -all: resctrl_tests
> +TEST_GEN_PROGS := resctrl_tests
>  
> -$(OBJS): $(SRCS)
> -	$(CC) $(CFLAGS) -c $(SRCS)
> +include ../lib.mk
>  
> -resctrl_tests: $(OBJS)
> -	$(CC) $(CFLAGS) -o $@ $^
> -
> -.PHONY: clean
> -
> -clean:
> -	$(RM) $(OBJS) resctrl_tests
> +$(OUTPUT)/resctrl_tests: $(wildcard *.c)

With the addition of KHDR_INCLUDES care should be taken to ensure
that this work follows the work that introduces this to kselftest since
it is not in mainline yet.

Apart from that, for the resctrl bits:

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com> # resctrl changes

Reinette