Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp1056119pxp; Sun, 20 Mar 2022 05:05:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwRTj7TWDTlfE1DxQTOJBfz/rJL0RsjQEtprxPbNX7RB2z2yaia5h7WAjkQZgixRY0TMug1 X-Received: by 2002:aa7:c04a:0:b0:418:d7e5:cd51 with SMTP id k10-20020aa7c04a000000b00418d7e5cd51mr18065512edo.385.1647777958120; Sun, 20 Mar 2022 05:05:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647777958; cv=none; d=google.com; s=arc-20160816; b=qScIogzIeWnIDz1ukLf435drYqdEx/ju9WtQC9VRfSZ5K4tV1RrnaXVbpx9Swx4wgN A/qTOXMjE/mvD1Igw8T2+XyUyobvGnP05es7kUsER3gKffddjs3Hdfn9BNrPLJ6oGcB3 Pl3RLqczY8rhVNX8JxagatCo9xRQDX12voi1WY0vf7qFjct3e78Oqq8+2bbO4HYAcF16 OCgLXfVdX9ObckyHl5FHZvhQOBw+xTUaitMQkU/BgeMegBSgN0qO8qqGQ5KEyAQ2JpoB YBqtdc2X51aq6lCdOjB5D/Mkt10avzfbqD9EdEMocA6GCspqudg4InUWbH5FamsVUiPn QUrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=lDI0a+FENS7GQ6v1qRTDegIUwmD6Wc2G5fDgnwPC4tM=; b=gSLfOAbPKreE/oTjFcjZmVo9DeXo0Jd9swp7pfd2Q55GNKNJVgvMnj4HBiPx83/mKQ 8IWY9Z37/6ip9qyRIAbSl/FtHuSSKxr9KaRwXsCcgKiNnE5MYXOxjCtu85013vUyKwkX P0Pqdtr9JSzpb9HuGoJ0PCr7haCj+dYrhwfPhERKcdI2SeSLT9EJ3fOtaB6vlwlBUJYR UsrHL3l5ehfgTwOrxEhGkerEy0ljFNMLRESzwcMA2dLhll7IDy92MNMh2/sVUgEtVffK sfvrNqPUewV0CaZZWMAz+yZbnq7kVDvoQVFWZAEeZiyFnSMVf0fnVeVoOA2+7OToaU+U 9UPA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v20-20020a17090610d400b006df76385b83si4990954ejv.35.2022.03.20.05.05.32; Sun, 20 Mar 2022 05:05:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242259AbiCSGVh (ORCPT + 99 others); Sat, 19 Mar 2022 02:21:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242252AbiCSGVf (ORCPT ); Sat, 19 Mar 2022 02:21:35 -0400 X-Greylist: delayed 570 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 18 Mar 2022 23:20:14 PDT Received: from mail-m17671.qiye.163.com (mail-m17671.qiye.163.com [59.111.176.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 914BE97298 for ; Fri, 18 Mar 2022 23:20:14 -0700 (PDT) Received: from localhost.localdomain (unknown [183.6.116.60]) by mail-m17671.qiye.163.com (Hmail) with ESMTPA id 42C0F2E0023; Sat, 19 Mar 2022 14:10:41 +0800 (CST) From: Yi Li To: linux-kernel@vger.kernel.org Cc: yilikernel@gmail.com, joseph.qi@linux.alibaba.com, jlbec@evilplan.org, mark@fasheh.com, ocfs2-devel@oss.oracle.com, Yi Li Subject: [PATCH] ocfs2: refactor the noqueue_attempted Date: Sat, 19 Mar 2022 14:10:28 +0800 Message-Id: <20220319061028.3152-1-yili@winhong.com> X-Mailer: git-send-email 2.25.3 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUhPN1dZLVlBSVdZDwkaFQgSH1lBWUMYGRhWH05IGhofQkpDTE NLVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktISkNVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PDo6Iio5Fj4CDRoKTyo2FRcI NxwaCUNVSlVKTU9MTUxLSU9KTUNDVTMWGhIXVQISFxI7DBIVExQVHFUYFBZFWVdZEgtZQVlKQ0hV TVVKSk1VTUtZV1kIAVlBSk1CTzcG X-HM-Tid: 0a7fa0cca8aeda56kuws42c0f2e0023 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE,T_SPF_PERMERROR autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The variable noqueue_attempted just set when DLM_LKF_NOQUEUE. refactor the code. Signed-off-by: Yi Li --- fs/ocfs2/dlmglue.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c index 801e60bab955..6315757c164d 100644 --- a/fs/ocfs2/dlmglue.c +++ b/fs/ocfs2/dlmglue.c @@ -1547,12 +1547,11 @@ static int __ocfs2_cluster_lock(struct ocfs2_super *osb, } if (level > lockres->l_level) { - if (noqueue_attempted > 0) { + if (noqueue_attempted) { ret = -EAGAIN; goto unlock; } - if (lkm_flags & DLM_LKF_NOQUEUE) - noqueue_attempted = 1; + noqueue_attempted = lkm_flags & DLM_LKF_NOQUEUE; if (lockres->l_action != OCFS2_AST_INVALID) mlog(ML_ERROR, "lockres %s has action %u pending\n", -- 2.25.3