Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2c030a61-1847-52e8-ab68-dee5b6e4d7bd@intel.com>
Date:   Fri, 18 Mar 2022 13:58:53 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.7.0
Subject: Re: [PATCH v6 3/6] selftests/resctrl: Fix resctrl_tests' return code
 to work with selftest framework
Content-Language: en-US
To:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
        "Shuah Khan" <skhan@linuxfoundation.org>
References: <20220318075807.2921063-1-tan.shaopeng@jp.fujitsu.com>
 <20220318075807.2921063-4-tan.shaopeng@jp.fujitsu.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20220318075807.2921063-4-tan.shaopeng@jp.fujitsu.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TVFUaUsrYjZ3LzlEdFlGRFMyeGZWc1lIL2J6Q2lxSXh4VHFQWVBjY0t3dUU2?=
 =?utf-8?B?eDNUSWZOL3VjSXNYcnhtNjlFZVpYOGdjQ0lUcmptMUhVekpVYUNnTEtyR21j?=
 =?utf-8?B?QmUyOU9hd2lxVjM2NnM0T0FaTkl5NU1vVmxlOVZFZkI3VkRTaktweENRRUlC?=
 =?utf-8?B?eEQ2TGJqc3MvdXVlTnVwYWlVQzZSa3JraVFrL2c5MEFlcStmVUNCaU51S2Jv?=
 =?utf-8?B?eHZXRDArRXVkWjJRRzBDTjlsMjNNampXN2FXV0FMT1JaWG1IUDZDYWNMMzY1?=
 =?utf-8?B?a2FINWRreTdLRXllakJaTE0vWXZ2TEhqaU51bVFIdThxS2tiQUttVm1rSEFt?=
 =?utf-8?B?SUNKOHpkU2dVMmNPZlV0NUNmRlJtSXpvTnJsNm1kWkdzMjdWOW05Z2RkM2lC?=
 =?utf-8?B?OEhFcWl2QUdXY2R6dGZYT3ZlWGV1VGxjajd0WmlXQWtHbGZPNkdvSUdFVDBa?=
 =?utf-8?B?ekhHNWtjY2pNbmZtazMvUHZJL2VDZTA1aWFRZGlNS1lxV0N0ZXBpTkpRQWJ0?=
 =?utf-8?B?VHJ2bjVhUDFpamZZN3dmeldsYzhTNUtLbWtDSVY3eXhVNm5PZ1hqamNlRUVR?=
 =?utf-8?B?c1M1elYwOWh1c0d3cjU5MlQwT1lJcy96ZmtFcDdCZW9pelZaWFh6RlhpUDVl?=
 =?utf-8?B?ZXdrRFNxeDBHMWtPczFmU2RaRVVhOUl4NFVxN1E5ejVieTJQM3RSZWZVNERP?=
 =?utf-8?B?SkI0SUZNQ1R3NGNYd3NoeDNIS2FmUWxzaHpHSFhkUjZBN0RyUFRNc0hYL0tu?=
 =?utf-8?B?QldlME0wNTFrUytDQ2xXZkljcVFLNTVtcndmTlJsRGpuZmVSMFhmVDBRYmsy?=
 =?utf-8?B?dUFNcEtuRGxUV0lZanJKeUMxWkEwWTUwalpxaSszSlhMNjJwK2FUNVRvKzhM?=
 =?utf-8?B?RnR4QzJMclkwbU1VcVp1bm0zKzhQRUR0MldNL09YaUI4OXBZeTUvUG9YMmhY?=
 =?utf-8?B?dGs2Y0JwWFdLcTAwbENDNk14aHI2NUVxK0lMay9qcVU5elUwTk9lVVk4SVc2?=
 =?utf-8?B?S0RLNHU5U1ZWclRTNU5Na2ZZb1pIMXFPOUtsNkRMT3FiWXB0TDRHbjJqdWJU?=
 =?utf-8?B?QzBHZkZHQkxqMUtXMU0wSW9IZkFRcUV5amdNTll1dkJRaW1lUFVEcGM1ZjlZ?=
 =?utf-8?B?UldSSFpjeUNGMHU3WjZOVEM4YktxSUN4RlJDTDBvbVZOWEtCZDdPejA2RWN6?=
 =?utf-8?B?dXcweXFSZFowNkFTOGFTSmtYb0pvdXRMdDltRGxoY0JHSGJXR21aNHNlcXlr?=
 =?utf-8?B?M3crdm9BbTVwVnVDd2xjNU5NNkpDcTVuRzI4VytvRFQ4U2RRRWhDNElvYkd4?=
 =?utf-8?B?azgvbmJSV0s2V25NejV5ZkxvRWo0cUN1YjJtK3lVSXdVTE1IUGJSb0FTUmVa?=
 =?utf-8?B?Q3JSWXI5QUZtejlzNnFTcWpTV0JzTU1qU3ZpMFBoNHlDaEFnNnJnZjJVc0dX?=
 =?utf-8?B?VnhERkdtTG9hZFpqVnEveVgrVVF6MnJrWjVWS3FLbzdHNnl3L21kNldwTmU4?=
 =?utf-8?B?TmJaQVAyL0F4QXYzdnlWQzRYVUlIc1dDaGVDcytoaGxPUTFGR1Q2ei9YSk82?=
 =?utf-8?B?bHliTVAwa3NUV0g2emlSWERrR0xnTmVRalZJdnB3d3RaQTljaWZWZUNpaDBq?=
 =?utf-8?B?SjEwRENTTUVYWG1oeStkT2xjTzJMWWIwa1lKemJrWjFIeURreGhsZEpLSG0w?=
 =?utf-8?B?WXBKanVxY2twVGIzWXB5YVQ4eG84RlNlSzM1WW9qb25kMkluVVVHY250SzNT?=
 =?utf-8?B?Q0tWYUZTd3RDdE1EbDlCMVMrU1cxRy9pclNNVjRzbmJGcXlvQ2Q0NlJMUmhH?=
 =?utf-8?B?TDcvZ21hSk05VlM0OHpiM2lXVUxNcFRPdjVRaWxVZThhMXFLR2FtcnZKR09s?=
 =?utf-8?B?ODJzby92YWNxZFA5STJpaWRLbm5VRXpQeEFtdVpvM2Z5amlOaCtXc082VFZq?=
 =?utf-8?B?TkVEb3BZa3g3NjhLU1ZIai9LVmNBaStTdVl6VWNXK2JhRFkydENHMFJSdzl3?=
 =?utf-8?B?emhUOHA3NkVBPT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 340f84fd-1228-4966-b93a-08da09221e78
X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2022 20:58:57.3299
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xvwNdXKaqEpOOGYAPZkYY/y9pqXW4fuXQrluaKhZvjKU2p/Ycv4A7B+KraTSoYDd/WWSEBt+9MsX4qXw5etecjAlghtjxT3V7dKKCZq0fwQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1558
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shaopeng Tan,

On 3/18/2022 12:58 AM, Shaopeng Tan wrote:
> In kselftest framework, if a sub test can not run by some reasons,
> the test result should be marked as SKIP rather than FAIL.
> Return KSFT_SKIP(4) instead of KSFT_FAIL(1) if resctrl_tests is not run
> as root or it is run on a test environment which does not support resctrl.
> 
>  - ksft_exit_fail_msg(): returns KSFT_FAIL(1)
>  - ksft_exit_skip(): returns KSFT_SKIP(4)
> 
> Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
> Signed-off-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
> ---
>  tools/testing/selftests/resctrl/resctrl_tests.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c
> index 973f09a66e1e..ed7e1a995b01 100644
> --- a/tools/testing/selftests/resctrl/resctrl_tests.c
> +++ b/tools/testing/selftests/resctrl/resctrl_tests.c
> @@ -205,7 +205,7 @@ int main(int argc, char **argv)
>  	 * 2. We execute perf commands
>  	 */
>  	if (geteuid() != 0)
> -		return ksft_exit_fail_msg("Not running as root, abort testing.\n");
> +		return ksft_exit_skip("Not running as root. Skipping...\n");
>  
>  	/* Detect AMD vendor */
>  	detect_amd();
> @@ -235,7 +235,7 @@ int main(int argc, char **argv)
>  	sprintf(bm_type, "fill_buf");
>  
>  	if (!check_resctrlfs_support())
> -		return ksft_exit_fail_msg("resctrl FS does not exist\n");
> +		return ksft_exit_skip("resctrl FS does not exist. Enable X86_CPU_RESCTRL config options.\n");
>  
>  	filter_dmesg();
>  

Almost.

"config options" -> "config option"

With that fixed you can add:
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette