Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp1404370pxp; Sun, 20 Mar 2022 16:15:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyb3Cn/l3loSz5oadzw36QM4UUsJCWSOkBtyyk1earOPNJnWk9yA9FoiDm6jAsVhiZAUqi+ X-Received: by 2002:a17:90a:bd04:b0:1bf:951d:5bf2 with SMTP id y4-20020a17090abd0400b001bf951d5bf2mr33340200pjr.18.1647818108203; Sun, 20 Mar 2022 16:15:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647818108; cv=none; d=google.com; s=arc-20160816; b=NhcQ9ftT7hHUkbV2M7k/wplH/lsHWoGFGOHY7g1TWGdHEmjIrpU+3VINMfWWrKou08 MR2St15f9NVzv8a8/bmF+wlMIpjMiZlP877bJXeXeNkr/lrySYKEzZOgRJ1YFUiIdll9 xSMeeUesPItVYeNlyiOIaVSPJV/nuGCuhX10T7Gi87TnEooUe8j/HuDGcoj4JOncqVqe wOYuk0kC7zadzAkjA84DVXr1H8NNsOn9B7/6sczDeBvrfborjlujRK59KSDUHV2PUZ3H RVsVsSXRPk6lpJ2en5jrGqWzmD3DovBBkwh1U4TV+RPR/poxEw+Ah/v5RWyONdq+1Yc8 l97A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=YZMUZMRb13gxRVQlDqvdqmbrfa6neN3fcSPMrOn7PzI=; b=e4ILoGArNMf5BVASxm5Wdx9UCDzxY+iE2vZqLId/jNMhpnWEMyZB6I8WIDxkXU+Jz+ ocVmS9hHsuWbpB3bdxKFjMjKvkBtDtC3Bl7MZ3j0oNZTLUOiDr0C72wIqifh3cqTdTd5 Mio45HpjudgyYQ6LoxWxh+skab2bwk+6x/64sj6nNhAMZV1alxUJkNyGPyNgAvZ46SSV hf+mCDkozWoaLXOA9KKBYfkB/PkR9D8jhGLJlTRBnpNP1/qxk5snFxPE+cpDnFUZUezL FQIfnzMEXWnT9D/mnGF+QAlSgqD7WzkMkak6VK7Mvas7mzpr8sJQuwMBhaqYNfyXvpu9 NuOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Bew74swD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l11-20020a056a0016cb00b004fa3a8dff74si7012078pfc.43.2022.03.20.16.14.34; Sun, 20 Mar 2022 16:15:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Bew74swD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242099AbiCSE2b (ORCPT + 99 others); Sat, 19 Mar 2022 00:28:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242084AbiCSE23 (ORCPT ); Sat, 19 Mar 2022 00:28:29 -0400 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3C5D1D253D; Fri, 18 Mar 2022 21:27:08 -0700 (PDT) Received: by mail-pg1-x532.google.com with SMTP id bc27so6407028pgb.4; Fri, 18 Mar 2022 21:27:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=YZMUZMRb13gxRVQlDqvdqmbrfa6neN3fcSPMrOn7PzI=; b=Bew74swDcYqef96ehtkWNmKyQ5lC/TfXk7XTkZOOpfEj/GHCpfvpuCeYMedZ4DI9B9 045sYlK3LZMvy+5vNRi00+1KocmzQfDq33Pp2f+VEejt6HKXYeM6OzhQ97vfbP7TGLy4 tCmTRzqHfjl3mIehaHhNmmoKmVpn1sQudbV5j/xFY1j5/CA07PpAd/VOdcE94UgiQpSG gmh/ZcYi2SL5SCMKhvosXB+/MQAaLXH3VQ7M5iY0Rqsc3fMPXZ18zmZRGlr55mvaS6OV UhJiAzN7RbrDdMMm7T22o6o+LwFkYTnpJp2vVtUrVwmRO/DJ1NxFJo0zQDEC0bticwst R1VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=YZMUZMRb13gxRVQlDqvdqmbrfa6neN3fcSPMrOn7PzI=; b=uE5s36eX77JxXKZLseZ85CInyHx3WrQH6hrVEEqEtIL6GMZ2m5Xmgf70k6AJQOZKEC MBSJRjjcIkqn280r73Qzc4c0M+bpk/XRnv0tkSvi0wh73qU4+iCu7Qw7Zxosy8lcICMI 38NjhI7XUwCWlS3UGj8Q3un0N2HjIcHTbis/Uyx+Arm8KN9kAjjb4xZI0emyc2cp2EW6 hVIhlGbkw/voqbXWR5SReCgL6kHajqDNRQYqvuKKOv2URdIIKEMpnSGX1xpbj5eXAlhi cl8BB7hqQzX50XLZ3y/IJHUFqGsC2bV3kwK3D5VKzrLPl33DV70JOeticagRCrIMljhI 7c5w== X-Gm-Message-State: AOAM531nrQYnnGj13+L7JrbUoZtMa7fiyXv1ylA3gIH+ordVkHKrvyXB 8/EJp8UW+UXEYPKi7O4jr18= X-Received: by 2002:aa7:8104:0:b0:4fa:2091:d200 with SMTP id b4-20020aa78104000000b004fa2091d200mr13462127pfi.17.1647664028128; Fri, 18 Mar 2022 21:27:08 -0700 (PDT) Received: from ubuntu.huawei.com ([119.3.119.18]) by smtp.googlemail.com with ESMTPSA id u37-20020a056a0009a500b004f820de3dcdsm10884887pfg.9.2022.03.18.21.27.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Mar 2022 21:27:07 -0700 (PDT) From: Xiaomeng Tong To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: alim.akhtar@samsung.com, avri.altman@wdc.com, daejun7.park@samsung.com, bvanassche@acm.org, beanhuo@micron.com, keosung.park@samsung.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Xiaomeng Tong Subject: [PATCH] ufs: remove an unneed NULL check on list iterator Date: Sat, 19 Mar 2022 12:26:57 +0800 Message-Id: <20220319042657.21835-1-xiam0nd.tong@gmail.com> X-Mailer: git-send-email 2.17.1 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The list iterator is always non-NULL so it doesn't need to be checked. Thus just remove the unnecessary NULL check. Signed-off-by: Xiaomeng Tong --- drivers/scsi/ufs/ufshpb.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c index 2d36a0715..a3db0ad60 100644 --- a/drivers/scsi/ufs/ufshpb.c +++ b/drivers/scsi/ufs/ufshpb.c @@ -869,12 +869,6 @@ static struct ufshpb_region *ufshpb_victim_lru_info(struct ufshpb_lu *hpb) struct ufshpb_region *rgn, *victim_rgn = NULL; list_for_each_entry(rgn, &lru_info->lh_lru_rgn, list_lru_rgn) { - if (!rgn) { - dev_err(&hpb->sdev_ufs_lu->sdev_dev, - "%s: no region allocated\n", - __func__); - return NULL; - } if (ufshpb_check_srgns_issue_state(hpb, rgn)) continue; -- 2.17.1