Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0fcfca14-1096-c7fb-b174-b4eabbb18b9f@csgroup.eu>
Date:   Fri, 18 Mar 2022 18:07:16 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.2
Subject: Re: [PATCH] macintosh: windfarm: Use NULL to compare with
 pointer-typed value rather than 0
Content-Language: fr-FR
To:     Xu Wang <vulab@iscas.ac.cn>, benh@kernel.crashing.org,
        linuxppc-dev@lists.ozlabs.org
Cc:     linux-kernel@vger.kernel.org
References: <20201113073343.64378-1-vulab@iscas.ac.cn>
From:   Christophe Leroy <christophe.leroy@csgroup.eu>
In-Reply-To: <20201113073343.64378-1-vulab@iscas.ac.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


Le 13/11/2020 à 08:33, Xu Wang a écrit :
> Compare pointer-typed values to NULL rather than 0.
> 
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>

If we are going to change that, let's do it right at once

Checkpatch says:

CHECK: Comparison to NULL could be written "!hdr"
#25: FILE: drivers/macintosh/windfarm_pm121.c:653:
+	if (hdr == NULL) {

CHECK: Comparison to NULL could be written "hdr"
#34: FILE: drivers/macintosh/windfarm_pm121.c:972:
+	if (hdr != NULL) {

total: 0 errors, 0 warnings, 2 checks, 16 lines checked


> ---
>   drivers/macintosh/windfarm_pm121.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/macintosh/windfarm_pm121.c b/drivers/macintosh/windfarm_pm121.c
> index ab467b9c31be..62826844b584 100644
> --- a/drivers/macintosh/windfarm_pm121.c
> +++ b/drivers/macintosh/windfarm_pm121.c
> @@ -650,7 +650,7 @@ static void pm121_create_cpu_fans(void)
>   
>   	/* First, locate the PID params in SMU SBD */
>   	hdr = smu_get_sdb_partition(SMU_SDB_CPUPIDDATA_ID, NULL);
> -	if (hdr == 0) {
> +	if (hdr == NULL) {
>   		printk(KERN_WARNING "pm121: CPU PID fan config not found.\n");
>   		goto fail;
>   	}
> @@ -969,7 +969,7 @@ static int pm121_init_pm(void)
>   	const struct smu_sdbp_header *hdr;
>   
>   	hdr = smu_get_sdb_partition(SMU_SDB_SENSORTREE_ID, NULL);
> -	if (hdr != 0) {
> +	if (hdr != NULL) {
>   		struct smu_sdbp_sensortree *st =
>   			(struct smu_sdbp_sensortree *)&hdr[1];
>   		pm121_mach_model = st->model_id;