Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220319090142.137998-1-zhouzhouyi@gmail.com> <20220319100443.GA13956@breakpoint.cc>
In-Reply-To: <20220319100443.GA13956@breakpoint.cc>
From:   Zhouyi Zhou <zhouzhouyi@gmail.com>
Date:   Sat, 19 Mar 2022 18:34:39 +0800
Message-ID: <CAABZP2z6=4bC7qzDdPVjFB10NFioqtspXGTgw_=62o29=VFa+w@mail.gmail.com>
Subject: Re: [PATCH] net:ipv4: send an ack when seg.ack > snd.nxt
To:     Florian Westphal <fw@strlen.de>
Cc:     Eric Dumazet <edumazet@google.com>,
        David Miller <davem@davemloft.net>, yoshfuji@linux-ipv6.org,
        dsahern@kernel.org, Jakub Kicinski <kuba@kernel.org>,
        pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Wei Xu <xuweihf@ustc.edu.cn>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Dear Florian

Thank you for reviewing my patch ;-)

On Sat, Mar 19, 2022 at 6:04 PM Florian Westphal <fw@strlen.de> wrote:
>
> zhouzhouyi@gmail.com <zhouzhouyi@gmail.com> wrote:
> > -     if (after(ack, tp->snd_nxt))
> > +     if (after(ack, tp->snd_nxt)) {
> > +             tcp_send_ack(sk);
> >               return -1;
> > +     }
>
> If we really need to do this we need to
>   if (!(flag & FLAG_NO_CHALLENGE_ACK))
Yes, we need to check FLAG_NO_CHALLENGE_ACK here to avoid two acks.
>         tcp_send_challenge_ack(sk);
>
> ... else this might result in two acks?
> Whats the problem thats being fixed here?
We fix the code to let it match what RFC 793 page 72 has described. I
guess this is also what the intermediate internet devices (routers,
firewalls for example) expect us to do ;-)

Thanks again
Zhouyi