Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH 1/2] iio:filter:admv8818: Add depends on REGMAP
To:     "Sa, Nuno" <Nuno.Sa@analog.com>
CC:     "cj.chengjian@huawei.com" <cj.chengjian@huawei.com>,
        "liwei391@huawei.com" <liwei391@huawei.com>,
        "Miclaus, Antoniu" <Antoniu.Miclaus@analog.com>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "jic23@kernel.org" <jic23@kernel.org>,
        "Jonathan.Cameron@huawei.com" <Jonathan.Cameron@huawei.com>
References: <20220318025914.2614812-1-bobo.shaobowang@huawei.com>
 <20220318025914.2614812-2-bobo.shaobowang@huawei.com>
 <PH0PR03MB678617206D33B41868D565B499139@PH0PR03MB6786.namprd03.prod.outlook.com>
From:   "Wangshaobo (bobo)" <bobo.shaobowang@huawei.com>
Message-ID: <2781b5e5-ad45-cd90-4bbb-813672098807@huawei.com>
Date:   Sun, 20 Mar 2022 13:32:52 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.0
MIME-Version: 1.0
In-Reply-To: <PH0PR03MB678617206D33B41868D565B499139@PH0PR03MB6786.namprd03.prod.outlook.com>
Content-Type: text/plain; charset="gbk"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


?? 2022/3/18 16:45, Sa, Nuno д??:
> Hi Wang,
>
> Thanks for the patch
>
>> -----Original Message-----
>> From: Wang ShaoBo <bobo.shaobowang@huawei.com>
>> Sent: Friday, March 18, 2022 3:59 AM
>> Cc: cj.chengjian@huawei.com; liwei391@huawei.com;
>> bobo.shaobowang@huawei.com; Miclaus, Antoniu
>> <Antoniu.Miclaus@analog.com>; linux-iio@vger.kernel.org; linux-
>> kernel@vger.kernel.org; jic23@kernel.org;
>> Jonathan.Cameron@huawei.com
>> Subject: [PATCH 1/2] iio:filter:admv8818: Add depends on REGMAP
>>
>> [External]
>>
>> Add "depends on REGMAP" to CONFIG_ADMV8818, because
>> admv8818 driver
>> uses structure/symbols such as 'struct regmap_config' which are
>> defined
>> only when CONFIG_REGMAP is set.
>>
>> Fixes: f34fe888ad05 ("iio:filter:admv8818: add support for ADMV8818")
>> Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
>> ---
>>   drivers/iio/filter/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/filter/Kconfig b/drivers/iio/filter/Kconfig
>> index 3ae35817ad82..4bbf10f8692c 100644
>> --- a/drivers/iio/filter/Kconfig
>> +++ b/drivers/iio/filter/Kconfig
>> @@ -7,7 +7,7 @@ menu "Filters"
>>
>>   config ADMV8818
>>   	tristate "Analog Devices ADMV8818 High-Pass and Low-Pass
>> Filter"
>> -	depends on SPI && COMMON_CLK && 64BIT
>> +	depends on REGMAP && SPI && COMMON_CLK && 64BIT
> I think the best way is to have select REGMAP_SPI. Hence:
>
>      depends on SPI && COMMON_CLK && 64BIT
>      select REGMAP_SPI
>
> This will automatically default CONFIG_REGMAP to y. with your
> patch, I guess we can still have issues with ' __devm_regmap_init_spi()'
>
> - Nuno S??
> .

Yes, only set REGMAP but REGMAP_SPI may causing __devm_regmap_init_spi 
undeined.

-- wangshaobo