Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 21 Mar 2022 09:40:04 +0000
Message-ID: <87ils7y77v.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     dann frazier <dann.frazier@canonical.com>
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, robh@kernel.org,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-team@android.com, Toan Le <toan@os.amperecomputing.com>,
        Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= <kw@linux.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        =?UTF-8?B?U3TDqXBoYW5l?= Graber <stgraber@ubuntu.com>,
        Thorsten Leemhuis <regressions@leemhuis.info>
Subject: Re: [PATCH] PCI: xgene: Revert "PCI: xgene: Use inbound resources for setup"
In-Reply-To: <YjN8pT5e6/8cRohQ@xps13.dannf>
References: <20220314144429.1947610-1-maz@kernel.org>
        <YjL8P0zkle2foxbk@lpieralisi>
        <YjN8pT5e6/8cRohQ@xps13.dannf>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, 17 Mar 2022 18:23:33 +0000,
dann frazier <dann.frazier@canonical.com> wrote:
>=20
> On Thu, Mar 17, 2022 at 09:15:43AM +0000, Lorenzo Pieralisi wrote:
> > [removed CC stable]
> >=20
> > On Mon, Mar 14, 2022 at 02:44:29PM +0000, Marc Zyngier wrote:
> > > Commit 6dce5aa59e0b ("PCI: xgene: Use inbound resources for setup")
> > > killed PCIe on my XGene-1 box (a Mustang board). The machine itself
> > > is still alive, but half of its storage (over NVMe) is gone, and the
> > > NVMe driver just times out.
> > >=20
> > > Note that this machine boots with a device tree provided by the
> > > UEFI firmware (2016 vintage), which could well be non conformant
> > > with the spec, hence the breakage.
> > >=20
> > > With the patch reverted, the box boots 5.17-rc8 with flying colors.
> > >=20
> > > Signed-off-by: Marc Zyngier <maz@kernel.org>
> > > Cc: Rob Herring <robh@kernel.org>
> > > Cc: Toan Le <toan@os.amperecomputing.com>
> > > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> > > Cc: Krzysztof Wilczy=C5=84ski <kw@linux.com>
> > > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > > Cc: St=C3=A9phane Graber <stgraber@ubuntu.com>
> > > Cc: dann frazier <dann.frazier@canonical.com>
> > > Cc: Thorsten Leemhuis <regressions@leemhuis.info>
> > > Cc: stable@vger.kernel.org>
> > > ---
> > >  drivers/pci/controller/pci-xgene.c | 33 ++++++++++++++++++++--------=
--
> > >  1 file changed, 22 insertions(+), 11 deletions(-)
> >=20
> > Dann, Rob,
> >=20
> > does this fix the regression debated here:
> >=20
> > https://lore.kernel.org/all/Yf2wTLjmcRj+AbDv@xps13.dannf
> >=20
> > It is unclear in that thread what the conclusion reached was.
>=20
> Thanks for checking in Lorenzo! Reverting that patch is required but
> not sufficient to get our m400s working. In addition, we'd also need
> to revert commit c7a75d07827a ("PCI: xgene: Fix IB window setup").
>=20
> I believe if we revert both then it should return us to a state where
> Marc's Mustang, St=C3=A9phane's Merlins and our m400s all work again.

Right. I'll post a series reverting both patches, which hopefully
Lorenzo and Bjorn can merge shortly.

Thanks,

	M.

--=20
Without deviation from the norm, progress is not possible.