Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 19 Mar 2022 16:10:38 +0000
From:   Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To:     Haowen Bai <baihaowen@meizu.com>
Cc:     herbert@gondor.apana.org.au, davem@davemloft.net,
        marco.chiappero@intel.com, fiona.trahe@intel.com,
        wojciech.ziemba@intel.com, qat-linux@intel.com,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: qat: Fix unsigned comparison with less than zero
Message-ID: <YjYAfqkhjeDD+glJ@silpixa00400314>
References: <1647569459-18376-1-git-send-email-baihaowen@meizu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1647569459-18376-1-git-send-email-baihaowen@meizu.com>
Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 -
 Collinstown Industrial Park, Leixlip, County Kildare - Ireland
Precedence: bulk

On Fri, Mar 18, 2022 at 10:10:59AM +0800, Haowen Bai wrote:
> drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c:67:5-8: WARNING: Unsigned expression compared with zero: ret < 0
> 
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
>  drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c b/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c
> index 6d10edc..0143835 100644
> --- a/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c
> +++ b/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c
> @@ -52,7 +52,7 @@ static const char *const dev_cfg_services[] = {
>  static int get_service_enabled(struct adf_accel_dev *accel_dev)
>  {
>  	char services[ADF_CFG_MAX_VAL_LEN_IN_BYTES] = {0};
> -	u32 ret;
> +	s32 ret;
>  
>  	ret = adf_cfg_get_param_value(accel_dev, ADF_GENERAL_SEC,
>  				      ADF_SERVICES_ENABLED, services);
A fix for this is already in the cryptodev tree:
    844318dfd31f ("crypto: qat - fix a signedness bug in get_service_enabled()")

Thanks,

-- 
Giovanni