Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 21 Mar 2022 12:21:32 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Jakob Koschel <jakobkoschel@gmail.com>
Cc:     Vaibhav Agarwal <vaibhav.sr@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
        Mark Greer <mgreer@animalcreek.com>,
        Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mike Rapport <rppt@kernel.org>,
        Brian Johannesmeyer <bjohannesmeyer@gmail.com>,
        Cristiano Giuffrida <c.giuffrida@vu.nl>,
        "Bos, H.J." <h.j.bos@vu.nl>
Subject: Re: [PATCH] staging: greybus: codecs: fix type confusion with
 dedicated list iterator variable
Message-ID: <20220321092132.GI3293@kadam>
References: <20220319202058.2518847-1-jakobkoschel@gmail.com>
 <20220321084844.GG3293@kadam>
 <23587784-B0EB-4FDD-B5BC-DC1B16404DA7@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <23587784-B0EB-4FDD-B5BC-DC1B16404DA7@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QQsXxHbhQEmNfscPYqHCi+ScKbH0pSX5GTnNiGLWF4BoYRF1z8g5g5yDjn95?=
 =?us-ascii?Q?U4iA0VabKEYxqyvUtkzOvxdUbG2jfx7rvCVX3MlEYp7PoOgRauxX5K5DmRE5?=
 =?us-ascii?Q?PzZKHMHUjSUw/AoqvM+ok5y/SoCUEi4MBu6BKeG94+KgqHp8lnWVN5EW8ePQ?=
 =?us-ascii?Q?p+D05XhFf/IEM0u8obnIa0EeJcqLlVXK4Ctezjo6Acr3hkn+59QG2t43bnEF?=
 =?us-ascii?Q?M+IdPzk8PruAe2DQ761QbuDhjHOAemuX+jhymzAKiOvFUy9CKwjfBL/LGo1L?=
 =?us-ascii?Q?eALpMfvwksO4opelhwBDy0HRwujOnEqMlm0ZCd7bhjmF2tjuD1+5lQkXvy9e?=
 =?us-ascii?Q?pU6mJTF5rlG3qn5EU4nEM/BcsByOrgJoxKSEt9Lh1wXI0tc4wS1t+277N7Th?=
 =?us-ascii?Q?FrT+i190YKp4fumEJ0C62jm318PbdAy5X4WKD4+WrMROB4U4x7s72geKz0fg?=
 =?us-ascii?Q?rFz1FavuHPB7y4+4IiZ3KBCzBwxcgqRpEf8A7rq2q7Kd9exvFca28v2JDR3T?=
 =?us-ascii?Q?Dnp/NgbGz+yR7PYjrG+s7DHzVv+5ILL6AMkQ//UExNtnYfWgA+zD1M5Ak2sm?=
 =?us-ascii?Q?GQmMwurP1id4qg8n8Ti9hPEE7cvwqnaCHUnazY7ad1QzDiVCa7DqUB62zrKF?=
 =?us-ascii?Q?jvO+rF/CB9L/5RC5A2XH/fGteKUlR7wEeU8sIzNeQd7e4OnZK0JCl0Fc+DVY?=
 =?us-ascii?Q?cO/puZQuYxlGA9LRtr6oyvXaC9IxMP07PJSuGELX9JrVCoe//BuirN5epE8I?=
 =?us-ascii?Q?SUFjjo+sw57n2a8DhitlDyEOJMzQPURdU0vitly8pQmKDSd5F7D96y8quXrX?=
 =?us-ascii?Q?pTjUKO5zUrFArEsQm3LDEtMZ5XvAG9vqMtibyIYzfTyW6zo+SBzR61jwZLln?=
 =?us-ascii?Q?OylxkxdaUnduoeVcYjAZqZZChTEAKWZsLGnzO9H8UC/59ouz9Dl7BXuPFv3C?=
 =?us-ascii?Q?gIH++DZJ6Wf/fVPzTGWv2IadR/hQoX73Ori/3cNjeEBg0hDhw+I/fZH08EDS?=
 =?us-ascii?Q?YZeL8VYdu0aSFBArqDkIFQ+yxvsTYGVdsGLIwPPzHTQYV9kkQXIUIxDE9bC5?=
 =?us-ascii?Q?/Q25zfC8yv/5xLbVotPbRd6Hs92S2Gu1zalZkGJGJhBWPrPtTIpKkQr/48eI?=
 =?us-ascii?Q?2tQZ1z35jQfoRD4IQL9+DBqmo1ATAg1NbDm51yD1qRnDsuRI+pqC9r0FztuE?=
 =?us-ascii?Q?/SlzZ1ECb+K5eSu3PNv0oZ2nBZjXfgs/fiHgA6jXC9Ylsk+F+PoShCAtbK63?=
 =?us-ascii?Q?1i88E661zj0x0Cgg/526bFeuxZEAvKW34qWDlyNQEUhEPEgQ/koyXQUQOIdW?=
 =?us-ascii?Q?vIcOxkyKMJV8id4urpenFURqWUwBxO//If30tajGhbMFm6OPDJZ2hjg3bS3e?=
 =?us-ascii?Q?jY6rHdxo4adzwQhanJbj63iKae2pfy4ILn2Zskbd8bVaQin/upF0ho6OSQHp?=
 =?us-ascii?Q?YHl3KAycpyPBc1bVRbNFAEscUArihZD5M/jgsA/Q+cotW08SVi72aA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e0ec66d-d6c5-4f10-00b2-08da0b1c37bd
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2022 09:21:44.9719
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qLFgX7A8qqnot908npxWk2vmlbr0RrUuGNTFdsiQCD0AFwIiGwEeIaJqd5+J4yjYHpdD4NBhSBnffYfKyuwoYqI38FdFnnElVNT9vHw6m9c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR10MB3460
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10292 signatures=694221
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxscore=0
 bulkscore=0 phishscore=0 spamscore=0 mlxlogscore=999 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2203210061
X-Proofpoint-ORIG-GUID: jMRheSVjpF8uMbfgVvFtmojJMMUrg9js
X-Proofpoint-GUID: jMRheSVjpF8uMbfgVvFtmojJMMUrg9js
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 21, 2022 at 10:06:13AM +0100, Jakob Koschel wrote:
> 
> > On 21. Mar 2022, at 09:48, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > 
> > The subject says that it fixes a bug but it does not.
> 
> Thank you for your review!
> 
> I don't agree that this doesn't fix a bug:
> 
> > +		}
> > 	}
> > 	if (!data) {
> > -		dev_err(dai->dev, "%s:%s DATA connection missing\n",
> > -			dai->name, module->name);
> 
> Using 'module' when data == NULL is *guaranteed* to be a type confused
> bogus pointer. It fundamentally can never be correct.

Ah.  I did not read all the way to the end of the patch.

The bugfix needs to be sent as it's own patch.  Just the one liner.  It
needs a fixes tag as well.

[PATCH] staging: greybus: fix Oops in error message

The "module" pointer is invalid here.  It's the list iterator and we
exited the loop without finding a valid entry.

Fixes: 6dd67645f22c ("greybus: audio: Use single codec driver registration")
Signed-off-by: You

 	if (!data) {
-		dev_err(dai->dev, "%s:%s DATA connection missing\n",
-			dai->name, module->name);
+		dev_err(dai->dev, "%s DATA connection missing\n",
+			dai->name);
 		mutex_unlock(&codec->lock);

We're happy to apply the other stuff as well, but we don't mix cleanups
and bug fixes like that.

regards,
dan carpenter