Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8a5fdf42-d457-7f47-b66a-8447fb297be0@kernel.org>
Date:   Sat, 19 Mar 2022 15:55:18 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2] dmaengine: qcom_hidma: Remove useless DMA-32 fallback
 configuration
Content-Language: en-US
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Vinod Koul <vkoul@kernel.org>
Cc:     linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org
References: <4deb32b0c7838da66608022c584326eb01d0da03.1642232106.git.christophe.jaillet@wanadoo.fr>
 <ee43d68f-000c-6513-38f2-877b9018ab22@kernel.org>
 <08b7604d-f528-ecb7-a8b2-7c9c36518143@wanadoo.fr>
From:   Sinan Kaya <okaya@kernel.org>
In-Reply-To: <08b7604d-f528-ecb7-a8b2-7c9c36518143@wanadoo.fr>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 3/19/2022 2:24 AM, Christophe JAILLET wrote:
> Le 22/01/2022 à 19:05, Sinan Kaya a écrit :
>> On 1/15/2022 2:35 AM, Christophe JAILLET wrote:
>>> As stated in [1], dma_set_mask() with a 64-bit mask never fails if
>>> dev->dma_mask is non-NULL.
>>> So, if it fails, the 32 bits case will also fail for the same reason.
>>>
>>> Simplify code and remove some dead code accordingly.
>>>
>>> [1]: 
>>> https://lore.kernel.org/linux-kernel/YL3vSPK5DXTNvgdx@infradead.org/#t
>>>
>>
>> Can we please document this?
> 
> Hi, the patch has been applied, but [1] is sometimes given as an 
> explanation link.
> 
> CJ
> 
> 
> [1]: 
> https://lists.linuxfoundation.org/pipermail/iommu/2019-February/033674.html

Sounds good, please carry my

Acked-By: Sinan Kaya <okaya@kernel.org>