Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp1894726pxp; Mon, 21 Mar 2022 07:12:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy6aJiKI+yx0Mbo7kF4Czek2cwdjVkwS6+NMDSC65kXeF0g+ZFiA7RdcwwQ6S27MOcBCNmk X-Received: by 2002:a17:90b:1bc9:b0:1c7:228a:95ce with SMTP id oa9-20020a17090b1bc900b001c7228a95cemr4609463pjb.3.1647871970848; Mon, 21 Mar 2022 07:12:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647871970; cv=none; d=google.com; s=arc-20160816; b=bnDlNBlZoHy/j7EmlRsB4mnGQnc47oBcIj2N2h/EbaOi8iR18eahv2Oosiy0hqKS/+ 2hrK/VYIVfNc8AmX5OSySbQ2TvcbI6qrNH/sg14JcpjkJxl8XNqdprHa6QNGpfg4dDc9 8mGvH2XM2Jj/iFkQqqVqeIs9bi1sEvOmPA9y412qPmtPKbnxMkkm12f5yZiIRiyvu8FG DXO/OTFPpBFQocf4QX5/OERUBrC0UsvNl1IoM6MyZDd/Aov5h87v6SQt25eFThgDKEjA 7PK4rV4N/ilx1ZsNeqJQrLd9E0GajaHW/qRGKxYuVke9J6Yr+Ndh6vC9UyBwC07pMKzC 3Bfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=Wohgj1k+iPo/OG15eMtdqemqDsjWYgkXISOxUJl2ybQ=; b=Q29+slVhYhvF/OBxXE9ka4pMRDTURx8NfpD1JcrjOvVyoVmfiGNZUDuyc61oG5GDph qd2ifcFVGNv/I9L+DBEO8wgsJhJdIMqWs1npGab9b9RI/clpBGR1/T7sFJ9s0b3QP2u4 BJOmewbL1NN/PNtfa9FQ2lGljCpoikK7XFHib/GiBa+becS5axdSlo67rWGnfhe86Edr SdWStdJBfUXWisQ8Vac0YVMd9JYzXtx3BSnRZ4pHztIL1nQ+QwG6L+/5W4GvBN/CtOpZ 3FLn0vnpALoJgcTJfR96ov/JoSMNOjE7orvKFUoOzR5c+jUcNdsOAIGoK56oVycdP1ZM TGTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YOZTtRqB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a12-20020a17090a8c0c00b001bd14e01fc0si18536358pjo.174.2022.03.21.07.12.35; Mon, 21 Mar 2022 07:12:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YOZTtRqB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243955AbiCSTB4 (ORCPT + 99 others); Sat, 19 Mar 2022 15:01:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243950AbiCSTBz (ORCPT ); Sat, 19 Mar 2022 15:01:55 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71D8452E66; Sat, 19 Mar 2022 12:00:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1EA48B80DB0; Sat, 19 Mar 2022 19:00:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1F87C340F0; Sat, 19 Mar 2022 19:00:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647716430; bh=Wohgj1k+iPo/OG15eMtdqemqDsjWYgkXISOxUJl2ybQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YOZTtRqBg7wEYpBXOPT8Lpiv6nNLzBRH2bQhtpqI9y4Za3T9ADhfhFGJIWOLRNSCq B25VkmhYkDoMBIIUYIl7iByK9Yv14TRoTnzeflm3cqLy9rzXN/lleasvqMue65RQCi yuuP5zFi04ghA9QMTFJZAJAbEMqQ5Sb9q8I3wsGZwZh0/B6TGOWis+g89b3FeqbOHA +9qLUAkBO0k/2bsYdS8gj/tazSXDi1SoWZkMnfPggT2b1ERsjCvByxRZSbKfxlGIfE Yl9bw8AcF3ZcTYpvDmC2d8fZHA/oJRqyR9n15QgsUJV9vdE1XxpoILf4bvBv1tYPx5 yCZzTjYqQHiag== Date: Sat, 19 Mar 2022 20:00:25 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Tobias Waldekranz Cc: davem@davemloft.net, kuba@kernel.org, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 2/2] net: dsa: mv88e6xxx: Ensure STU support in VLAN MSTI callback Message-ID: <20220319200025.5833b2ba@thinkpad> In-Reply-To: <20220318201321.4010543-3-tobias@waldekranz.com> References: <20220318201321.4010543-1-tobias@waldekranz.com> <20220318201321.4010543-3-tobias@waldekranz.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 Mar 2022 21:13:21 +0100 Tobias Waldekranz wrote: > In the same way that we check for STU support in the MST state > callback, we should also verify it before trying to change a VLANs > MSTI membership. >=20 > Fixes: acaf4d2e36b3 ("net: dsa: mv88e6xxx: MST Offloading") > Signed-off-by: Tobias Waldekranz Tested-by: Marek Beh=C3=BAn