Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 20 Mar 2022 14:17:08 +0000
From:   Boris Petkov <bp@alien8.de>
To:     Paolo Bonzini <pbonzini@redhat.com>
CC:     Peter Zijlstra <peterz@infradead.org>,
        Jamie Heilman <jamie@audible.transient.net>,
        linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Sean Christopherson <seanjc@google.com>, x86@kernel.org,
        kvm@vger.kernel.org
Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_-v1=2E2=5D_kvm/emulate=3A_Fix_SET?= =?US-ASCII?Q?cc_emulation_function_offsets_with_SLS?=
User-Agent: K-9 Mail for Android
In-Reply-To: <6970ccc4-1c42-23fa-0b31-99b102ed76c8@redhat.com>
References: <YjI69aUseN/IuzTj@zn.tnic> <YjJFb02Fc0jeoIW4@audible.transient.net> <YjJVWYzHQDbI6nZM@zn.tnic> <20220316220201.GM8939@worktop.programming.kicks-ass.net> <YjMBdMlhVMGLG5ws@zn.tnic> <YjMS8eTOhXBOPFOe@zn.tnic> <YjMVpfe/9ldmWX8W@hirez.programming.kicks-ass.net> <94df38ce-6bd7-a993-7d9f-0a1418a1c8df@redhat.com> <YjXcRsR2T8WGnVjl@zn.tnic> <ad13632c-127d-ff5a-6530-5282e58521b1@redhat.com> <YjXfgsSZpVVdg0lv@zn.tnic> <6970ccc4-1c42-23fa-0b31-99b102ed76c8@redhat.com>
Message-ID: <8618FFB5-4029-4C8C-9982-B431F967D468@alien8.de>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On March 20, 2022 2:04:02 PM UTC, Paolo Bonzini <pbonzini@redhat=2Ecom> wro=
te:
>So this is what I squashed in:
>
>diff --git a/arch/x86/kvm/emulate=2Ec b/arch/x86/kvm/emulate=2Ec
>index f321abb9a4a8=2E=2Ee86d610dc6b7 100644
>--- a/arch/x86/kvm/emulate=2Ec
>+++ b/arch/x86/kvm/emulate=2Ec
>@@ -430,7 +430,19 @@ static int fastop(struct x86_emulate_ctxt *ctxt, fas=
top_t fop);
> =20
>  /* Special case for SETcc - 1 instruction per cc */
> =20
>-#define SETCC_ALIGN	(4 * (1 + IS_ENABLED(CONFIG_SLS)))
>+/*
>+ * Depending on =2Econfig the SETcc functions look like:
>+ *
>+ * SETcc %al   [3 bytes]
>+ * RET         [1 byte]
>+ * INT3        [1 byte; CONFIG_SLS]
>+ *
>+ * Which gives possible sizes 4 or 5=2E  When rounded up to the
>+ * next power-of-two alignment they become 4 or 8=2E
>+ */
>+#define SETCC_LENGTH	(4 + IS_ENABLED(CONFIG_SLS))
>+#define SETCC_ALIGN	(4 << IS_ENABLED(CONFIG_SLS))
>+static_assert(SETCC_LENGTH <=3D SETCC_ALIGN);
> =20
>  #define FOP_SETCC(op) \
>  	"=2Ealign " __stringify(SETCC_ALIGN) " \n\t" \
>
>Paolo


Ack=2E

Thanks=2E

--=20
Sent from a small device: formatting sux and brevity is inevitable=2E