Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8822dfa2-bdb8-fceb-e920-94afb50881e8@intel.com>
Date:   Fri, 18 Mar 2022 13:19:26 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] ice: use min() to make code cleaner in ice_gnss
Content-Language: en-US
To:     Wan Jiabing <wanjiabing@vivo.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Jakub Kicinski" <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20220318094629.526321-1-wanjiabing@vivo.com>
From:   Tony Nguyen <anthony.l.nguyen@intel.com>
In-Reply-To: <20220318094629.526321-1-wanjiabing@vivo.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NStrdlZWZytPV254VjZtOURiWVpGdlRqekwrWVpVZVFDbGZvM2RBNUNCVEVO?=
 =?utf-8?B?amJRdWtPOU82UEc4Tzh3U1VXNkcrWGJzT1RxS0p0TXU2NzNmUHNCc3Fab1lY?=
 =?utf-8?B?a2VrQUJKRWhsTUZzRENyTFJnYmYrbTVaSGVISVFGamg1Sll0OXVLaFB4NFRE?=
 =?utf-8?B?Q2wwb205WUo0ZEhMazVOOFZuN0t5b3lNM2t1NGoySDQ2dk9GYXNMS0UzNk5Q?=
 =?utf-8?B?K05CL2JDSnNEbkN3MVVPNjJ0WnpKeG0ycDUxWFNPVlZEUEZuZFhsY2JXUFNk?=
 =?utf-8?B?UytZNW9ockRBNUlYbUx5N3RnWTZwWStJemtUbEwxQTFhdXdmT0ZaazdVNVdz?=
 =?utf-8?B?a09xTElQZXl3V3NBR29iSTk1VDFWb1o5Y3F3MHNtdGpIT1pDNWhmM2p4b0FX?=
 =?utf-8?B?TzBMNVg3cmpKaUswZE43eDRyTDZQT29TdUs2cWJneE9IZmFIUm5ONHRqRFhH?=
 =?utf-8?B?TUhuK291ZWI3eGdiK1BvcXNJRVRzVVd4cytSWHdaT3VpODZiUDgzQURUR2xX?=
 =?utf-8?B?QmUvS0MvUmRaVnRZd1lJL3M0R1hPbjZOT0lXRXVwekZXNWc0b2Q5eWRUUkVx?=
 =?utf-8?B?SitWVDZxYlBJWGhzWC9oN2grUjJoWmNJbVJsM0NoZG9mVDVyQTVVaFhJWXNV?=
 =?utf-8?B?S211a3Q2K0pPNjlRRkl2WG93UmZpc2UyOHNiZFNuTjR2ZDY3TTk1YnYrS2ty?=
 =?utf-8?B?MnVYUnYySTUyOWNRU3Fnc3FHWGVYZmdxOE1vMkYxTi9IZExtSVdQaGdLUHFO?=
 =?utf-8?B?NU9rRElSWW1zWEdkeUdnU2xiZ2ZOSjQxUVN2M0dsWUllK2NMRWFJZm9DcTdw?=
 =?utf-8?B?WTV2eVljWjBEeWg5czJ1bG5VWXVSeVI4MmxGYlAyVzZaNmowQy81Q09aOE9K?=
 =?utf-8?B?cDV5c2ppVWRJcGxwZ0pyWUJLSGdYc1haV2ljNUI3b3djeE9ENUJ1U0daTVpx?=
 =?utf-8?B?ekxNcU1NdmYrUitEaXVIdGlmUDltOTVWVmgzaEI2Z081RjJkQ2htanJ2c1M5?=
 =?utf-8?B?T0MzdjBGMUh3eVZ3cUxWaStueUlnKy9yN0pZOEJ3Q0FIajBnc3UyZllsV2Qx?=
 =?utf-8?B?WUw2SEtDamxjMTBmak9xUHZxWUxQQzBjbTdCSWpWRUhpZzVvZTg3VFcxbzVl?=
 =?utf-8?B?S2hPdk5mZDkzc0wzWXk3VmtURm54QmorVFhxd2lmckFGbk1RL1ozemxiQmNL?=
 =?utf-8?B?Nm1XdjI4WUJTeTExc29tVzIwQVFSRGVIL01vaG9Qdm5hZ1NwcW5IZXlLZUI5?=
 =?utf-8?B?QVVqSDE0aENkNThIVkFjY1FqY2Y2YUJxclBwZmkyYnc1cUVOdGpQUUh6K1BK?=
 =?utf-8?B?M3J1QmVlTklrY3BxSExQNDNaY3M2M0Y5cnc2dEkyNEUxWVRRZEJYZDByKzh5?=
 =?utf-8?B?bUFub3dJNjUwZFI1TEtlclpUK0U3VVBRWEtaUWQ4cDVTNURlRTBvZ2dOSEFj?=
 =?utf-8?B?TXVkK1N5VDM3NHJlWEhyZ1haWE1aUWZmUHBweFJ1U2lXcG9VV0VmSFhGaEpk?=
 =?utf-8?B?dU5IYWN2SzJTaFQ5emFlZ2VLeGo1WFdVNjJTdHBjU21LMUpWVTJxYWxYVklH?=
 =?utf-8?B?SlRDQkN4SGpsejlUalhGaTdoZ0MybkIyZGJEb1UzSEZjNTgxMTl4MXNTaVk0?=
 =?utf-8?B?cUtQRWlsNjJJQnBJVUVMV0drWkxBRFVzcTdIa0JqeUtSNFFKQjVCaGxHMmFP?=
 =?utf-8?B?YlhSUjRpcXhDVHl4bzQ1dUVXNzB0RkVLZnB5aDhRNUNYTmptSGtEcWxyM1NV?=
 =?utf-8?B?d2JLUWJBR0l6cTVXR1pPRlpaSjQ3Rlc5Q2pwd1p0UjlGOWtLSGU0N2h0U1hK?=
 =?utf-8?B?bGJ6Mk1SeTRJdkJJU2xOMFFGaDBDa3Z4eXNicXE2MUtKcnl2aDFYYUJBeEFM?=
 =?utf-8?B?OCtRekNXZTFETGUvN3QxejdzYURNbDh6TVpseHg0NGlNcnpGWmdUcnhiZGRI?=
 =?utf-8?B?U0lKV0h5cmthRlpMdEVjTkNPQVBMa2tXUXFsRWltU3k3ekRDQlZHL0NOM0pz?=
 =?utf-8?B?VnRkeG5WeWRBPT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b29b8c40-7de5-4e7b-7fb6-08da091c9b78
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3229.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2022 20:19:30.0946
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: krk32ua7J8Ckk0Hz4RDB1TrAlGkP5YhBNPyDh+r+Mtq7yGuWIWMmqoVoFCI+03dPsGL8z/PJhv27anVJ80INeMKaB147GeJ59s1y/XkQV+U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4767
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/18/2022 2:46 AM, Wan Jiabing wrote:
> Fix the following coccicheck warning:
> ./drivers/net/ethernet/intel/ice/ice_gnss.c:79:26-27: WARNING opportunity for min()
>
> Use min() to make code cleaner.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>

There are build issues with this patch:

In file included from ./include/linux/kernel.h:26,
                  from drivers/net/ethernet/intel/ice/ice.h:9,
                  from drivers/net/ethernet/intel/ice/ice_gnss.c:4:
drivers/net/ethernet/intel/ice/ice_gnss.c: In function ‘ice_gnss_read’:
./include/linux/minmax.h:20:35: error: comparison of distinct pointer 
types lacks a cast [-Werror]
    20 |         (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
       |                                   ^~
./include/linux/minmax.h:26:18: note: in expansion of macro ‘__typecheck’
    26 |                 (__typecheck(x, y) && __no_side_effects(x, y))
       |                  ^~~~~~~~~~~
./include/linux/minmax.h:36:31: note: in expansion of macro ‘__safe_cmp’
    36 |         __builtin_choose_expr(__safe_cmp(x, y), \
       |                               ^~~~~~~~~~
./include/linux/minmax.h:45:25: note: in expansion of macro ‘__careful_cmp’
    45 | #define min(x, y)       __careful_cmp(x, y, <)
       |                         ^~~~~~~~~~~~~
drivers/net/ethernet/intel/ice/ice_gnss.c:79:30: note: in expansion of 
macro ‘min’
    79 |                 bytes_read = min(bytes_left, 
ICE_MAX_I2C_DATA_SIZE);
       |                              ^~~
cc1: all warnings being treated as errors