Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.60.0.1.1\))
Subject: Re: [PATCH] staging: greybus: codecs: fix type confusion with
 dedicated list iterator variable
From:   Jakob Koschel <jakobkoschel@gmail.com>
In-Reply-To: <20220321092132.GI3293@kadam>
Date:   Mon, 21 Mar 2022 10:27:10 +0100
Cc:     Vaibhav Agarwal <vaibhav.sr@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
        Mark Greer <mgreer@animalcreek.com>,
        Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mike Rapport <rppt@kernel.org>,
        Brian Johannesmeyer <bjohannesmeyer@gmail.com>,
        Cristiano Giuffrida <c.giuffrida@vu.nl>,
        "Bos, H.J." <h.j.bos@vu.nl>
Content-Transfer-Encoding: quoted-printable
Message-Id: <56102C8D-DBFF-43A5-9641-04577F01AB6D@gmail.com>
References: <20220319202058.2518847-1-jakobkoschel@gmail.com>
 <20220321084844.GG3293@kadam>
 <23587784-B0EB-4FDD-B5BC-DC1B16404DA7@gmail.com>
 <20220321092132.GI3293@kadam>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Precedence: bulk


> On 21. Mar 2022, at 10:21, Dan Carpenter <dan.carpenter@oracle.com> =
wrote:
>=20
> On Mon, Mar 21, 2022 at 10:06:13AM +0100, Jakob Koschel wrote:
>>=20
>>> On 21. Mar 2022, at 09:48, Dan Carpenter <dan.carpenter@oracle.com> =
wrote:
>>>=20
>>> The subject says that it fixes a bug but it does not.
>>=20
>> Thank you for your review!
>>=20
>> I don't agree that this doesn't fix a bug:
>>=20
>>> +		}
>>> 	}
>>> 	if (!data) {
>>> -		dev_err(dai->dev, "%s:%s DATA connection missing\n",
>>> -			dai->name, module->name);
>>=20
>> Using 'module' when data =3D=3D NULL is *guaranteed* to be a type =
confused
>> bogus pointer. It fundamentally can never be correct.
>=20
> Ah.  I did not read all the way to the end of the patch.
>=20
> The bugfix needs to be sent as it's own patch.  Just the one liner.  =
It
> needs a fixes tag as well.
>=20
> [PATCH] staging: greybus: fix Oops in error message
>=20
> The "module" pointer is invalid here.  It's the list iterator and we
> exited the loop without finding a valid entry.
>=20
> Fixes: 6dd67645f22c ("greybus: audio: Use single codec driver =
registration")
> Signed-off-by: You
>=20
> 	if (!data) {
> -		dev_err(dai->dev, "%s:%s DATA connection missing\n",
> -			dai->name, module->name);
> +		dev_err(dai->dev, "%s DATA connection missing\n",
> +			dai->name);
> 		mutex_unlock(&codec->lock);
>=20
> We're happy to apply the other stuff as well, but we don't mix =
cleanups
> and bug fixes like that.

ok great, I'll separate and resubmit both. Thanks!

>=20
> regards,
> dan carpenter

	Jakob