Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp2107868pxp; Mon, 21 Mar 2022 11:27:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzO4fUwiKZJ8O5g6P+1YP45l1z73GALs82IWAu2wW0qJhtb3vQveJOGfz6YWFn+kq1I+Gdt X-Received: by 2002:a17:907:7e8c:b0:6dc:b357:2f4 with SMTP id qb12-20020a1709077e8c00b006dcb35702f4mr22131874ejc.434.1647887253570; Mon, 21 Mar 2022 11:27:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647887253; cv=none; d=google.com; s=arc-20160816; b=Qr0lWJcNG2Z50LaZ43KpFKEJL5D/HryltG6gN44ZyeBGOaYq9k36ZybiMv3DQ+VIvJ e7VRPuNBuhUBEFHs5P1HsowLUwfdqMjZdJzMvAs9xpIa2K1Oi2H8U+jpDDcpC8YoLGyf iCE/nqtmrXY12jMv06kpJKXU0jG0ZdbRsgPU7iKD15srQlotyUydrejlWINI6gox7DXJ fgqn3gcNhsVMsAGdr0nbb+jnh8jpCEi9ZHC/P+8O9UPQ+H+Kjx6YCnhrKjGh/2DFW2CP 88Mj9KmjUhDgGK+GNKoGTKHFDb7OHJxwheTcQ+ytJUmZ+Oj0cPZ0f+14JoITtwavOsgO hfGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=4l1IjK/V6gWCi6L59LMBO2xOXKYClT2IM/sIKlVtEYU=; b=PunSKpbvV2wbWg9a1OWLLm/iejW2zg/eVqD48BPjoSOi6rTKUlMLu37DIC83QQtusv a1Of91h8s1P1dOcOF9Bge8cDeIUPOfpob2+e18bg0sAoociVCSq0acz77+i0LISDKvLY C3RTvXNlmAbp00ekzu+56F6QJm98Fu3uJ1J2RkHxIR1CS83fdmMrT00oMFIHOXeJiVSW xe4BC4QbpqU2agtkZpIQiWg2EtZraJ3VRy6p3BeNi0jaQfM+dDZp1BfjMozjEGyEoc3M Nhz9QEBuYfrjRPzj/Q4Re5mmqPwiouvn+2kgGK5PeSvUS7A80VB8v6RRQ6y/PgMv9FE8 /IyQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a24-20020a509b58000000b00418c2b5bea4si9697016edj.390.2022.03.21.11.27.06; Mon, 21 Mar 2022 11:27:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346097AbiCUJ7W (ORCPT + 99 others); Mon, 21 Mar 2022 05:59:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346091AbiCUJ7S (ORCPT ); Mon, 21 Mar 2022 05:59:18 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C78AD139268; Mon, 21 Mar 2022 02:57:53 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 544A6143D; Mon, 21 Mar 2022 02:57:53 -0700 (PDT) Received: from e123648.arm.com (unknown [10.57.22.222]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7479C3F766; Mon, 21 Mar 2022 02:57:50 -0700 (PDT) From: Lukasz Luba To: linux-kernel@vger.kernel.org Cc: lukasz.luba@arm.com, dietmar.eggemann@arm.com, Pierre.Gondois@arm.com, ionela.voinescu@arm.com, viresh.kumar@linaro.org, rafael@kernel.org, daniel.lezcano@linaro.org, linux-pm@vger.kernel.org, mka@chromium.org, nm@ti.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, cristian.marussi@arm.com, sudeep.holla@arm.com, matthias.bgg@gmail.com Subject: [RESEND][PATCH 2/8] PM: EM: Add artificial EM flag Date: Mon, 21 Mar 2022 09:57:23 +0000 Message-Id: <20220321095729.20655-3-lukasz.luba@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220321095729.20655-1-lukasz.luba@arm.com> References: <20220321095729.20655-1-lukasz.luba@arm.com> X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pierre Gondois The Energy Model (EM) can be used on platforms which are missing real power information. Those platforms would implement .get_cost() which populates needed values for the Energy Aware Scheduler (EAS). The EAS doesn't use 'power' fields from EM, but other frameworks might use them. Thus, to avoid miss-usage of this specific type of EM, introduce a new flags which can be checked by other frameworks. Signed-off-by: Pierre Gondois Signed-off-by: Lukasz Luba --- include/linux/energy_model.h | 5 +++++ kernel/power/energy_model.c | 2 ++ 2 files changed, 7 insertions(+) diff --git a/include/linux/energy_model.h b/include/linux/energy_model.h index 0a3a5663177b..92e82a322859 100644 --- a/include/linux/energy_model.h +++ b/include/linux/energy_model.h @@ -67,11 +67,16 @@ struct em_perf_domain { * * EM_PERF_DOMAIN_SKIP_INEFFICIENCIES: Skip inefficient states when estimating * energy consumption. + * + * EM_PERF_DOMAIN_ARTIFICIAL: The power values are artificial and might be + * created by platform missing real power information */ #define EM_PERF_DOMAIN_MILLIWATTS BIT(0) #define EM_PERF_DOMAIN_SKIP_INEFFICIENCIES BIT(1) +#define EM_PERF_DOMAIN_ARTIFICIAL BIT(2) #define em_span_cpus(em) (to_cpumask((em)->cpus)) +#define em_is_artificial(em) ((em)->flags & EM_PERF_DOMAIN_ARTIFICIAL) #ifdef CONFIG_ENERGY_MODEL #define EM_MAX_POWER 0xFFFF diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c index 0153b0ca7b23..6ecee99af842 100644 --- a/kernel/power/energy_model.c +++ b/kernel/power/energy_model.c @@ -384,6 +384,8 @@ int em_dev_register_perf_domain(struct device *dev, unsigned int nr_states, if (milliwatts) dev->em_pd->flags |= EM_PERF_DOMAIN_MILLIWATTS; + else if (cb->get_cost) + dev->em_pd->flags |= EM_PERF_DOMAIN_ARTIFICIAL; em_cpufreq_update_efficiencies(dev); -- 2.17.1