Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp2188170pxp; Mon, 21 Mar 2022 13:23:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw7tsQmf1UnHtaFCPnherwtHPLdgiazVke7V01Rho5EXjm/fVNhDEmntEL1uq/mPd+Tg2iu X-Received: by 2002:a17:906:3ec9:b0:6bb:2eb9:84f with SMTP id d9-20020a1709063ec900b006bb2eb9084fmr22254973ejj.86.1647894229112; Mon, 21 Mar 2022 13:23:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647894229; cv=none; d=google.com; s=arc-20160816; b=UypRDEA7eLIezdf8K+S+fZ3euAAJ/k8g4+khilHyAfMk+Vcaz/t3a8P34Iinbhzhj3 wgcBc76JBzNOdnbmaXVAj/qTPjdCWAFcpnzRxqw0+9MZyK3E2RFelDqBM+fwM0/v5+Yq dtz9PMfLDasF0PA49Uzu9BKndMgTZUmyAM5FgdVMJxpCksWqLUt9owfd3XVHbODktuw0 L7fL8UoXpnaPhXOoMyS7MhG9mIpwnrLSthn+MRJwBWqFgjq+IHFcR8KgV/E0/EFGxFKg E+xCNQ4WvkEj6+rCmloEn/jSXg0iug76bBOn6dPkQ4BTBbgjUP1QDZ6UzHMVqgF9g87Q SFSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=eI81Cj2MzQaMOBuzQ4GEFQs/9QyzMW3B2HHtrtblKg8=; b=soa6QCr3DQPYT8oihgf717XYPocqTwEGYm1XUaK4H/17xfmK8Qaqb0OToa31mJyK36 WazlJ6rvQbbwN1jJ2Q4cUhl7LX982aORNlJU8Y8L7WUeRPZ80Etjd8k48FQ5SrJQyQsC 7S4sUbSHk6z1QGr8EF5AzZ0/HKAX4GYpqQJY0hVydlSnPlrr6BziRl7XprA59uV6Oacx X1i00HuOzxalpZovQ09Rxq4j2uhc+YFrMc8gAOgIggR9I73hF8qFw68bnOPlHY7rLO8Q oRNXCDbOjQ5NDFS2H2/l/J8v7Z1i5kksdzOSREFBWDyRL6A9qT2JCv54dM8+ZlOo8tW3 jG6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@resnulli-us.20210112.gappssmtp.com header.s=20210112 header.b=YJPfZoOk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hc37-20020a17090716a500b006dfc9b0ea2asi8563705ejc.484.2022.03.21.13.23.23; Mon, 21 Mar 2022 13:23:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@resnulli-us.20210112.gappssmtp.com header.s=20210112 header.b=YJPfZoOk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234246AbiCUJ6I (ORCPT + 99 others); Mon, 21 Mar 2022 05:58:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346064AbiCUJ5o (ORCPT ); Mon, 21 Mar 2022 05:57:44 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B600D137F5D for ; Mon, 21 Mar 2022 02:56:19 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id r22so8627773ejs.11 for ; Mon, 21 Mar 2022 02:56:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eI81Cj2MzQaMOBuzQ4GEFQs/9QyzMW3B2HHtrtblKg8=; b=YJPfZoOkdyk0Tw+7qRPh58EnUzvFx/fTdWHKqFyZmi3tjW/JAmH3VGGB6hObEkNF0f X0RBZ4rFRZjCkceuK4AvtYTZ0Uf/x6DyBNOVb41hXmyMNV+utHkwvIHDTIgqgqbftgdd 5tfiuGzD/H+vzXqPKSHeWCUgJyX0iF+wfruDFv3yDaTNPficgmjOQwYiJ2mzRqvMBanK Sc12hG92iiqKORIdhiqE/vH6cKhFY81FHUJGNeEmPi/hKJjFCZRsmi1FmX8Awapf2jl+ A/8jlPesJR25JMWH2giDPCUb73DyLoEa2UqWyTzzRdAhzUQQyQDJmJg62cUHcy5Zfw4T HndA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eI81Cj2MzQaMOBuzQ4GEFQs/9QyzMW3B2HHtrtblKg8=; b=4BulkFeoRgaURTy5ffgv3PR73bKWs9b+yJP7z5LdH0dHHH9mnzy1ILOldMV/3RZwW/ ZJHwBPdozpdBk5GjhXWJUTLeDls+HFypryhwh6eqGRTOL//rZa1taLtmUcorj3OMDukr zqDnCOkzNAT4EZqG1n7Rn3QSSsDcxe+s4DG0XXLsK6jmKGFwmXPJuNJHn9bidn+hDUAB /FeLl3xE/OsSJFpHpXDF27cNWAWsaOEnOb1vGF1cVTQfSe5nR3vJe48JPpOQ5TzVofYa Ixhpedm/X59mSkokiF8EwDdUnpo/ZQhkSuofyrcJdTuF7yrAWHNXbLsinYIddF6LVxYH 6uQQ== X-Gm-Message-State: AOAM533+jqXE4q723HigE7GFBRf3oZkITSSRgVWXdG71zLeHpNePNx77 iuEcXpS2H2eCt3vUP6LjXKlE6g== X-Received: by 2002:a17:907:971f:b0:6df:a42d:7b00 with SMTP id jg31-20020a170907971f00b006dfa42d7b00mr17609349ejc.159.1647856577608; Mon, 21 Mar 2022 02:56:17 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id z13-20020a17090674cd00b006df78d85eabsm1898054ejl.111.2022.03.21.02.56.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 02:56:17 -0700 (PDT) Date: Mon, 21 Mar 2022 10:56:16 +0100 From: Jiri Pirko To: Sun Shouxin Cc: j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, yoshfuji@linux-ipv6.org, dsahern@kernel.org, oliver@neukum.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, huyd12@chinatelecom.cn Subject: Re: [PATCH v5 4/4] net:bonding:Add support for IPV6 RLB to balance-alb mode Message-ID: References: <20220321084704.36370-1-sunshouxin@chinatelecom.cn> <20220321084704.36370-5-sunshouxin@chinatelecom.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220321084704.36370-5-sunshouxin@chinatelecom.cn> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mon, Mar 21, 2022 at 09:47:04AM CET, sunshouxin@chinatelecom.cn wrote: >This patch is implementing IPV6 RLB for balance-alb mode. As I stated in the other thread, I strongly believe it is bad idea to add this code. It is not needed. User should use LACP and not obscure ALB/RLB mode. It should not be extented. On contrary, I would like to see this going opposite direction and eventually remove ALB/RLB mode from bonding.