Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220124121009.108649-1-alistair@alistair23.me>
 <20220124121009.108649-6-alistair@alistair23.me> <CAMuHMdUe-z-6_=W5AFtWMug-cqTZKJhd-iLbdoRnSKoXwm27Uw@mail.gmail.com>
In-Reply-To: <CAMuHMdUe-z-6_=W5AFtWMug-cqTZKJhd-iLbdoRnSKoXwm27Uw@mail.gmail.com>
From:   Alistair Francis <alistair23@gmail.com>
Date:   Mon, 21 Mar 2022 17:34:00 +1000
Message-ID: <CAKmqyKNtE8=Jna78+L2a8BwsgM+LZVPi4ppg8Z0RGJ-21RqPtw@mail.gmail.com>
Subject: Re: [PATCH v18 5/8] hwmon: sy7636a: Add temperature driver for sy7636a
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Alistair Francis <alistair@alistair23.me>,
        Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Sascha Hauer <kernel@pengutronix.de>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Lee Jones <lee.jones@linaro.org>,
        Linux PM list <linux-pm@vger.kernel.org>,
        linux-hwmon@vger.kernel.org,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, NXP Linux Team <linux-imx@nxp.com>,
        Zhang Rui <rui.zhang@intel.com>,
        Amit Kucheria <amitk@kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Andreas Kemnade <andreas@kemnade.info>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Guenter Roeck <linux@roeck-us.net>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Mar 8, 2022 at 9:21 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Alistair,
>
> On Mon, Jan 24, 2022 at 1:25 PM Alistair Francis <alistair@alistair23.me> wrote:
> > This is a multi-function device to interface with the sy7636a
> > EPD PMIC chip from Silergy.
> >
> > Signed-off-by: Alistair Francis <alistair@alistair23.me>
> > Acked-by: Guenter Roeck <linux@roeck-us.net>
>
> Thanks for your patch, which is now commit de34a40532507814 ("hwmon:
> sy7636a: Add temperature driver for sy7636a") in mfd/for-mfd-next.
>
> > --- a/drivers/hwmon/Kconfig
> > +++ b/drivers/hwmon/Kconfig
> > @@ -1672,6 +1672,15 @@ config SENSORS_SIS5595
> >           This driver can also be built as a module. If so, the module
> >           will be called sis5595.
> >
> > +config SENSORS_SY7636A
> > +       tristate "Silergy SY7636A"
> > +       help
> > +         If you say yes here you get support for the thermistor readout of
> > +         the Silergy SY7636A PMIC.
>
> As this is an i2c mfd device, you do need a dependency on MFD and I2C,
> or some other symbol, unless compile-testing?

It doesn't depend on either to build though. It can be built independently.

Alistair

>
> > +
> > +         This driver can also be built as a module.  If so, the module
> > +         will be called sy7636a-hwmon.
> > +
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds