Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Sat, 19 Mar 2022 12:24:14 +0800
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Tony Nguyen <anthony.l.nguyen@intel.com>
Cc:     Jesse Brandeburg <jesse.brandeburg@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ice: use min() to make code cleaner in ice_gnss
Message-ID: <YjVa7rJx7TuIo4gm@myhostname>
References: <20220318094629.526321-1-wanjiabing@vivo.com>
 <8822dfa2-bdb8-fceb-e920-94afb50881e8@intel.com>
Content-Type: multipart/mixed; boundary="+du2xvKkY8mMwSr8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8822dfa2-bdb8-fceb-e920-94afb50881e8@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QnVwMlM5UTduSkN5dER3YWllSGd6VjhlZHBhYXpodVJpN1hPaEU3VDQzWFdi?=
 =?utf-8?B?dDA4czNBbWFzMWRyNU5sZWlncTloWjhLZC9ybllnR3NramEvQ2VRdEFRREI1?=
 =?utf-8?B?V3J3QzVsVnNLVHJ0OFJ1MExja2hDTElHOGg1b0kwQWYxcHc5ZGtZWDUrWlRV?=
 =?utf-8?B?aDVMZko4RXpEU0hkMGowRzdJTElBOUZVVXE3QUU3Y0FrUVd4cGdQbGNtTVZ1?=
 =?utf-8?B?b2pPdmJOY05qVUJmRWVBbTRIUk96aEVSdTBFUFlpeUJmMnZJYjRxMVovK2lU?=
 =?utf-8?B?Z283aXh1NXpDTEJNRXYwUjc4MUNYVXhpKzZPVjlIenpyay9zcjM4TFVFOStZ?=
 =?utf-8?B?ZVhTVmNXYzdtWDd3Wnp2MCtHMlB6SzZtTVVQSnoxbHVJOTFjbTk0TkVsK0Jq?=
 =?utf-8?B?N2RjckNLbjFVS0JiNko1aTVVcUUwUjA3ak9SOWp1UGFwQ25laytPb2M0TXcv?=
 =?utf-8?B?NVJBTXpsTm1aZDNJR0JIYjBDeUw3eW0wYStqWFB4VTU5c2RZL0x6YTRmUCtu?=
 =?utf-8?B?UHUzVkRZUDFhOTE0TkhNakVGL3dkUHk3cHRvbDRrUVlyR1N2c0JITlZXUDkw?=
 =?utf-8?B?S0RFWEpKVUwyb2Vnd3JKSkx1bFFSU2U4T0tpVTI1ai9wamRFcURIYWs2bHJN?=
 =?utf-8?B?QjQ5MlNkSjZMc0FBQ3RSUlZ3WEdMdndIMjFBUldwdGlRRUtFWWtQQ0xTTGZ3?=
 =?utf-8?B?aHNGdFpGcFl5dHc2UXQyUUpSS2dKbDRJQm1BVHBPS09WclM1di9sVlZlSk82?=
 =?utf-8?B?WUdVcDl4d3FBWGhxSUNaL0ZUcG9pN1ZxclF3T2NncEZRMzNScU51ZlNlRmc2?=
 =?utf-8?B?eERya3ZnZTVGNUpaODJSM3hyNWdvZ3RXblAvcVpnWVBEOHNTb21LN2pjOGY1?=
 =?utf-8?B?NTJ0eEQyUXZJQ2FNN2NQeFVPdlF3eEN2NjdMYU5YNXpTdTFpYytZTGdOU1NH?=
 =?utf-8?B?S1pHTDhhUGJUSTdXVmtEV3lEU01ZKzRhMXpORVU4djNyQWxnL25SN1V5WlNC?=
 =?utf-8?B?bWNQNnZxdEpJMTlYMiswdGtCYi9OMHFFQ1NBWlcrc0dXSGpSMVVTT29vTUYy?=
 =?utf-8?B?VDE1UURXOFlmSjRsS3VjOEF3WnpxakdxV3RHdmN1ZVdXZ3JSZ1hrcXZuQzlG?=
 =?utf-8?B?RkZPNDUyeHBWUlo3QkN0Z05EdU9CVnVXU1hqS1Z4TUxxQmREc0F5S1k3UGwv?=
 =?utf-8?B?ekxnZlpkcFJpS0U0Y0F6aGFoTS9Qek00NkRVNDFpY2ErcmgxSUxLaGR1L29x?=
 =?utf-8?B?VENacHQzZGh5ZnAzL2RTRjJDZU1tNGRWRkVJeVBXRHRqUUVobkZFUU0rRCtQ?=
 =?utf-8?B?WnA2VGJGeENuV1JPOXhhazNQaVRKMHhrcERqVnVQSDJ2cE10ODZQY2lJYVY3?=
 =?utf-8?B?UFhDb1k1VTJwVVBtSWI5Znh1bFNkK2wwZWFNaGxBZzBnaFppbFBiSG1lcmdW?=
 =?utf-8?B?TkFCNmNHclFwWGYyajBjU000SzJPV0M4dzhHajJUVkZITDhPMGRzU0ZtUXhy?=
 =?utf-8?B?SGNTTnBXK293SVlrTWtnVjhGNFJLKzRjUDJzWmdtZm9NVTk3WGNzOUhUMUlB?=
 =?utf-8?B?S1hBa1E2UXlLOTk4TGJVUnNiQWNTTi8wNVJvVjU1NXhkSnR6MmpJT2xVRWx0?=
 =?utf-8?B?NlYyZXRYVDlaSHRQcEpXUW9EMzZCRm9BakpkRVlqWFlySnpMbkdOL1J5UFFx?=
 =?utf-8?B?WldLbEw0KytxWkZQVDJ6OUxYTjdZd1l5N0Joay9qd3JTSEt2UmxCUXMycnFm?=
 =?utf-8?B?MHV5TVZoMGtXZHdReTRsdXl0SUUwYVdFV0pxWFgzaUFwSFpCWEowUDVZYUJx?=
 =?utf-8?B?aDVNTFdFb0F2V2pJUldacEp4SkEzM0hlemxCS3VQdUp1RTFiaSsyUThxaVRD?=
 =?utf-8?B?czl3bFI0bjQ1QVVtMUJVQUlMSnRiT1dyVytCRlEyWnMrai95SmNoRnFUZEs1?=
 =?utf-8?Q?ssS96RuZDAEiPa8tEnYOZxZpwKiB6g4v?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6097a341-5275-4bed-8280-08da09605429
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2022 04:24:16.5019
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0MKQ9GqObEAWAmNaeKaVLZ3ndgqEGM3SpAoGvSxSLukZARZdyPxfgFsu2nLC5aMBEawdCs/47oCTjYYywF3p5A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB5147
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--+du2xvKkY8mMwSr8
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On Fri, Mar 18, 2022 at 01:19:26PM -0700, Tony Nguyen wrote:
> 
> On 3/18/2022 2:46 AM, Wan Jiabing wrote:
> > Fix the following coccicheck warning:
> > ./drivers/net/ethernet/intel/ice/ice_gnss.c:79:26-27: WARNING opportunity for min()
> > 
> > Use min() to make code cleaner.
> > 
> > Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> 
> There are build issues with this patch:
> 
> In file included from ./include/linux/kernel.h:26,
>                  from drivers/net/ethernet/intel/ice/ice.h:9,
>                  from drivers/net/ethernet/intel/ice/ice_gnss.c:4:
> drivers/net/ethernet/intel/ice/ice_gnss.c: In function ‘ice_gnss_read’:
> ./include/linux/minmax.h:20:35: error: comparison of distinct pointer types
> lacks a cast [-Werror]
>    20 |         (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
>       |                                   ^~
> ./include/linux/minmax.h:26:18: note: in expansion of macro ‘__typecheck’
>    26 |                 (__typecheck(x, y) && __no_side_effects(x, y))
>       |                  ^~~~~~~~~~~
> ./include/linux/minmax.h:36:31: note: in expansion of macro ‘__safe_cmp’
>    36 |         __builtin_choose_expr(__safe_cmp(x, y), \
>       |                               ^~~~~~~~~~
> ./include/linux/minmax.h:45:25: note: in expansion of macro ‘__careful_cmp’
>    45 | #define min(x, y)       __careful_cmp(x, y, <)
>       |                         ^~~~~~~~~~~~~
> drivers/net/ethernet/intel/ice/ice_gnss.c:79:30: note: in expansion of macro
> ‘min’
>    79 |                 bytes_read = min(bytes_left, ICE_MAX_I2C_DATA_SIZE);
>       |                              ^~~
> cc1: all warnings being treated as errors
> 

Yes, sorry for the warning.

After check minmax.h, it's better to use min_t and there are no warnings.

Please check the new patch, thanks!

Wan Jiabing

--+du2xvKkY8mMwSr8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename="0001-ice-use-min_t-to-make-code-cleaner-in-ice_gnss.patch"

From 43118a4f14393816054a41e4861106cdb623b3d9 Mon Sep 17 00:00:00 2001
From: Wan Jiabing <wanjiabing@vivo.com>
Date: Sat, 19 Mar 2022 12:01:29 +0800
Subject: [PATCH] ice: use min_t() to make code cleaner in ice_gnss

Fix the following coccicheck warning:
./drivers/net/ethernet/intel/ice/ice_gnss.c:79:26-27: WARNING opportunity for min()

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/net/ethernet/intel/ice/ice_gnss.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_gnss.c b/drivers/net/ethernet/intel/ice/ice_gnss.c
index 35579cf4283f..85ceb7018781 100644
--- a/drivers/net/ethernet/intel/ice/ice_gnss.c
+++ b/drivers/net/ethernet/intel/ice/ice_gnss.c
@@ -76,8 +76,7 @@ static void ice_gnss_read(struct kthread_work *work)
 	for (i = 0; i < data_len; i += bytes_read) {
 		u16 bytes_left = data_len - i;
 
-		bytes_read = bytes_left < ICE_MAX_I2C_DATA_SIZE ? bytes_left :
-					  ICE_MAX_I2C_DATA_SIZE;
+		bytes_read = min_t(u8, bytes_left, ICE_MAX_I2C_DATA_SIZE);
 
 		err = ice_aq_read_i2c(hw, link_topo, ICE_GNSS_UBX_I2C_BUS_ADDR,
 				      cpu_to_le16(ICE_GNSS_UBX_EMPTY_DATA),
-- 
2.35.1


--+du2xvKkY8mMwSr8--