Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp2225864pxp; Mon, 21 Mar 2022 14:19:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyIhh1Gg+8vrhEzDkZmSW1Ar0S9GZ8biAhaaE9BnTg6vHuWxZXfCrs9OVj1gBXYd4GjmrFb X-Received: by 2002:a17:903:40c4:b0:154:3ffd:77f7 with SMTP id t4-20020a17090340c400b001543ffd77f7mr10655663pld.36.1647897569571; Mon, 21 Mar 2022 14:19:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647897569; cv=none; d=google.com; s=arc-20160816; b=lzxFFZ7DlrYwwwZ2qot56YaYSeM573zV6An3G136BkDT2ZdxwnGWTvltfh9j/EpJrq DZtPNMfeblzJjze1D4AlKVy5//E0ReRfrRrcl+qmIf4H/b2Ox4Iop0W4zfuLMQgPVhx/ Stzbl34kafgVd7s4bJKeRCzTBghGzRYEu1R41CjKGB1m/L09e7PES4rCkLSKRBX3OQN3 mHwlUq2aVbr2lILvOEb01kf25IHUbbpo5/ktphero+zT5XufWqgZ9wK8hefFAYIR/gOb V3COh22vc3naHUkv9M2vEMcZvZFIjAtUQZuF56aQCP7fsBArQ7sYK6JepdgPNjhpdkrT +lqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=cO7AjDjeJIy5Qpw0zFf/SmS51/Q6KU0hyMEE6k8MFjw=; b=yRJlvWFXQhFzGnc063BfjjaukanoXjNREGyu1j+S0ZK0bloYm1EFkoMWvxhUdXt2mj 2Ttda5fvUPLFdoSgX3PQ39w3s+092hbwlTUpikEiR3Cem0Oz3XLNfxL7P6ZcesvE5oJ4 N3RJcnwwWQH0M+84PA7VeNn5UE1h2mkzKzZQiJGDlyWyn77ZMSwIoh4TG4xldNFcBFnN Km1gj4mZmAcFV9kEzqITvL5bXuaOF/ertb1Svol52Y3zMHoDJkoFI2kWhmp7ijMeM+i/ p7u/JZaq7pN65fqTU5oyKNQBPaO6UA2k1MkHzZ5dmt+zBNs7FOjq4RqdlCSnHP1F1wiY n1qg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OfbaYY90; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id r10-20020a170902c7ca00b00153b2d165bcsi10807659pla.452.2022.03.21.14.19.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 14:19:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OfbaYY90; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 331EA1DB3C8; Mon, 21 Mar 2022 14:06:22 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345488AbiCUI5N (ORCPT + 99 others); Mon, 21 Mar 2022 04:57:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345482AbiCUI5M (ORCPT ); Mon, 21 Mar 2022 04:57:12 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD44F57485 for ; Mon, 21 Mar 2022 01:55:46 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id m30so9836848wrb.1 for ; Mon, 21 Mar 2022 01:55:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=cO7AjDjeJIy5Qpw0zFf/SmS51/Q6KU0hyMEE6k8MFjw=; b=OfbaYY90jqR7DZF9ctMaTAQhlRWGusytHu/XNiNObeiYtmHyF40LM79m3mobnIWzkX 7IaRCKvT5utAMqKrDRB8T46NX85oH4k6klPz6aGfQRsYVhOMLLtxHNGc0V19PgrW0ae8 Pboo5lIrHEMt3tsiVJ7uz7Wc8ttkL8UlHJ6Ol+wCOHPRJZLv5uCAa0xDEzNgV+qhJq8a k17NOHYSoeL9QQhc0qwItq4tKcqUXiILGTSmQDT5lZb6ktmgqda0JhkN2ZBD+EEHzcDu IwDx5ZeRHpUoLXssdAyhyIv2m1o/LihvJRQiP/3HF0uTkPkkFd4SEs4ulyy6wLKulwFI 5sLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=cO7AjDjeJIy5Qpw0zFf/SmS51/Q6KU0hyMEE6k8MFjw=; b=kgSttI09kAeD4h2ZNmvqmtoseBmydZdEyZdtJdhh4oSMsGyIgpe+xbiIvXcREvFnEh ZsHbDAkN8w+Ne9q364vyu73upXegcvwN+wsJ9n4ZPXz3EyJHcyOm0v5aSy0hHyqFb71y Ctyz6KifxQzGN7VEW4ROnts2G0O1QY2S7rti9VqALEEMkm+nNi21u6xIVkuw4/cujD5Z LcTb054to5AbF8RYPHxU8wkLrx/RkUaPOCAukYxwrMpvjc9IN0InTJ69bxD3swjwQSRR SkA0blVDNodY/Iscw/xavwpkCccoPMz3UQcrMx+S0xgjlCMy21Dg3vwNWHjsHPJsZT8F 7YWg== X-Gm-Message-State: AOAM531TnORXajXhODCuNbrZ/MyY+yX8JrRiPRkkf+c8yKwrsk2+KvKL HFjGsK/lWQ2EWW1oTG7apmHTXjAlrv/hAw== X-Received: by 2002:a5d:5148:0:b0:203:d72f:cea2 with SMTP id u8-20020a5d5148000000b00203d72fcea2mr17118105wrt.306.1647852945334; Mon, 21 Mar 2022 01:55:45 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id k40-20020a05600c1ca800b0038c6c8b7fa8sm14563408wms.25.2022.03.21.01.55.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 01:55:44 -0700 (PDT) Date: Mon, 21 Mar 2022 08:55:43 +0000 From: Lee Jones To: Miaoqian Lin Cc: Magnus Damm , Ian Molton , Samuel Ortiz , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: asic3: Add missing iounmap() on error asic3_mfd_probe Message-ID: References: <20220307072947.5369-1-linmq006@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220307072947.5369-1-linmq006@gmail.com> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 07 Mar 2022, Miaoqian Lin wrote: > Add the missing iounmap() before return from asic3_mfd_probe > in the error handling case. > > Fixes: 64e8867ba809 ("mfd: tmio_mmc hardware abstraction for CNF area") > Signed-off-by: Miaoqian Lin > --- > drivers/mfd/asic3.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog