Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp2226142pxp; Mon, 21 Mar 2022 14:19:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzCCsabPvjkaJY2vFlPii+KeV4SG5GvEpU1H82R4eSDNCsgqiDR+3lkTvrnKy/VscK6M7c/ X-Received: by 2002:a17:902:e551:b0:154:48d5:4212 with SMTP id n17-20020a170902e55100b0015448d54212mr9410535plf.5.1647897597913; Mon, 21 Mar 2022 14:19:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647897597; cv=none; d=google.com; s=arc-20160816; b=CZFOxEAd2jZmqaTxOIYCPmAVPLH6nH5DT7aSqgBHGKLO7ojLWwMQiHtzVdFoVv+PIy wAIRTW39xoU6AwCQWbeJDKyAPk2jgzowXfs34f3XFGZindAWNpltJEDwqDxcoQmqEB2i Qu65ir8VWPQmGVYnuduohO+Q9dr7OpX8IOjeQ62K3/OfQoBvnIE8d5pYXCSziw/deCh1 ygfm/4K0ctNRgYkPFgqm0j9ODd9vdfGVNTdCDN6Lv6OC62lCX7BTnuGyD3e5snpKYe4g hhhxfRI9lsgMyoMDdVSIm2vssmjtTb4x+FiuYI4JpOmtJgi5JuxWz/QxzawXuX7AuE+3 fb6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=1Dg5Wey2143VbCqVuHaJX4vgNuLYVVkZS6cXSogoU5c=; b=z0HxAElv99O1zUdRI+N+e7vcz2uQOLVfySu4p3fYl/pT29T+zz027Dssi1mDgaOge1 Gnskv5T6jku7pdvyj32Yq64zuLxy98nXhgnEQlBjcL1DVoEXtev2/CdIY3HRnAH0xcGq CtRlFEZb1Ru45lSG8GRNr1FHxJBXyX7x5JKMg2GhSc2isKSLxZ4FxiXLaMjf5foiL3NG E2/7o0V++ZfA+SRLBALHNReNpfFpFWCkVira4tr2tYz0tvMCR8Vw8AvUUzMz0lKo1y3G uZJjsfLRCDRDYs2IjdmbJO2N2rFeBofHUNB39Ch/UyXMCm2Ey8t0a+LGQIs8zsDTdxlB QAZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qMJEj8Zo; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id b5-20020a17090a488500b001c7469269b5si346580pjh.56.2022.03.21.14.19.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 14:19:57 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qMJEj8Zo; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 685A61B0863; Mon, 21 Mar 2022 14:07:07 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344982AbiCUOew (ORCPT + 99 others); Mon, 21 Mar 2022 10:34:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349846AbiCUOdK (ORCPT ); Mon, 21 Mar 2022 10:33:10 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6DCDA1AF; Mon, 21 Mar 2022 07:30:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 019D0B8170B; Mon, 21 Mar 2022 14:30:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22526C340EE; Mon, 21 Mar 2022 14:30:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647873028; bh=BJoJxM62oVu3PvwNK+c15fauttUCWAVfzzp/YPFUujo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qMJEj8Zo3BFaBw5Q+l5pug8Oa22PK9dZbWcMe5AZda5rqrEYZ9Q0GqaeZYcv6+vY0 hWLJ/CgZbWa1zThm38J7rqx0Qn2DSBAUKLS1squ35QlSdse+oWuIHOXT/LF4V1JzAx /3J374DD0Ze1ReNwYDnSDVRhfdgPSt4acP5ab1efSe4YY8SZrusWmMX+eqlIXHw2qn QwAqDNyi5hKLk3Em2C761jdzMrwE1znLJU7qDV6YR1/HxqATZ4pBrW1RB9FpqAlyRz g7v6Jfh4CdtdXjXA5SOZBZ7BLx9odpD2PRdGtyTmkiu9ntV+iCKPvSz/mCPx7xozeS X+Qam1RbisLAQ== Date: Mon, 21 Mar 2022 14:30:22 +0000 From: Will Deacon To: Sudeep Holla Cc: Darren Hart , Greg Kroah-Hartman , Dietmar Eggemann , Vincent Guittot , LKML , Linux Arm , "Rafael J. Wysocki" , Catalin Marinas , Peter Zijlstra , Valentin Schneider , "D . Scott Phillips" , Ilkka Koskinen , stable@vger.kernel.org, Barry Song <21cnbao@gmail.com> Subject: Re: [PATCH v3] topology: make core_mask include at least cluster_siblings Message-ID: <20220321143021.GB11145@willie-the-truck> References: <7ac47c67-0b5e-5caa-20bb-a0100a0cb78f@arm.com> <9398d7ad-30e7-890a-3e18-c3011c383585@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 16, 2022 at 03:55:41PM +0000, Sudeep Holla wrote: > On Wed, Mar 16, 2022 at 08:20:32AM -0700, Darren Hart wrote: > > On Wed, Mar 16, 2022 at 03:48:50PM +0100, Dietmar Eggemann wrote: > > [...] > > > > > > > Yeah, I can see your point. It's the smaller hack. My solution just > > > prevents us to manipulate the coregroup mask only to get the MC layer > > > degenerated by the core topology code. But people might say that's a > > > clever thing to do here. So I'm fine with your original solution as well. > > > > > > [...] > > > > Thanks Dietmar, > > > > Sudeep, do we have sufficient consensus to pull in this patch? > > Indeed. I have already Acked, and sure after all these discussions we have > concluded that this is the best we can do though not matches everyone's taste. > > Greg or Will(not sure why he had asked since v3 doesn't touch arm64), > Can one of you pick this patch ? Right, this doesn't touch arm64 any more so I don't think I'm the right person to queue it. Will