Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp2236610pxp; Mon, 21 Mar 2022 14:36:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQpjjlGoODonmNnh0O9NMx6WpxVVSWdx5x4MPgYBvrxj4PMEecqENF2XmEciNsBUs2/1PL X-Received: by 2002:a17:902:c242:b0:154:4f3f:ec6a with SMTP id 2-20020a170902c24200b001544f3fec6amr8073379plg.121.1647898585523; Mon, 21 Mar 2022 14:36:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647898585; cv=none; d=google.com; s=arc-20160816; b=vX+YJwm46SNXq0amWCc4lXrMOVxmKmL3BCl8omfOytFu18V1IQVpni9+gNjec1ZXpn PyszaU4hwSk/TgCtT4+AoeIfR1AqXC9Fmi3L+I67CVWwILCoSdUAfOrgbwfK/qnMj6au UJ5rJGMbPAnQkQnHsj7J4vudwIaDSF0kZQ16ssuQqFRxSBWnzHGQ4DNaANAZoR4xwyY0 XKQPTlFlpcyyauERn7AWQVgqk9ZFHGNxBbHJ2FIPnPZgIwuJ0U3742tbSegGfq3dFJU9 GSez5L1smVZycnR56/AKRy/FcjM43DL7xku3qI+nUndkl66QNh6lQaNIarBz8+o7c3I3 gSEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=lLJQ7vulm+2L7PzxxfXWEKCcufG4UX0PnfvTDr8GlpM=; b=N+homZi00GWVQNWtokoBZg23H1ur8y9hq0d9j/sJVJuqXcBakOIiyA5/ZWpvRW0wie 5AwjP+KplV+JSXGdL3Ct0idJgMlwnxtmUxy3Euce2nqP5QmrBPLUWN0dIn+7EGbJu7cT YggKWKnc3xqSafM0znEsOJYK5xA5t+9eYff4S4mAZKSap9EkENO3Oy6QiGDSVk5NoXuC h5mAaWn6uZ2cTML/KvC9fdMN9AIAmtghSNt34nHylk9mkuwaNOZKbF9DU6GAVMfPpOKu 38jtYIPHoWCDxj+ns25eEmJPfbTfywodKsjjSyp7U8ehsp711lS2NkAJ4yexsaGcULyK 2JPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="Ie2uN4/4"; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id r9-20020a632049000000b003816043ee80si13870660pgm.117.2022.03.21.14.36.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 14:36:25 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="Ie2uN4/4"; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5B00A2571A3; Mon, 21 Mar 2022 14:13:07 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345924AbiCUJd6 (ORCPT + 99 others); Mon, 21 Mar 2022 05:33:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238396AbiCUJd4 (ORCPT ); Mon, 21 Mar 2022 05:33:56 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BE0555755; Mon, 21 Mar 2022 02:32:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 1127BCE1281; Mon, 21 Mar 2022 09:32:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03C76C340E8; Mon, 21 Mar 2022 09:32:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1647855148; bh=3TpisNXZrIjMUtHPVMXBUyOBKnyj9MiqrvAw+qDS5KA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ie2uN4/4NPOtK+25pNl+b5reXwnxOLMQSuhkhLzsLtRqA23qGEfMdX5TdK9jc9kW5 gXbuz9JAmKIY60YNvtahRZUDAZ5j3z0RR5R3Ooz4alOoCv6NTOdX6MCipBfkczw3YC EjuvOiP0wUVTFav16fKZbjkoNW+EBBfNPJ5Wee1w= Date: Mon, 21 Mar 2022 10:32:25 +0100 From: Greg Kroah-Hartman To: Jung Daehwan Cc: Mathias Nyman , "open list:USB XHCI DRIVER" , open list , Howard Yen , Jack Pham , Puma Hsu , "J . Avila" , sc.suh@samsung.com Subject: Re: [PATCH v3 0/4] support USB offload feature Message-ID: References: <1647853194-62147-1-git-send-email-dh10.jung@samsung.com> <20220321092409.GA62265@ubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220321092409.GA62265@ubuntu> X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 21, 2022 at 06:24:09PM +0900, Jung Daehwan wrote: > On Mon, Mar 21, 2022 at 10:14:23AM +0100, Greg Kroah-Hartman wrote: > > On Mon, Mar 21, 2022 at 05:59:50PM +0900, Daehwan Jung wrote: > > > This patchset is for USB offload feature, which makes Co-processor to use > > > some memories of xhci. Especially it's useful for USB Audio scenario. > > > Audio stream would get shortcut because Co-processor directly write/read > > > data in xhci memories. It could get speed-up using faster memory like SRAM. > > > That's why this gives vendors flexibilty of memory management. > > > Several pathches have been merged in AOSP kernel(android12-5.10) and I put > > > together and split into 3 patches. Plus let me add user(xhci-exynos) > > > module to see how user could use it. > > > > > > To sum up, it's for providing xhci memories to Co-Processor. > > > It would cover DCBAA, Device Context, Transfer Ring, Event Ring, ERST. > > > It needs xhci hooks and to export some xhci symbols. > > > > > > Changes in v2 : > > > - Fix commit message by adding Signed-off-by in each patch. > > > - Fix conflict on latest. > > > > > > Changes in v3 : > > > - Remove export symbols and xhci hooks which xhci-exynos don't need. > > > - Modify commit message to clarify why it needs to export symbols. > > > - Check compiling of xhci-exynos. > > > > As I asked for in the previous submission, you MUST have a user for > > these hooks, otherwise we can not accept them (nor would you WANT us to > > accept them). Please fix that up and add them to the next submission as > > we can not do anything with this one. > > > > thanks, > > > > greg k-h > > > > Hi greg, > > I've submitted the user(xhci-exynos) together on the last patch of the patchset. > You can see xhci-exynos uses these hooks and symbols. > > [PATCH v3 4/4] usb: host: add xhci-exynos driver Then this is not "offload" hooks at all. They are merely "support another xhci platform driver, right? I see a lot of exports and function hooks added, are they _ALL_ used by the xhci driver? If so, please reword this series as it is not very obvious at all what you are doing. thanks, greg k-h