Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Mon, 21 Mar 2022 19:29:11 +1100 (AEDT)
From:   Finn Thain <fthain@linux-m68k.org>
To:     Christophe Leroy <christophe.leroy@csgroup.eu>
cc:     Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Randy Dunlap <rdunlap@infradead.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] macintosh/via-pmu: Fix build failure when CONFIG_INPUT
 is disabled
In-Reply-To: <5291a177-9a67-b23a-515f-7faa3cc887e8@csgroup.eu>
Message-ID: <e8398356-8ba3-e9de-8da0-3591907340b5@linux-m68k.org>
References: <d987663bbed18d7dbf106db6066a759040b4e57a.1647837028.git.fthain@linux-m68k.org> <5291a177-9a67-b23a-515f-7faa3cc887e8@csgroup.eu>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="-1463811774-1060938498-1647851351=:12278"
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

---1463811774-1060938498-1647851351=:12278
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Mon, 21 Mar 2022, Christophe Leroy wrote:

>=20
>=20
> Le 21/03/2022 =C3=A0 05:30, Finn Thain a =C3=A9crit=C2=A0:
> > drivers/macintosh/via-pmu-event.o: In function `via_pmu_event':
> > via-pmu-event.c:(.text+0x44): undefined reference to `input_event'
> > via-pmu-event.c:(.text+0x68): undefined reference to `input_event'
> > via-pmu-event.c:(.text+0x94): undefined reference to `input_event'
> > via-pmu-event.c:(.text+0xb8): undefined reference to `input_event'
> > drivers/macintosh/via-pmu-event.o: In function `via_pmu_event_init':
> > via-pmu-event.c:(.init.text+0x20): undefined reference to `input_alloca=
te_device'
> > via-pmu-event.c:(.init.text+0xc4): undefined reference to `input_regist=
er_device'
> > via-pmu-event.c:(.init.text+0xd4): undefined reference to `input_free_d=
evice'
> > make[1]: *** [Makefile:1155: vmlinux] Error 1
> > make: *** [Makefile:350: __build_one_by_one] Error 2
> >=20
> > Don't call into the input subsystem unless CONFIG_INPUT is built-in.
> >=20
> > Reported-by: kernel test robot <lkp@intel.com>
> > Cc: Michael Ellerman <mpe@ellerman.id.au>
> > Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> > Cc: Randy Dunlap <rdunlap@infradead.org>
> > Signed-off-by: Finn Thain <fthain@linux-m68k.org>
> > ---
> > This is equivalent to the patch I sent a couple of days ago. This one
> > is slightly longer and adds a new symbol so that Kconfig logic can been
> > used instead of Makefile logic in case reviewers prefer that.
> > ---
> >   drivers/macintosh/Kconfig   | 5 +++++
> >   drivers/macintosh/Makefile  | 3 ++-
> >   drivers/macintosh/via-pmu.c | 2 ++
> >   3 files changed, 9 insertions(+), 1 deletion(-)
> >=20
> > diff --git a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig
> > index 5cdc361da37c..b9102f051bbb 100644
> > --- a/drivers/macintosh/Kconfig
> > +++ b/drivers/macintosh/Kconfig
> > @@ -67,6 +67,11 @@ config ADB_PMU
> >   =09  this device; you should do so if your machine is one of those
> >   =09  mentioned above.
> >  =20
> > +config ADB_PMU_EVENT
> > +=09bool
> > +=09depends on ADB_PMU && INPUT=3Dy
> > +=09default y
>=20
> Could be reduced to
>=20
> config ADB_PMU_EVENT
> =09def_bool y if ADB_PMU && INPUT=3Dy
>=20

That's great but my question remains unanswered: why the aversion to=20
conditionals in Makefiles, when that would be simpler (no new symbol)?
---1463811774-1060938498-1647851351=:12278--